java, simplify openai client.tsp#26699
Merged
weidongxu-microsoft merged 6 commits intomainfrom Nov 15, 2023
Merged
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Nov 14, 2023
4b13e2a to
212d94d
Compare
6 tasks
6 tasks
Member
|
What version of Java autorest are we using in Edit: it seems like |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mssfang
approved these changes
Nov 15, 2023
…ered from public operation getChatCompletions
XiaofeiCao
reviewed
Nov 15, 2023
| generate-tests: false | ||
| custom-types-subpackage: "implementation.models" | ||
| custom-types: "FunctionCallModelBase,FunctionCallPreset,FunctionCallPresetFunctionCallModel,FunctionNameFunctionCallModel" | ||
| custom-types: "FunctionCallPreset" |
Contributor
There was a problem hiding this comment.
What's the effect of this change?
Member
Author
There was a problem hiding this comment.
It moves this model to impl. Maybe we can use @internal
XiaofeiCao
approved these changes
Nov 15, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 15, 2023
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify client.tsp for Java emitter.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links