[TypeSpec] Upgrade to 0.49.0 (#26200) #26203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmhelprp
requested review from
a team,
Kishp01,
ahamad-MS,
alvinli222,
circy9,
konrad-jamrozik,
matthchr,
mikeharder,
palma21,
weinong and
weshaggard
as code owners
jkmhelprp
requested review from
bexxx and
vicancy
and removed request for
a team
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Insights/myWorkbooks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/applicationinsights/resource-manager/readme.md json: Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Insights/myWorkbooks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/applicationinsights/resource-manager/readme.md json: Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Insights/myWorkbooks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/applicationinsights/resource-manager/readme.md json: Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json |
|
The API version of the swagger is inconsistent with its file path. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/common/v5/definitions.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/dscCompilationJob.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/dscNode.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/watcher.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/webhook.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/dscNodeCounts.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/softwareUpdateConfiguration.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/deletedAutomationAccount.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/privateEndpointConnection.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/privateLinkResources.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Automation/automationAccounts/{}/listDeletedRunbooks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/account.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Automation/automationAccounts/{}/runtimeEnvironments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/runtimeEnvironment.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Automation/automationAccounts/{}/runtimeEnvironments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/automation/resource-manager/readme.md json: Microsoft.Automation/preview/2023-05-15-preview/runtimeEnvironment.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/clusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/clusters.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/clusters.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/clusters.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/arcSettings.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/arcSettings.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{}/extensions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/extensions.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{}/extensions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/extensions.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{}/generatePassword is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/arcSettings.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{}/createArcIdentity is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/arcSettings.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/arcSettings/{}/consentAndInstallDefaultExtensions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/arcSettings.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/clusters/{}/uploadCertificate is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-08-01-preview/clusters.json |
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 344 Errors, 0 Warnings failed [Detail]
Only 27 items are listed, please refer to log for more details.
️❌SemanticValidation: 8 Errors, 0 Warnings failed [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌SpellCheck: 59 Errors, 0 Warnings failed [Detail]
Only 27 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Unknown word (Apigee), please fix the error or add words to ./custom-words.txt path: Microsoft.ApiCenter/stable/2024-03-01/apicenter.json#L2930:14 |
|
Unknown word (springboot), please fix the error or add words to ./custom-words.txt path: Microsoft.AppPlatform/preview/2023-11-01-preview/appplatform.json#L12547:99 |
|
Unknown word (SDFLEX), please fix the error or add words to ./custom-words.txt path: Microsoft.AzureLargeInstance/preview/2023-07-20-preview/azurelargeinstance.json#L756:14 |
|
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54:7 |
|
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54:52 |
|
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L57:30 |
|
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L58:34 |
|
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L58:71 |
|
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L73:35 |
|
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L73:80 |
|
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L144:7 |
|
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L144:52 |
|
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L147:42 |
|
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L217:7 |
|
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L217:52 |
|
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L221:131 |
|
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L236:35 |
|
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:7 |
|
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:52 |
|
Unknown word (rootcert), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:102 |
|
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L274:30 |
|
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L312:21 |
|
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L423:33 |
|
Unknown word (finetuning), please fix the error or add words to ./custom-words.txt path: authoring/preview/2023-10-01-preview/azureopenai.json#L612:37 |
|
Unknown word (finetuning), please fix the error or add words to ./custom-words.txt path: authoring/preview/2023-10-01-preview/azureopenai.json#L665:38 |
|
Unknown word (finetuning), please fix the error or add words to ./custom-words.txt path: authoring/preview/2023-10-01-preview/azureopenai.json#L708:37 |
|
Unknown word (finetuning), please fix the error or add words to ./custom-words.txt path: authoring/preview/2023-10-01-preview/azureopenai.json#L746:40 |
️⌛PR Summary pending [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
AzureRestAPISpecReview
added
Cadl
This was referenced Oct 12, 2023
This was referenced Nov 6, 2023
* tsv test pipeline * test failure * Update eng/tools/TypeSpecValidation/test/git-diff.test.ts * Update eng/pipelines/typespec-validation-ci.yml Co-authored-by: Mike Harder <[email protected]> * Update eng/pipelines/typespec-validation-ci.yml Co-authored-by: Mike Harder <[email protected]> --------- Co-authored-by: Mike Harder <[email protected]>
- Continuation of #26425 - Update generate autorest with latest version of TypeSpec packages
* change the event type of tags from string to object * ran prettier check
Replaced Windows OS images with Gen2 equivalent
…house_swagger' (#26561) * [AutoSync] 5a9813b211 Add lakehouse swagger * [AutoSync] 1cc7912bdd Fix spelling * [AutoSync] bc53c0c6db Add type * Add swagger change for Synapse * Fix Synapse * Fix reference --------- Co-authored-by: swagger-automation <[email protected]>
…add version stable/2023-10-01 (#26483) * Adds base for updating Microsoft.ContainerService/aks from version stable/2023-09-01 to version 2023-10-01 * Updates readme * Updates API version in new specs and examples * Add rest api specs for node public IP IPtags and IP-based Load Balancers (#26389) * feat: add rest api spec for node public IP IPTags * feat: add rest api spec for ip-based load balancer * Add API spec for AKS HostNetwork NSG Control (#26385) * update readme (#26388) * Update custom words for ContainerService/aks 2023-10-01 (#26481) * add CapacityReservationGroup into custom-words.txt (#26461) Co-authored-by: tong chen <[email protected]> * add lower case capacityreservationgroup (#26475) Co-authored-by: tong chen <[email protected]> --------- Co-authored-by: Tong Chen <[email protected]> Co-authored-by: tong chen <[email protected]> * restored to dev branch base (#26451) Co-authored-by: tong chen <[email protected]> * resolve conflict (#26585) --------- Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Jialun Cai <[email protected]> Co-authored-by: Tong Chen <[email protected]> Co-authored-by: tong chen <[email protected]>
* Adds base for updating Microsoft.Dashboard from version preview/2022-10-01-preview to version 2023-09-01 * Updates readme * Updates API version in new specs and examples * minor fixes --------- Co-authored-by: Younjin Song <[email protected]>
* First Stable commit * New API Version Relase * Fixed pretty json check * Removed changes in 2015-10-31 API version * Removed Private Endpoint Definitions from Common V5 * Reuse common-types for Subscription, APIVersion and ResourceGroup parameters * Resolved PR comments * Removed unused definitions and fixed examples * Fixed duplicate schema errors * Fixed duplicate schema errors * Fix Go SDK * Added suppression for PutRequestResponseSchemeArm * Fix Go SDK * Fixed Lint errors for type object failure --------- Co-authored-by: Sushil Upadhyay <[email protected]> Co-authored-by: Mahak Jain <[email protected]> Co-authored-by: mahakjain314 <[email protected]>
…e version: 2023-11-01 (#26541) * Adds Microsoft.Cache stable api version 2023-11-01 with new scaling status, encryption, and identity support * Adds x-ms-identifiers tag for modules
This was referenced Nov 7, 2023
Closed
Added response field for client name (#26073)
…to add version stable/2023-07-01 (#26538) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2021-12-13 to version 2023-07-01 * Updates readme * Updates API version in new specs and examples * Update new fields and add `GetVersions.json`. * Fix version, add new path, fix `GetVersions.json`. * Temp fix. * Prettier format fix. * Minor fix. * Fix wrong schema for `/versions` endpoint. --------- Co-authored-by: Haofeng Xie <[email protected]>
) * remove default on eviction type * copy from 2023-09-01-preview * update specs with version 2023-11-01-preview --------- Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
Member
|
@jkmhelprp closing this PR as we don't generally run a full merge from main into feature branches. You should instead rebase your feature branch on top of main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.