-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Storage STG 92 #26286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage STG 92 #26286
Conversation
* added new version * added version to readme
This reverts commit 439846f.
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| file.json | 2024-02-04(c125686) | 2023-08-03(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L46:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L93:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L164:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L240:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L313:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L491:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L566:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L689:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L804:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L927:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1047:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1175:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1271:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1334:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1419:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1516:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1607:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1671:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1762:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1853:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1952:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2077:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2190:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2265:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2420:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2517:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2630:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2724:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2826:9 |
|
| The new version is removing enum value(s) '2023-08-03' from the old version. Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L3002:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2024-02 | package-2024-02(c125686) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
HostParametersValidation |
The host parameter must be called 'endpoint'. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L16 |
HostParametersValidation |
The host parameter must be typed 'type 'string', format 'url''. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L16 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L135 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L145 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L221 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L361 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L366 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L371 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L376 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L387 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L547 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L644 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L670 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L759 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L785 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L882 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L908 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1002 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1028 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1080 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1130 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1156 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1239 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1249 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1390 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1400 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1487 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1497 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1578 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1588 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Generated ApiView
|
|
Hi @seanmcc-msft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
Co-authored-by: Sean McCullough <[email protected]>
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Added response field for client name (#26073)
This is not a breaking change, this is a new service version
Do not delete the
feature/storage/stg92basebranch when merging, we need to cherry-pick a commit from this branch to 93.