Skip to content

Conversation

@seanmcc-msft
Copy link
Member

This is not a breaking change, this is a new service version

Do not delete the feature/storage/stg92base branch when merging, we need to cherry-pick a commit from this branch to 93.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 18, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 18, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 51 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
file.json 2024-02-04(c125686) 2023-08-03(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L46:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L93:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L164:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L240:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L313:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L491:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L566:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L689:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L804:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L927:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1047:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1175:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1271:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1334:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1419:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1516:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1607:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1671:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1762:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1853:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L1952:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2077:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2190:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2265:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2420:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2517:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2630:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2724:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L2826:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2023-08-03' from the old version.
Old: Microsoft.FileStorage/preview/2023-08-03/file.json#L3002:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2024-02 package-2024-02(c125686) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
HostParametersValidation The host parameter must be called 'endpoint'.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L16
HostParametersValidation The host parameter must be typed 'type 'string', format 'url''.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L16
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L135
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L145
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L221
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L361
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L366
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L371
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L376
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L387
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L547
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L644
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L670
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L759
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L785
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L882
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L908
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1002
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1028
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1080
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1130
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1156
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1239
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1249
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1390
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1400
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1487
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1497
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1578
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2024-02-04/file.json#L1588
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 18, 2023

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 18, 2023

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.FileStorage https://apiview.dev/Assemblies/Review/38179b918b3741bdb9096c4143b2afb1

@openapi-workflow-bot
Copy link

Hi @seanmcc-msft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@seanmcc-msft seanmcc-msft marked this pull request as ready for review November 7, 2023 18:48
@seanmcc-msft seanmcc-msft requested a review from a team as a code owner November 7, 2023 18:48
@seanmcc-msft seanmcc-msft requested review from DominikMe and JeffreyRichter and removed request for a team November 7, 2023 18:48
@tg-msft tg-msft added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Nov 7, 2023
@tg-msft tg-msft merged commit ef99caa into main Nov 7, 2023
@tg-msft tg-msft deleted the feature/storage/stg92base branch November 7, 2023 22:01
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

zman-ms pushed a commit that referenced this pull request Jan 10, 2024
Added response field for client name (#26073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. CI-MissingBaseCommit data-plane new-api-version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants