Conversation
|
Hi, @RBANSALMS! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2021-06-30-preview | package-2021-06-30-preview(64f7f5f) | default(main) |
| package-2022-04-30-preview | package-2022-04-30-preview(64f7f5f) | default(main) |
| package-2022-09-13-preview | package-2022-09-13-preview(64f7f5f) | default(main) |
| package-2023-06-30 | package-2023-06-30(64f7f5f) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
OperationsAPIImplementation |
Operations API must be implemented for 'Microsoft.Scom'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L1 |
|
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L50 |
RPC-Uri-V1-03 |
OperationsApiResponseSchema |
The response schema of operations API '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Scom/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L74 |
|
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L75 |
RPC-Operations-V1-01 |
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L92 |
RPC-Uri-V1-03 |
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L134 |
RPC-Uri-V1-03 |
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L173 |
RPC-Uri-V1-03 |
ResourceNameRestriction |
The resource name parameter 'instanceName' should be defined with a 'pattern' restriction. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L173 |
RPC-Uri-V1-05 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L240 |
RPC-Put-V1-11 |
PutResponseSchemaDescription |
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L240 |
RPC-Put-V1-11 |
PatchResponseCode |
LRO PATCH must have 200 and 202 return codes. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L270 |
|
LroPatch202 |
The async patch operation should return 202. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L298 |
RPC-Patch-V1-06, RPC-Async-V1-08 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L352 |
RPC-Async-V1-07 |
MissingTypeObject |
The schema 'OperationsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L378 |
|
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L381 |
|
MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L404 |
|
MissingTypeObject |
The schema 'MonitoringInstance' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L446 |
|
MissingTypeObject |
The schema 'MonitoringInstanceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L464 |
|
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L482 |
|
MissingTypeObject |
The schema 'ManagementServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L529 |
|
MissingTypeObject |
The schema 'DomainControllerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L549 |
|
MissingTypeObject |
The schema 'DomainUserCredentials' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L562 |
|
MissingTypeObject |
The schema 'AzureHybridBenefitProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L612 |
|
MissingTypeObject |
The schema 'MonitoringInstanceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SCOM/preview/2021-06-30-preview/scom.json#L629 |
|
OperationsAPIImplementation |
Operations API must be implemented for 'Microsoft.Scom'. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L1 |
|
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L50 |
RPC-Uri-V1-03 |
OperationsApiResponseSchema |
The response schema of operations API '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Scom/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L74 |
|
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L75 |
RPC-Operations-V1-01 |
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L92 |
RPC-Uri-V1-03 |
PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Scom' doesn't match the namespace. Location: Microsoft.SCOM/preview/2022-04-30-preview/scom.json#L134 |
RPC-Uri-V1-03 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️All merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @RBANSALMS! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
|
Hi, @RBANSALMS, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
|
Earlier I had created this PR #24608 to move SCOM MI swagger from private repo to Public repo, but due to no interaction on that PR, I have created this PR now. |
|
Hi @RBANSALMS! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
GitHub issue for finalizing name of the NameSpace for SDK: |
Please fix these and afterwards, remove ARMChangesRequest label for ARM to review this swagger. |
|
Please address or respond to feedback from the ARM API reviewer. |
|
/azp run TypeSpec Validation |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Opened new PR with Just PP APIs: #25148 |
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.