Skip to content

Comments

[Hub Generated] Publish private branch 'validate'#24608

Closed
RBANSALMS wants to merge 1 commit intomainfrom
published/Azure/azure-rest-api-specs-pr/validate
Closed

[Hub Generated] Publish private branch 'validate'#24608
RBANSALMS wants to merge 1 commit intomainfrom
published/Azure/azure-rest-api-specs-pr/validate

Conversation

@RBANSALMS
Copy link
Contributor

@RBANSALMS RBANSALMS commented Jun 27, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@RBANSALMS
Copy link
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12081

@openapi-workflow-bot
Copy link

Hi, @RBANSALMS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 27, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.SCOM/preview/2022-09-13-preview
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌SwaggerAPIView: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Failed to generate swagger APIView. The readme file format is invalid and the tag is not defined. Use the provided readme template for guidance readme template. For more details, please check the detail log. "How to fix":"Check the readme file and make sure the readme file format is valid and the tag is defined. Use the provided readme template"
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    unacceptable kind of an object to dump [object Error] "role":"Model Validation",
    "url":"https://github.com/Azure/azure-rest-api-specs/blob/f59f1d42f2f59b1917a5cb06b64b95d8a694be48/specification/scom/resource-manager/Microsoft.SCOM/preview/2022-09-13-preview/scom.json"
    ️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    INTERNAL_ERROR Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/scom/resource-manager/Microsoft.SCOM/preview/2022-09-13-preview/examples/Operations_List.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/scom/resource-manager/Microsoft.SCOM/preview/2022-09-13-preview/examples/Operations_List.json'
    JsonUrl: Microsoft.SCOM/preview/2022-09-13-preview/scom.json
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 27, 2023

    Swagger Generation Artifacts

    ️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=370288&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @RBANSALMS
    Copy link
    Contributor Author

    Issue for management client library name :
    https://github.com/Azure/azure-sdk-pr/issues/1187

    @openapi-workflow-bot
    Copy link

    Hi @RBANSALMS! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @RBANSALMS This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP.

    @openapi-workflow-bot
    Copy link

    Hi, @RBANSALMS, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved.
    Action Required:

  • Follow this guidance Naming for new initial management or client libraries (new SDKs) - Overview (azure.com) to create an issue for management client library name arch board review.
  • Paste the issue link that you created in step 1 in this PR

  • Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed.

    @raosuhas
    Copy link
    Member

    Hi @RBANSALMS This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP.

    New rp namsespaces must be onboarded with rpaas. Can you please fix this ?

    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 11, 2023
    @RBANSALMS
    Copy link
    Contributor Author

    @raosuhas

    Regarding your comment regarding "New rp namsespaces must be onboarded with rpaas", we are already onbroaded to RPaas.

    I have other concerns wrt to this PR:

    1. I had opened this PR via Openapihib by providing the latest PR for our RP from the Private repo.
    https://openapihub.azure-devex-tools.com/tools/publishpullrequest
    Latest PR from Private Repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/12081

    But it seems that this PR does not include all the files from the private repo, it does include only one file "specification/scom/resource-manager/Microsoft.SCOM/preview/2022-09-13-preview/scom.json", but all other files from the private repo are not included in this PR.
    All files from the private repo are shown below:
    image

    Ideally all the files from the private repo should be part of this PR to be merged into the public repo, right?
    Please guide me how should I make include all the files in the PR.

    1. I think, as all the files are not included in the PR, so you are seeing this RP as not being onboarded to RPaas. Once the above point 1 will get fixed, then this error will also go away.

    2. I assume that the same should be the way for other validation errors as well (Avacado, ModelValidation , SemanticValidation etc)

    Please feel free to redirect.

    @RBANSALMS
    Copy link
    Contributor Author

    @raosuhas , please help me in getting unblocked.

    @RBANSALMS RBANSALMS mentioned this pull request Jul 24, 2023
    8 tasks
    @RBANSALMS
    Copy link
    Contributor Author

    Opened manually generated PR. #24803

    Closing this PR.

    @RBANSALMS RBANSALMS closed this Jul 28, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants