Skip to content

Resolve Linter validation issue#23953

Closed
v-sapanchal wants to merge 375 commits intoAzure:release-Microsoft.Network-2022-11-01from
v-sapanchal:sapanchal/swagger_errordetailserror
Closed

Resolve Linter validation issue#23953
v-sapanchal wants to merge 375 commits intoAzure:release-Microsoft.Network-2022-11-01from
v-sapanchal:sapanchal/swagger_errordetailserror

Conversation

@v-sapanchal
Copy link
Contributor

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

paramsiva1 and others added 30 commits March 28, 2023 10:58
Co-authored-by: Parameswara Reddy Bodeddula <pbodeddula@microsoft.com>
…version stable/2023-01-15 (Azure#22431)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-11-15 to version 2023-01-15

* Updates readme

* Updates API version in new specs and examples

* Adds RecoveryPointProperties for 2023-01-15

* Adds RecoveryPointProperties at missed places

* Fixes API version in examples

* Fixes model validation errors
…perators' (Azure#23323)

* Add autoAdd field to indicate sku should be included during creation (Azure#5849)

* copy folder

* Add autoAdd field

* update readme

* Add operation example

* fix style

Co-authored-by: Peter Shen <yinshen@microsoft.com>

* Add previour Private PR for 2021-10-15-preview as a baseline

* Update EventGrid.json with new features to be part of 2021-10-15-preview API

* update readme file and add missing example files

* fix typo

* fix operation name for unauthorize

* fix tag

* New API version to Microsoft.Security 2023-01-01-preview

* refactoring

* Update readme

* fix syntax error

* Refactoring

* Add pattern restriction

* Fix readme

* npm run prettier

* Update naming in the examples

* fix merge

* merge fix

* fix merge

* fix merge

* Update readme.md

* Update readme.md

---------

Co-authored-by: Peter Shen <shen.yingjun@hotmail.com>
Co-authored-by: Peter Shen <yinshen@microsoft.com>
Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Co-authored-by: Daniel Dahan <dahandaniel@microsoft.com>
Co-authored-by: Sivan Manor <simanor@microsoft.com>
* Adding the previous version, 2021-11-01-preview, as the initial commit under 2022-09-12-preview folder for easier review

* Updating the 2022-09-12-preview version

* Removing jobCount from sessionPut example
… version preview/2023-02-01-preview (Azure#23221)

* Adds base for updating Microsoft.ContainerInstance from version stable/2022-09-01 to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* added property

* added sample request and responses

* integer format

* read only property

* read only fix

* custom word

* changed boolean to enum

* changed boolean to enum in examples

* x-ms-enum
* added properties property for operation object

* updated older api version as well

* prettier fix

* use full description for properties object

* remove 'type'

* use correct property name
Add error and intervention actions.
…ft.DevCenter-2023-01-01-preview' (Azure#23124)

* add or modify files

* Update readme.md

re-adding azure-sdk-for-go
* S360 fix EdgeOrder 2022-05-01-preview

* reverting change for referrer
* Add pageable support for list functions

* nit

---------

Co-authored-by: Minnie Liu <peiliu@microsoft.com>
…ocumentation for version preview/2023-01-01-preview (Azure#23357)

* updating api spec documentation

* updating api spec documentation Azure#2

* updating api spec documentation Azure#3
…ivate Endpoint Connection DELETE/PUT responses (Azure#23205)

* Add EP healthStatus property

* Fix Private Endpoint swagger issue

* Remove 202 response from Private Endpoint Connection model
…rsion stable/2022-10-01 (Azure#23262)

merged with breaking change approved
…rsion stable/2022-05-01 (Azure#22916)

* make fixes for s360 items

* spelling fix

* added missing properties to all stable api versions

* fix model validation errors
Azure#23029)

* Add missing default value to fix s360

* Fix PrettierCheck issue

---------

Co-authored-by: Bo Zhang <bzhan@microsoft.com>
* Adding 2022-11-01-preview swagger for reference

* Adding provicer client id and client secret as part of the Scene Create Job and Scenes Get & Search Features APIs

* Removing duplicate parameter IntegrationIds from list sensor integrations API

* Add changes for supporting multi-polygon shapefile ingestion

---------

Co-authored-by: Bhargav Kansagara <bhkansag@microsoft.com>
Co-authored-by: Pratyush Prateek <pratyush.prateek.eee15@itbhu.ac.in>
…operation (Azure#22908)

* Update healthbot.json

Add "x-ms-long-running-operation": true

* Update healthbot.json

Add "x-ms-long-running-operation": true

* Update healthbot.json

Add "x-ms-long-running-operation": true

* Update healthbot.json

Add "x-ms-long-running-operation": true

* Update healthbot.json

* Update healthbot.json

Fix

* Update healthbot.json

* Update healthbot.json

* Update healthbot.json
* Update aliases.json

* remove 2008 alias

this image was entirely deprecated, and was removed from PS.

* add centos versioned

* add architecture

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

* Update arm-compute/quickstart-templates/aliases.json

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

* Update aliases.json

---------

Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
* Update readme.python.md

* Update readme.python.md

* Update readme.python.md
* Add base

* Update API version

* Update readme
…rsion stable/2022-10-01 (Azure#22721)

* Adds base for updating Microsoft.ResourceHealth from version preview/2022-10-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* added missing api

* Revert "added missing api"

This reverts commit 111d6ca.

* added missing api

* added error message suppression to readme

* prettier fix

* added missing fields for s360 items

* updated description

* spelling fix

* added missing properties to all stable api versions

* Revert "added missing properties to all stable api versions"

This reverts commit 220764b.

* fixes from pr for resourcehealth.json file

* updated child avialbility example uri

* added suppression for _ActionUrl

* added suppression for _ActionUrl

* added suppression for _ActionUrl

* added suppression for _ActionUrl

* added suppression for _ActionUrl

* added suppression for _ActionUrl

* linter wrnings

* update readme for .net sdk

* update readme for .net sdk

* update readme for sdks

* trying suppression for actionurl.comment

* added suppression for _ActionUrl
This was referenced May 12, 2023
@ghost
Copy link

ghost commented May 28, 2023

Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label May 28, 2023
@ghost ghost closed this Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023

Hi, @v-sapanchal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.