Correct wrong apiVersion for managedCluster 2019-04-01 by zqingqing1 · Pull Request #5849 · Azure/azure-rest-api-specs

zqingqing1 · 2019-05-03T00:26:47Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…/2019-02-01 to version 2019-04-01

…1 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error

…Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo

AutorestCI · 2019-05-03T00:27:28Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a2d02785d864b6a95fc8d0e4ad721aa6c516003b
  stderr: 'fatal: reference is not a tree: a2d02785d864b6a95fc8d0e4ad721aa6c516003b'

AutorestCI · 2019-05-03T00:27:35Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a2d02785d864b6a95fc8d0e4ad721aa6c516003b
  stderr: 'fatal: reference is not a tree: a2d02785d864b6a95fc8d0e4ad721aa6c516003b'

AutorestCI · 2019-05-03T00:28:02Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a2d02785d864b6a95fc8d0e4ad721aa6c516003b
  stderr: 'fatal: reference is not a tree: a2d02785d864b6a95fc8d0e4ad721aa6c516003b'

AutorestCI · 2019-05-03T00:28:59Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a2d02785d864b6a95fc8d0e4ad721aa6c516003b
  stderr: 'fatal: reference is not a tree: a2d02785d864b6a95fc8d0e4ad721aa6c516003b'

AutorestCI · 2019-05-03T00:29:35Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a2d02785d864b6a95fc8d0e4ad721aa6c516003b
  stderr: 'fatal: reference is not a tree: a2d02785d864b6a95fc8d0e4ad721aa6c516003b'

azuresdkci · 2019-05-03T00:58:33Z

Can one of the admins verify this patch?

xizha162 · 2019-05-03T04:17:49Z

specification/containerservice/resource-manager/readme.md

+
+```yaml $(tag) == 'package-2019-04-30'
+input-file:
+- Microsoft.ContainerService/preview/2019-04-30/openShiftManagedClusters.json


This should be stable/2019-04-30/openshiftManagedCluster.json

jhendrixMSFT

There are merge conflicts that must be resolved.

lmazuel · 2019-05-03T19:24:17Z

Discussed offline, not needed anymore

…5849) * copy folder * Add autoAdd field * update readme * Add operation example * fix style Co-authored-by: Peter Shen <yinshen@microsoft.com>

…perators' (#23323) * Add autoAdd field to indicate sku should be included during creation (#5849) * copy folder * Add autoAdd field * update readme * Add operation example * fix style Co-authored-by: Peter Shen <yinshen@microsoft.com> * Add previour Private PR for 2021-10-15-preview as a baseline * Update EventGrid.json with new features to be part of 2021-10-15-preview API * update readme file and add missing example files * fix typo * fix operation name for unauthorize * fix tag * New API version to Microsoft.Security 2023-01-01-preview * refactoring * Update readme * fix syntax error * Refactoring * Add pattern restriction * Fix readme * npm run prettier * Update naming in the examples * fix merge * merge fix * fix merge * fix merge * Update readme.md * Update readme.md --------- Co-authored-by: Peter Shen <shen.yingjun@hotmail.com> Co-authored-by: Peter Shen <yinshen@microsoft.com> Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com> Co-authored-by: Daniel Dahan <dahandaniel@microsoft.com> Co-authored-by: Sivan Manor <simanor@microsoft.com>

…perators' (Azure#23323) * Add autoAdd field to indicate sku should be included during creation (Azure#5849) * copy folder * Add autoAdd field * update readme * Add operation example * fix style Co-authored-by: Peter Shen <yinshen@microsoft.com> * Add previour Private PR for 2021-10-15-preview as a baseline * Update EventGrid.json with new features to be part of 2021-10-15-preview API * update readme file and add missing example files * fix typo * fix operation name for unauthorize * fix tag * New API version to Microsoft.Security 2023-01-01-preview * refactoring * Update readme * fix syntax error * Refactoring * Add pattern restriction * Fix readme * npm run prettier * Update naming in the examples * fix merge * merge fix * fix merge * fix merge * Update readme.md * Update readme.md --------- Co-authored-by: Peter Shen <shen.yingjun@hotmail.com> Co-authored-by: Peter Shen <yinshen@microsoft.com> Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com> Co-authored-by: Daniel Dahan <dahandaniel@microsoft.com> Co-authored-by: Sivan Manor <simanor@microsoft.com>

Xiaofang Zhang and others added 9 commits April 23, 2019 13:48

Adds base for updating Microsoft.ContainerService from version stable…

165bd29

…/2019-02-01 to version 2019-04-01

Updates readme

c6dac20

Updates API version in new specs and examples

606ec05

Adding windowsProfile and maxAgentPools property in the new 2019-04-0…

4df11d3

…1 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error

adding load balancer sku property (Azure#5556)

e095d44

Add support VMSS agent nodes with public IP. (Azure#5748)

9150e84

Add identity property in managedCluster definition and add an example (…

c225658

…Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo

rebase

9965c80

correct right apiVersion for mc

46b6f07

add read only

8bb0797

azuresdkci assigned jhendrixMSFT May 3, 2019

azuresdkci requested a review from jhendrixMSFT May 3, 2019 00:49

AutorestCI mentioned this pull request May 3, 2019

[AutoPR containerservice/resource-manager] Correct wrong apiVersion for managedCluster 2019-04-01 Azure/azure-sdk-for-python#5065

Closed

remove useless file

443db00

xizha162 reviewed May 3, 2019

View reviewed changes

jhendrixMSFT requested changes May 3, 2019

View reviewed changes

lmazuel closed this May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct wrong apiVersion for managedCluster 2019-04-01 #5849

Correct wrong apiVersion for managedCluster 2019-04-01 #5849
zqingqing1 wants to merge 11 commits intoAzure:masterfrom
zqingqing1:change-readmn

zqingqing1 commented May 3, 2019

Uh oh!

AutorestCI commented May 3, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 3, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 3, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 3, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 3, 2019 •

edited

Loading

Uh oh!

azuresdkci commented May 3, 2019

Uh oh!

xizha162 May 3, 2019

Uh oh!

jhendrixMSFT left a comment

Uh oh!

lmazuel commented May 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

zqingqing1 commented May 3, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 3, 2019

Uh oh!

xizha162 May 3, 2019

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

lmazuel commented May 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading