Skip to content

Add refresh API for MI#23926

Closed
guptanitish-ms wants to merge 13 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom
guptanitish-ms:release-sql-Microsoft.Sql-2022-11-01-preview
Closed

Add refresh API for MI#23926
guptanitish-ms wants to merge 13 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom
guptanitish-ms:release-sql-Microsoft.Sql-2022-11-01-preview

Conversation

@guptanitish-ms
Copy link
Contributor

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Add an action to an existing API
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    Asap
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    Asap
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @guptanitish-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail] The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/443cd0ea0e08ce1603c67f0285c8c1c4413047e6/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/stable/2021-11-01/ManagedInstances.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.53/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token   in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:29\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft"


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/443cd0ea0e08ce1603c67f0285c8c1c4413047e6/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/preview/2022-08-01-preview/ManagedInstances.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.53/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token   in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:29\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft"
    ️️✔️LintDiff succeeded [Detail]
    Rule Message
    LintDiffToolException "details":""stack":"ParserError: Error parsing /mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json: missed comma between flow collection entries (764:31)\n\n 761
    ️❌Avocado: 4 Errors, 1 Warnings failed [Detail]
    Rule Message
    JSON_PARSE The file is not a valid JSON file.
    json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":764,"column":30},"token":" ","message":"invalid symbol, token:  , line: 764, column: 30","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"})
    JSON_PARSE The file is not a valid JSON file.
    json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":11},"token":""readOnly"","message":"unexpected token, token: "readOnly", line: 765, column: 11","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"})
    JSON_PARSE The file is not a valid JSON file.
    json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":21},"token":":","message":"unexpected token, token: :, line: 765, column: 21","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"})
    JSON_PARSE The file is not a valid JSON file.
    json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":23},"token":"true","message":"unexpected token, token: true, line: 765, column: 23","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"})
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-preview-2022-11
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 0 Errors, 0 Warnings failed [Detail]
    ️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    JSON_PARSING_ERROR Json parsing error: invalid symbol
    JsonUrl: Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json#L764:30
    ️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Code style issues found
    path: Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️❌CadlValidation: 0 Errors, 0 Warnings failed [Detail]
    ️❌TypeSpec Validation: 0 Errors, 0 Warnings failed [Detail]
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 11, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @guptanitish-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Code Generator Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
      cmderr	[automation_generate.sh] npm notice
      cmdout	[automation_generate.sh] [Autorest]  762 |             "$ref": "#/definitions/EndpointDetail"
      cmdout	[automation_generate.sh] [Autorest]  763 |           },
      cmdout	[automation_generate.sh] [Autorest]  764 |           "x-ms-identifiers": []
      cmdout	[automation_generate.sh] [Autorest] -------------------------------------^
      cmdout	[automation_generate.sh] [Autorest]  765 |           "readOnly": true
      cmdout	[automation_generate.sh] [Autorest]  766 |         }
      cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmdout	[automation_generate.sh] [Autorest]  762 |             "$ref": "#/definitions/EndpointDetail"
      cmdout	[automation_generate.sh] [Autorest]  763 |           },
      cmdout	[automation_generate.sh] [Autorest]  764 |           "x-ms-identifiers": []
      cmdout	[automation_generate.sh] [Autorest] -------------------------------------^
      cmdout	[automation_generate.sh] [Autorest]  765 |           "readOnly": true
      cmdout	[automation_generate.sh] [Autorest]  766 |         }
      cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:876
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 876 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:876
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 876 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cannot force update branch 'sdkAuto/23926/Azure.ResourceManager.Sql' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/23926/Azure.ResourceManager.Sql' as it is the current HEAD of the repository.
    • Azure.ResourceManager.Sql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    • Azure.ResourceManager.Sql [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/23926/Azure.ResourceManager.Sql' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		Azure.ResourceManager.Sql
      error		Azure.ResourceManager.Sql
    ️❌ azure-sdk-for-java failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/pom.xml'
      Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/pom.xml'
    • azure-resourcemanager-sql-generated [View full logs
      error	Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/pom.xml'
      error	The following packages are still pending:
      error		azure-resourcemanager-sql-generated
    ️❌ azure-sdk-for-go failed [Detail]
    • Code Generator Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql�[0m
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/sql/armsql, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql
      cmderr	[generator automation-v2] [ERROR] autorest --version=3.8.2 --use=@autorest/go@4.0.0-preview.48 --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.20.0]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] info    | AutoRest core version selected from configuration: 3.8.2.
      cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.6.3).
      cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.8.2/nodemodules/@autorest/core/dist' (3.8.2)
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.48 -> 4.0.0-preview.48)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.48->4.0.0-preview.48)
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.23.1 -> 4.23.1)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.23.1->4.23.1)
      cmderr	[generator automation-v2] [ERROR] error   | JsonSpec/SyntaxError | Syntax Error Encountered:  Unexpected token   in JSON
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30
      cmderr	[generator automation-v2] [ERROR] error   | JsonSpec/SyntaxError | Syntax Error Encountered:  Unexpected token   in JSON
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30
      cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
      cmderr	[generator automation-v2] [ERROR] error   |   YAMLException: missed comma between flow collection entries (764:31)
      cmderr	[generator automation-v2] [ERROR] 761 |           "items": {
      cmderr	[generator automation-v2] [ERROR] 762 |             "$ref": "#/definitions/EndpointDetail"
      cmderr	[generator automation-v2] [ERROR] 763 |           },
      cmderr	[generator automation-v2] [ERROR] 764 |           "x-ms-identifiers": []
      cmderr	[generator automation-v2] [ERROR] -------------------------------------^
      cmderr	[generator automation-v2] [ERROR] 765 |           "readOnly": true
      cmderr	[generator automation-v2] [ERROR] 766 |         }
      cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • sql/resource-manager [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from f0f817cdf0f31426950dbd0d5a10b71bbe5f32c0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.sql.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.sql.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the SQL label May 11, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2023

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @guptanitish-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @guptanitish-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @v-xuto
    Copy link
    Member

    v-xuto commented May 12, 2023

    @guptanitish-ms Please fix CI checks errors (LintDiff, SemanticValidation, Avocado, Model validation ), you can refer to this comments or https://aka.ms/ci-fix on how to fix it.

    @v-xuto
    Copy link
    Member

    v-xuto commented May 15, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 15, 2023
    @openapi-workflow-bot
    Copy link

    Hi @guptanitish-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @guptanitish-ms
    Copy link
    Contributor Author

    @guptanitish-ms Please fix CI checks errors (LintDiff, SemanticValidation, Avocado, Model validation ), you can refer to this comments or https://aka.ms/ci-fix on how to fix it.

    Most errors are fixed. There are a few remaining ones which I am not sure how to fix.

    @v-xuto
    Copy link
    Member

    v-xuto commented May 16, 2023

    Most errors are fixed. There are a few remaining ones which I am not sure how to fix.

    @guptanitish-ms
    For ModelValidation error, please refer to this link to add the header in your example. If you don't know how to add the header, you can refer to this example.

    For LintDiff error, please find the ARM oncall owner to review. You can check the third of the ARM API Review Checklist in the first comment.

    @guptanitish-ms guptanitish-ms mentioned this pull request May 16, 2023
    11 tasks
    @guptanitish-ms
    Copy link
    Contributor Author

    @guptanitish-ms Please fix CI checks errors (LintDiff, SemanticValidation, Avocado, Model validation ), you can refer to this comments or https://aka.ms/ci-fix on how to fix it.

    Please take another look. Most errors are resolved. Im told the other errors dont need to be addressed / we need an exception for those.

    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2023
    @guptanitish-ms guptanitish-ms force-pushed the release-sql-Microsoft.Sql-2022-11-01-preview branch 3 times, most recently from 5113b2e to ad2b737 Compare May 17, 2023 22:51
    @guptanitish-ms guptanitish-ms force-pushed the release-sql-Microsoft.Sql-2022-11-01-preview branch 2 times, most recently from 52bee98 to fa9b63f Compare May 18, 2023 16:12
    @guptanitish-ms guptanitish-ms force-pushed the release-sql-Microsoft.Sql-2022-11-01-preview branch from fa9b63f to 38880f2 Compare May 18, 2023 16:15
    @ericshape
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 18, 2023
    @jeremyfrosti
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 23926 in repo Azure/azure-rest-api-specs

    @v-xuto
    Copy link
    Member

    v-xuto commented May 19, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1 raych1 deleted the branch Azure:release-sql-Microsoft.Sql-2022-11-01-preview May 19, 2023 07:26
    @raych1 raych1 closed this May 19, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    8 participants