Add refresh API for MI#23926
Add refresh API for MI#23926guptanitish-ms wants to merge 13 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom
Conversation
|
Hi, @guptanitish-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/443cd0ea0e08ce1603c67f0285c8c1c4413047e6/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/stable/2021-11-01/ManagedInstances.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.53/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:29\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft" |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/443cd0ea0e08ce1603c67f0285c8c1c4413047e6/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/preview/2022-08-01-preview/ManagedInstances.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.53/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:29\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json:764:30\nERROR: Syntax error: missed comma between flow collection entries\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft" |
️️✔️LintDiff succeeded [Detail]
| Rule | Message |
|---|---|
LintDiffToolException |
"details":""stack":"ParserError: Error parsing /mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json: missed comma between flow collection entries (764:31)\n\n 761 |
️❌Avocado: 4 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
JSON_PARSE |
The file is not a valid JSON file. json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":764,"column":30},"token":" ","message":"invalid symbol, token: , line: 764, column: 30","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":11},"token":""readOnly"","message":"unexpected token, token: "readOnly", line: 765, column: 11","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":21},"token":":","message":"unexpected token, token: :, line: 765, column: 21","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}]({"kind":"structure","code":"unexpected token","position":{"line":765,"column":23},"token":"true","message":"unexpected token, token: true, line: 765, column: 23","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json"}) |
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-preview-2022-11 |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 0 Errors, 0 Warnings failed [Detail]
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
JSON_PARSING_ERROR |
Json parsing error: invalid symbol JsonUrl: Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json#L764:30 |
️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
HowToFix |
Code style issues found path: Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌CadlValidation: 0 Errors, 0 Warnings failed [Detail]
️❌TypeSpec Validation: 0 Errors, 0 Warnings failed [Detail]
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
|
Hi, @guptanitish-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
|
Hi @guptanitish-ms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @guptanitish-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
@guptanitish-ms Please fix CI checks errors ( |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @guptanitish-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Most errors are fixed. There are a few remaining ones which I am not sure how to fix. |
@guptanitish-ms For |
Please take another look. Most errors are resolved. Im told the other errors dont need to be addressed / we need an exception for those. |
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
5113b2e to
ad2b737
Compare
52bee98 to
fa9b63f
Compare
fa9b63f to
38880f2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 23926 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Add an action to an existing API
Asap
Asap
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.