Closed
Conversation
|
Hi, @guptanitish-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/96a5c970c7fc807e49706a3c7c6731d94c4e37f1/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/stable/2021-11-01/ManagedInstances.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.51/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/examples/ManagedInstanceTopQueriesListMax.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json:737:12 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/managedInstances/managedInstanceName/topqueries"].get["x-ms-examples"]["Obtain list of instance's top resource consuming queries. Full-blown request and response" |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/96a5c970c7fc807e49706a3c7c6731d94c4e37f1/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/preview/2022-08-01-preview/ManagedInstances.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.51/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/examples/ManagedInstanceTopQueriesListMax.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json:737:12 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/managedInstances/managedInstanceName/topqueries"].get["x-ms-examples"]["Obtain list of instance's top resource consuming queries. Full-blown request and response" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.0.1) | new version | base version |
|---|---|---|
| default | default(96a5c97) | default(main) |
️❌Avocado: 5 Errors, 1 Warnings failed [Detail]
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/96a5c970c7fc807e49706a3c7c6731d94c4e37f1/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json" |
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/96a5c970c7fc807e49706a3c7c6731d94c4e37f1/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json" |
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/examples/ManagedInstanceList.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/examples/ManagedInstanceList.json' JsonUrl: Microsoft.Sql/preview/2023-02-01/ManagedInstances.json |
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=361886&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/sql/armsql - 2.0.0-beta.1+ Enum `DNSRefreshConfigurationPropertiesStatus` has been removed + Field `Family`, `MaintenanceConfigurationID` of struct `VirtualClusterProperties` has been removed + Function `*ServerDevOpsAuditSettingsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)` + Function `*ServerDevOpsAuditSettingsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ServerDevOpsAuditSettingsClientGetOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, *ServerDevOpsAuditSettingsClientGetOptions)` + Operation `*ReplicationLinksClient.Delete` has been changed to LRO, use `*ReplicationLinksClient.BeginDelete` instead. + Operation `*TransparentDataEncryptionsClient.CreateOrUpdate` has been changed to LRO, use `*TransparentDataEncryptionsClient.BeginCreateOrUpdate` instead. + Operation `*VirtualClustersClient.UpdateDNSServers` has been changed to LRO, use `*VirtualClustersClient.BeginUpdateDNSServers` instead. + Struct `DNSRefreshConfigurationProperties` has been removed + Struct `UpdateManagedInstanceDNSServersOperation` has been removed + Type of `ManagedDatabaseRestoreDetailsProperties.NumberOfFilesDetected` has been changed from `*int64` to `*int32` + Type of `ManagedDatabaseRestoreDetailsProperties.PercentCompleted` has been changed from `*float64` to `*int32` + Type of `ManagedDatabaseRestoreDetailsProperties.UnrestorableFiles` has been changed from `[]*string` to `[]*ManagedDatabaseRestoreDetailsUnrestorableFileProperties` + Type of `ServerPrivateEndpointConnection.Properties` has been changed from `*PrivateEndpointConnectionProperties` to `*PrivateEndpointConnectionPropertiesAutoGenerated` + Type of `ServerProperties.PublicNetworkAccess` has been changed from `*ServerNetworkAccessFlag` to `*ServerPublicNetworkAccessFlag`
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-sql [View full logs] [Preview SDK Changes]info [Changelog]
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:876 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 876 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:876 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 876 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cannot force update branch 'sdkAuto/23898/Azure.ResourceManager.Sql' as it is the current HEAD of the repository. Error: cannot force update branch 'sdkAuto/23898/Azure.ResourceManager.Sql' as it is the current HEAD of the repository.
❌Azure.ResourceManager.Sql [View full logs] [Preview SDK Changes]info [Changelog]
❌Azure.ResourceManager.Sql [View full logs]error Fatal error: cannot force update branch 'sdkAuto/23898/Azure.ResourceManager.Sql' as it is the current HEAD of the repository. error The following packages are still pending: error Azure.ResourceManager.Sql error Azure.ResourceManager.Sql
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-sql-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️sdk/resourcemanager/sql/armsql [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New function `*StartStopManagedInstanceSchedulesClient.CreateOrUpdate(context.Context, string, string, StartStopScheduleName, StartStopManagedInstanceSchedule, *StartStopManagedInstanceSchedulesClientCreateOrUpdateOptions) (StartStopManagedInstanceSchedulesClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*StartStopManagedInstanceSchedulesClient.Delete(context.Context, string, string, StartStopScheduleName, *StartStopManagedInstanceSchedulesClientDeleteOptions) (StartStopManagedInstanceSchedulesClientDeleteResponse, error)` info [Changelog] - New function `*StartStopManagedInstanceSchedulesClient.Get(context.Context, string, string, StartStopScheduleName, *StartStopManagedInstanceSchedulesClientGetOptions) (StartStopManagedInstanceSchedulesClientGetResponse, error)` info [Changelog] - New function `*StartStopManagedInstanceSchedulesClient.NewListByInstancePager(string, string, *StartStopManagedInstanceSchedulesClientListByInstanceOptions) *runtime.Pager[StartStopManagedInstanceSchedulesClientListByInstanceResponse]` info [Changelog] - New function `NewSynapseLinkWorkspacesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SynapseLinkWorkspacesClient, error)` info [Changelog] - New function `*SynapseLinkWorkspacesClient.NewListByDatabasePager(string, string, string, *SynapseLinkWorkspacesClientListByDatabaseOptions) *runtime.Pager[SynapseLinkWorkspacesClientListByDatabaseResponse]` info [Changelog] - New function `NewVulnerabilityAssessmentBaselineClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentBaselineClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentBaselineClient.Get(context.Context, string, string, VulnerabilityAssessmentName, BaselineName, *VulnerabilityAssessmentBaselineClientGetOptions) (VulnerabilityAssessmentBaselineClientGetResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentBaselineClient.NewListBySQLVulnerabilityAssessmentPager(string, string, VulnerabilityAssessmentName, *VulnerabilityAssessmentBaselineClientListBySQLVulnerabilityAssessmentOptions) *runtime.Pager[VulnerabilityAssessmentBaselineClientListBySQLVulnerabilityAssessmentResponse]` info [Changelog] - New function `NewVulnerabilityAssessmentBaselinesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentBaselinesClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentBaselinesClient.CreateOrUpdate(context.Context, string, string, VulnerabilityAssessmentName, BaselineName, DatabaseSQLVulnerabilityAssessmentRuleBaselineListInput, *VulnerabilityAssessmentBaselinesClientCreateOrUpdateOptions) (VulnerabilityAssessmentBaselinesClientCreateOrUpdateResponse, error)` info [Changelog] - New function `NewVulnerabilityAssessmentExecuteScanClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentExecuteScanClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentExecuteScanClient.BeginExecute(context.Context, string, string, VulnerabilityAssessmentName, *VulnerabilityAssessmentExecuteScanClientBeginExecuteOptions) (*runtime.Poller[VulnerabilityAssessmentExecuteScanClientExecuteResponse], error)` info [Changelog] - New function `NewVulnerabilityAssessmentRuleBaselineClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentRuleBaselineClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentRuleBaselineClient.CreateOrUpdate(context.Context, string, string, VulnerabilityAssessmentName, BaselineName, string, DatabaseSQLVulnerabilityAssessmentRuleBaselineInput, *VulnerabilityAssessmentRuleBaselineClientCreateOrUpdateOptions) (VulnerabilityAssessmentRuleBaselineClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentRuleBaselineClient.Get(context.Context, string, string, VulnerabilityAssessmentName, BaselineName, string, *VulnerabilityAssessmentRuleBaselineClientGetOptions) (VulnerabilityAssessmentRuleBaselineClientGetResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentRuleBaselineClient.NewListByBaselinePager(string, string, VulnerabilityAssessmentName, BaselineName, *VulnerabilityAssessmentRuleBaselineClientListByBaselineOptions) *runtime.Pager[VulnerabilityAssessmentRuleBaselineClientListByBaselineResponse]` info [Changelog] - New function `NewVulnerabilityAssessmentRuleBaselinesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentRuleBaselinesClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentRuleBaselinesClient.Delete(context.Context, string, string, VulnerabilityAssessmentName, BaselineName, string, *VulnerabilityAssessmentRuleBaselinesClientDeleteOptions) (VulnerabilityAssessmentRuleBaselinesClientDeleteResponse, error)` info [Changelog] - New function `NewVulnerabilityAssessmentScanResultClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentScanResultClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentScanResultClient.Get(context.Context, string, string, SQLVulnerabilityAssessmentName, string, string, *VulnerabilityAssessmentScanResultClientGetOptions) (VulnerabilityAssessmentScanResultClientGetResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentScanResultClient.NewListByScanPager(string, string, SQLVulnerabilityAssessmentName, string, *VulnerabilityAssessmentScanResultClientListByScanOptions) *runtime.Pager[VulnerabilityAssessmentScanResultClientListByScanResponse]` info [Changelog] - New function `NewVulnerabilityAssessmentScansClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentScansClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentScansClient.Get(context.Context, string, string, VulnerabilityAssessmentName, string, *VulnerabilityAssessmentScansClientGetOptions) (VulnerabilityAssessmentScansClientGetResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentScansClient.NewListBySQLVulnerabilityAssessmentsPager(string, string, VulnerabilityAssessmentName, *VulnerabilityAssessmentScansClientListBySQLVulnerabilityAssessmentsOptions) *runtime.Pager[VulnerabilityAssessmentScansClientListBySQLVulnerabilityAssessmentsResponse]` info [Changelog] - New function `NewVulnerabilityAssessmentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentsClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentsClient.Delete(context.Context, string, string, VulnerabilityAssessmentName, *VulnerabilityAssessmentsClientDeleteOptions) (VulnerabilityAssessmentsClientDeleteResponse, error)` info [Changelog] - New function `NewVulnerabilityAssessmentsSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VulnerabilityAssessmentsSettingsClient, error)` info [Changelog] - New function `*VulnerabilityAssessmentsSettingsClient.CreateOrUpdate(context.Context, string, string, VulnerabilityAssessmentName, VulnerabilityAssessment, *VulnerabilityAssessmentsSettingsClientCreateOrUpdateOptions) (VulnerabilityAssessmentsSettingsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentsSettingsClient.Get(context.Context, string, string, SQLVulnerabilityAssessmentName, *VulnerabilityAssessmentsSettingsClientGetOptions) (VulnerabilityAssessmentsSettingsClientGetResponse, error)` info [Changelog] - New function `*VulnerabilityAssessmentsSettingsClient.NewListByServerPager(string, string, *VulnerabilityAssessmentsSettingsClientListByServerOptions) *runtime.Pager[VulnerabilityAssessmentsSettingsClientListByServerResponse]` info [Changelog] - New struct `Baseline` info [Changelog] - New struct `BaselineAdjustedResult` info [Changelog] - New struct `BenchmarkReference` info [Changelog] - New struct `DatabaseKey` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSet` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSetListResult` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSetProperties` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaseline` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineInput` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineInputProperties` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListInput` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListInputProperties` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListResult` info [Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineProperties` info [Changelog] - New struct `EndpointDependency` info [Changelog] - New struct `EndpointDetail` info [Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection` info [Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult` info [Changelog] - New struct `ManagedDatabaseMoveDefinition` info [Changelog] - New struct `ManagedDatabaseMoveOperationListResult` info [Changelog] - New struct `ManagedDatabaseMoveOperationResult` info [Changelog] - New struct `ManagedDatabaseMoveOperationResultProperties` info [Changelog] - New struct `ManagedDatabaseRestoreDetailsBackupSetProperties` info [Changelog] - New struct `ManagedDatabaseRestoreDetailsUnrestorableFileProperties` info [Changelog] - New struct `ManagedDatabaseStartMoveDefinition` info [Changelog] - New struct `ManagedInstanceAdvancedThreatProtection` info [Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult` info [Changelog] - New struct `ManagedInstanceDtc` info [Changelog] - New struct `ManagedInstanceDtcListResult` info [Changelog] - New struct `ManagedInstanceDtcProperties` info [Changelog] - New struct `ManagedInstanceDtcSecuritySettings` info [Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings` info [Changelog] - New struct `ManagedLedgerDigestUploads` info [Changelog] - New struct `ManagedLedgerDigestUploadsListResult` info [Changelog] - New struct `ManagedLedgerDigestUploadsProperties` info [Changelog] - New struct `ManagedServerDNSAlias` info [Changelog] - New struct `ManagedServerDNSAliasAcquisition` info [Changelog] - New struct `ManagedServerDNSAliasCreation` info [Changelog] - New struct `ManagedServerDNSAliasListResult` info [Changelog] - New struct `ManagedServerDNSAliasProperties` info [Changelog] - New struct `OutboundEnvironmentEndpoint` info [Changelog] - New struct `OutboundEnvironmentEndpointCollection` info [Changelog] - New struct `PrivateEndpointConnectionPropertiesAutoGenerated` info [Changelog] - New struct `QueryCheck` info [Changelog] - New struct `RefreshExternalGovernanceStatusOperationResult` info [Changelog] - New struct `RefreshExternalGovernanceStatusOperationResultProperties` info [Changelog] - New struct `Remediation` info [Changelog] - New struct `ScheduleItem` info [Changelog] - New struct `ServerConfigurationOption` info [Changelog] - New struct `ServerConfigurationOptionListResult` info [Changelog] - New struct `ServerConfigurationOptionProperties` info [Changelog] - New struct `StartStopManagedInstanceSchedule` info [Changelog] - New struct `StartStopManagedInstanceScheduleListResult` info [Changelog] - New struct `StartStopManagedInstanceScheduleProperties` info [Changelog] - New struct `SynapseLinkWorkspace` info [Changelog] - New struct `SynapseLinkWorkspaceInfoProperties` info [Changelog] - New struct `SynapseLinkWorkspaceListResult` info [Changelog] - New struct `SynapseLinkWorkspaceProperties` info [Changelog] - New struct `UpdateVirtualClusterDNSServersOperation` info [Changelog] - New struct `VaRule` info [Changelog] - New struct `VirtualClusterDNSServersProperties` info [Changelog] - New struct `VulnerabilityAssessment` info [Changelog] - New struct `VulnerabilityAssessmentListResult` info [Changelog] - New struct `VulnerabilityAssessmentPolicyProperties` info [Changelog] - New struct `VulnerabilityAssessmentScanForSQLError` info [Changelog] - New struct `VulnerabilityAssessmentScanListResult` info [Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQL` info [Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLListResult` info [Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLProperties` info [Changelog] - New struct `VulnerabilityAssessmentScanResultProperties` info [Changelog] - New struct `VulnerabilityAssessmentScanResults` info [Changelog] - New field `AvailabilityZone`, `EncryptionProtector`, `Keys`, `ManualCutover`, `PerformCutover`, `PreferredEnclaveType` in struct `DatabaseProperties` info [Changelog] - New field `EncryptionProtector`, `Keys`, `ManualCutover`, `PerformCutover`, `PreferredEnclaveType` in struct `DatabaseUpdateProperties` info [Changelog] - New field `Expand`, `Filter` in struct `DatabasesClientGetOptions` info [Changelog] - New field `AvailabilityZone`, `MinCapacity`, `PreferredEnclaveType` in struct `ElasticPoolProperties` info [Changelog] - New field `AvailabilityZone`, `MinCapacity`, `PreferredEnclaveType` in struct `ElasticPoolUpdateProperties` info [Changelog] - New field `SecondaryType` in struct `InstanceFailoverGroupProperties` info [Changelog] - New field `CrossSubscriptionRestorableDroppedDatabaseID`, `CrossSubscriptionSourceDatabaseID`, `CrossSubscriptionTargetManagedInstanceID`, `IsLedgerOn`, `StorageContainerIdentity` in struct `ManagedDatabaseProperties` info [Changelog] - New field `CurrentBackupType`, `CurrentRestorePlanSizeMB`, `CurrentRestoredSizeMB`, `DiffBackupSets`, `FullBackupSets`, `LogBackupSets`, `NumberOfFilesQueued`, `NumberOfFilesRestored`, `NumberOfFilesRestoring`, `NumberOfFilesSkipped`, `NumberOfFilesUnrestorable`, `Type` in struct `ManagedDatabaseRestoreDetailsProperties` info [Changelog] - New field `NextLink` in struct `RecoverableDatabaseListResult` info [Changelog] - New field `Keys` in struct `RecoverableDatabaseProperties` info [Changelog] - New field `Expand`, `Filter` in struct `RecoverableDatabasesClientGetOptions` info [Changelog] - New field `Keys` in struct `RestorableDroppedDatabaseProperties` info [Changelog] - New field `Expand`, `Filter` in struct `RestorableDroppedDatabasesClientGetOptions` info [Changelog] - New field `IsManagedIdentityInUse` in struct `ServerDevOpsAuditSettingsProperties` info [Changelog] - New field `ExternalGovernanceStatus` in struct `ServerProperties` info [Changelog] - New field `Version` in struct `VirtualClusterProperties` info [Changelog] info [Changelog] Total 14 breaking change(s), 344 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-sql [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Interface ElasticPool has a new optional parameter availabilityZone info [Changelog] - Interface ElasticPool has a new optional parameter minCapacity info [Changelog] - Interface ElasticPool has a new optional parameter preferredEnclaveType info [Changelog] - Interface ElasticPoolUpdate has a new optional parameter availabilityZone info [Changelog] - Interface ElasticPoolUpdate has a new optional parameter minCapacity info [Changelog] - Interface ElasticPoolUpdate has a new optional parameter preferredEnclaveType info [Changelog] - Interface ManagedDatabase has a new optional parameter isLedgerOn info [Changelog] - Interface ManagedDatabaseUpdate has a new optional parameter isLedgerOn
️❌ azure-resource-manager-schemas failed [Detail]
❌Failed [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
❌sql/resource-manager [View full logs] [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from 0b79c1a5f9b8ea40f2b592a56446bffabdf9db5f. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
❌Az.sql.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.sql.DefaultTag
Generated ApiView
|
ghost
added
the
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @guptanitish-ms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @guptanitish-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
This was referenced May 10, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@guptanitish-ms Please fix CI checks errors ( |
Member
|
@v-xuto this looks like it should be a breaking change right ? Updating an existing api version inthe public repo ? |
Member
I am a bit confused . In the description you said this is adding an action to an existing api , but this looks like a completely new api version ? Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01/ManagedInstances.json:4 in 96a5c97. [](commit_id = 96a5c97, deletion_comment = False) |
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Contributor
Author
|
Created a new one here: #23926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Add action to an existing API
Asap
Asap
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.