Api Management - Versions, Revisions and Releases by darrelmiller · Pull Request #2295 · Azure/azure-rest-api-specs

darrelmiller · 2018-01-19T02:25:54Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[] If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2018-01-19T02:30:07Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2018-01-19T17:01:28Z

We made some updates in December, and moved back to working out of master. current is just a duplicate of master to allow for an easier transition. You can read more about all of the changes we made here: December 2017 Refactoring

fearthecowboy

Looks OK to me.

New APIs added -- requires ARM signoff by @ravbhatnagar

fearthecowboy · 2018-01-22T16:27:09Z

FYI; the two validation errors are being addressed with suppressions in a different PR #2257

ravbhatnagar · 2018-01-23T08:32:04Z

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/apis/{apiId}/revisions": {


Is revision an ARM resource? Is is possible to get an individual revision?

ravbhatnagar · 2018-01-23T08:35:44Z

Looks good. Just one question whether revisions is a resource and if its possible to get an individual revision.

darrelmiller · 2018-01-23T19:24:13Z

@ravbhatnagar There is no .../revisions/{revisionId} operation because it would be redundant with .../apis/{apiId} as every API is also a revision. The .../revisions operation is simply a read-only concept used to drive a UI view. It is not a ARM Resource.

ravbhatnagar · 2018-01-25T20:00:28Z

Signing off!

darrelmiller · 2018-01-30T01:29:02Z

@fearthecowboy Could you push the big green button please?

AutorestCI · 2018-01-30T02:00:41Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2018-01-30T02:00:43Z

No modification for AutorestCI/azure-sdk-for-python

AutorestCI · 2018-01-30T02:00:54Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2018-01-30T02:00:59Z

No modification for AutorestCI/azure-sdk-for-python

AutorestCI · 2018-01-30T02:30:07Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T02:30:09Z

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

AutorestCI · 2018-01-30T02:34:12Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T02:34:14Z

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

darrelmiller added 4 commits October 26, 2017 22:22

Changed title to description

d72914c

merged!

3f50832

Changes to support Revisions, Versions and Releases

da74a5c

Added examples

4a40e18

azuresdkci assigned fearthecowboy Jan 19, 2018

marstr changed the base branch from current to master January 19, 2018 16:40

fearthecowboy approved these changes Jan 22, 2018

View reviewed changes

fearthecowboy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 22, 2018

fearthecowboy assigned ravbhatnagar Jan 22, 2018

ravbhatnagar reviewed Jan 23, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 25, 2018

fearthecowboy merged commit d062804 into Azure:master Jan 30, 2018

Conversation

darrelmiller commented Jan 19, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Jan 19, 2018

Uh oh!

marstr commented Jan 19, 2018

Uh oh!

fearthecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

fearthecowboy commented Jan 22, 2018

Uh oh!

ravbhatnagar Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Jan 23, 2018

Uh oh!

darrelmiller commented Jan 23, 2018

Uh oh!

ravbhatnagar commented Jan 25, 2018

Uh oh!

darrelmiller commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

darrelmiller commented Jan 19, 2018 •

edited by azuresdkci

Loading