AzureApiManagement new entity "Tag" documented by vfedonkin · Pull Request #2257 · Azure/azure-rest-api-specs

vfedonkin · 2018-01-11T20:11:36Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

[ * ] The title of the PR is clear and informative.
[ * ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ * ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ * ] If applicable, the PR references the bug/issue that it fixes.
[ * ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ * ] I have read the contribution guidelines.
[ * ] My spec meets the review criteria:
- [ * ] The spec conforms to the Swagger 2.0 specification.
- [ * ] The spec follows the guidelines described in the Swagger checklist document.
- [ * ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

vfedonkin · 2018-01-11T20:13:06Z

@solankisamir (Samir Solanski) , could you please also review this PR?

solankisamir · 2018-01-11T20:48:09Z

Update the readme.md file with the new resource files for tags. #Resolved

solankisamir · 2018-01-11T20:50:39Z

+          "$ref": "./apimanagement.json#/definitions/Resource"
+        }
+      ],
+      "description": "Contract details."


Contract [](start = 22, length = 8)

Tag Contract Details. #Resolved

solankisamir · 2018-01-11T20:52:24Z

+        "externalDocsDescription": {
+          "type": "string",
+          "description": "Description of the external resources describing the tag."
+        }


you can put these parameters in a base contract and do allOf in CreateParameterProperties and ContractProperties. would reduce redundancy

Done. Also got rid of some unnecessary duplicates in TagContract

solankisamir · 2018-01-11T20:54:39Z

+    },
+    "OperationEntityContract": {
+      "properties": {
+        "displayName": {


is there any max/min length to any of the properties in the contract.

This is read-only contract, we never use in any put/patch requests. Should we specify min/max length anyway?

then we can specify "readonly": "true" #Resolved

solankisamir · 2018-01-12T11:58:19Z

+      "properties": {
+        "properties": {
+          "x-ms-client-flatten": true,
+          "$ref": "#/definitions/TagContractProperties",


is displayName a required property in the UpdateContract. if yes... then we dont need 2 contracts. you can just have one contract for both Create and Update.

solankisamir · 2018-01-12T12:02:25Z

+        },
+        "externalDocsDescription": {
+          "type": "string",
+          "description": "Description of the external resources describing the tag."


is there a max min to these properties also?

Yes, we need for externalDocsUrl only. Added.

solankisamir

left some minor comments. rest looks good. Thanks @vfedonkin

solankisamir · 2018-01-12T12:06:55Z

+            "$ref": "#/parameters/ProductIdParameter"
+          },
+          {
+            "$ref": "#./apimtags.json#/parameters/TagIdParameter"


#./ [](start = 21, length = 3)

maybe this is what the CI job is complaining about. #Resolved

solankisamir · 2018-01-12T12:07:11Z

+            "$ref": "#/parameters/ProductIdParameter"
+          },
+          {
+            "$ref": "#./apimtags.json#/parameters/TagIdParameter"


#./ [](start = 21, length = 3)

check this #Resolved

solankisamir · 2018-01-12T12:07:21Z

+          "200": {
+            "description": "Gets the details of the tag specified by its identifier.",
+            "schema": {
+              "$ref": "#./apimtags.json#/definitions/TagContract"


#./ [](start = 23, length = 3)

check this. #Resolved

solankisamir · 2018-01-12T12:07:58Z

+            "$ref": "#/parameters/OperationIdParameter"
+          },
+          {
+            "$ref": "#./apimtags.json#/parameters/TagIdParameter"


#./ [](start = 21, length = 3)

check this and other references below. #Resolved

solankisamir · 2018-01-12T12:09:31Z

            "$ref": "#/parameters/ApiIdParameter"
          },
+          {
+            "$ref": "#./apimtags.json#/parameters/TagIdParameter"


#./ [](start = 21, length = 3)

you can fix this and run the tool https://github.com/Azure/oav locally before submitting again. #Resolved

fearthecowboy · 2018-01-17T16:36:46Z

Hey @solankisamir / vfedonkin

Can y'all ping me when you're ready for me to review this?

fearthecowboy · 2018-01-17T19:17:44Z

+        "tags": [
+          "ProductTags"
+        ],
+        "operationId": "Tags_ListByProduct",


This operation is Tags_ListByProduct the next is Tag_HeadByProduct

The prefix should be consistent between operations (Tag or Tags, but not both)

We have used a singular case in all other operations. @vfedonkin let's use Tag.

Done, using "Tag" everywhere.

fearthecowboy · 2018-01-17T19:21:51Z

+        "tags": [
+          "ProductTags"
+        ],
+        "operationId": "Tag_DeleteFromProduct",


I'd recommend this was just Tag_Delete -- the operation Id is used to generate method names, and unless there is an overriding or compelling reason, we'd like to stick to common patterns.

Renamed to Tag_DetachFromProduct. Same for Tag_DetachFromApi and Tag_DetachFromOperation

fearthecowboy · 2018-01-17T19:22:19Z

+        "tags": [
+          "ProductTags"
+        ],
+        "operationId": "Tag_CreateOrUpdateForProduct",


I'd recommend this was just Tag_CreateOrUpdate -- the operation Id is used to generate method names, and unless there is an overriding or compelling reason, we'd like to stick to common patterns.

Renamed to Tag_AssignToProduct. Same for Tag_AssignToApi and Tag_AssignToOperation

fearthecowboy · 2018-01-17T19:23:04Z

+        "tags": [
+          "ProductTags"
+        ],
+        "operationId": "Tag_GetByProduct",


I'd recommend this was just Tag_Get -- the operation Id is used to generate method names, and unless there is an overriding or compelling reason, we'd like to stick to common patterns.

@fearthecowboy
We already have Tag_Get in apimtags.json with url like
".../service/{serviceName}/tags/{tagId}"
Can we use the same operationId for
".../service/{serviceName}/products/{productId}/tags/{tagId}" ?

fearthecowboy · 2018-01-17T19:23:22Z

+        "tags": [
+          "ProductTags"
+        ],
+        "operationId": "Tag_HeadByProduct",


We don't see a lot of HEAD operations.

The operationId should describe what the operation does, not the HTTP Method used-- I'd suggest Tag_GetEntityState

Done. The same for apis/operations/tags entities.

fearthecowboy · 2018-01-17T19:36:39Z

@vfedonkin

We already have Tag_Get in apimtags.json with url like
".../service/{serviceName}/tags/{tagId}"
Can we use the same operationId for
".../service/{serviceName}/products/{productId}/tags/{tagId}" ?

Ah, I'm just seeing that.

HMMMM.

No, we definitely can't have duplicate operationIds.

In that case, this could remain the way it is.

fearthecowboy · 2018-01-17T22:05:38Z

Adding @ravbhatnagar -- new APIs require ARM signoff.

fearthecowboy

Just a couple of things; nothing serious.

We should put a suppression in the readme.md for the two linter violations; add a section that looks like this:

# Suppressions

``` yaml
directive: 
  - suppress: R3016
     reason: existing properties, can't be changed without breaking API.
```

fearthecowboy · 2018-01-17T19:29:26Z

+          "ProductTags"
+        ],
+        "operationId": "Tag_DeleteFromProduct",
+        "description": "Detach the tag from the Product.",


The description "Detach the tag from the Product.", sounds like the tag still exists once deleted. Can we say Deletes or removes ?

Tag is really exists as an entity, it's just detached from the product.

Oh. interesting.

fearthecowboy · 2018-01-17T19:31:10Z

+        "tags": [
+          "TagResources"
+        ],
+        "operationId": "TagResources_ListByService",


this operationId prefix is plural- while that is the preferred way, the rest of the service is singular. These should be consistent.

fearthecowboy · 2018-01-17T22:25:37Z

+        "tags": [
+          "OperationTags"
+        ],
+        "operationId": "Tag_HeadByOperation",


Perhaps Tag_GetEntityStateByOperation ?

fearthecowboy

I'm good with the state of this. Awaiting ARM signoff from @ravbhatnagar

AutorestCI · 2018-01-30T19:46:48Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpowe3k_jh/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpowe3k_jh/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->2.1.68)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\82_20180129T185436\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\82_20180129T185436\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\82_20180129T185436\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\82_20180129T185436\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\82_20180129T185436\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

AutorestCI · 2018-01-30T19:49:37Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

vfedonkin · 2018-01-30T20:20:45Z

@fearthecowboy, conflicts solved, ok to merge.

fearthecowboy · 2018-01-30T22:00:41Z

You have some validation issues : https://travis-ci.org/Azure/azure-rest-api-specs/jobs/335311496

vfedonkin · 2018-01-31T01:32:29Z

@fearthecowboy, validation issues are not related to my changes but I will investigate what's wrong.

vfedonkin · 2018-01-31T19:05:44Z

Moved all tags-related paths to apimtags.json file since apimapis.json is already too huge.

AutorestCI · 2018-01-31T19:31:09Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-31T19:40:09Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxg4bg8iq/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxg4bg8iq/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Installing AutoRest extension '@microsoft.azure/autorest.go' (preview)
VERBOSE: [FYI- npm does not currently support progress... this may take a few moments]
VERBOSE: Running  npm install for @microsoft.azure/autorest.go, 2.1.69
VERBOSE: npm install completed @microsoft.azure/autorest.go, 2.1.69
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

vfedonkin · 2018-01-31T19:55:28Z

@fearthecowboy, could you please check now? I left apimapis.json file as it was before, without any changes.

azuresdkciprbot · 2018-01-31T20:24:48Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-01-31T20:42:31Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpf7evxdb2/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpf7evxdb2/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->2.1.69)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHs0k5t\87_20180131T193539\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

solankisamir · 2018-02-02T02:30:04Z

@fearthecowboy a gentle ping on this one.

fearthecowboy · 2018-02-02T18:33:46Z

@solankisamir - there's a validation error (I don't think caused by this PR, happened somewhere along the way with all those being pushed thru this week).

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/335805386#L741

It looks like it's pretty minor, can you take a quick look and see if we can fix up what went wrong so we have a clean validation with this one?

vfedonkin · 2018-02-02T19:51:55Z

@fearthecowboy , we couldn't fix this issue, as we understand it's an issue with validation tool itself.
It doesn't support boolean parameters in examples.

Below is a parameter definition:
{
"name": "deleteSubscriptions",
"in": "query",
"required": false,
"type": "boolean",
"description": "Delete existing subscriptions to the product or not."
},

And this is a sample file:
{
"parameters": {
"serviceName": "apimService1",
"resourceGroupName": "rg1",
"api-version": "2017-03-01",
"subscriptionId": "subid",
"productId": "testproduct",
"deleteSubscriptions": "true",
"If-Match": "*"
},
"responses": {
"204": {}
}
}

What is the best way to fix it?
Thanks,
Vitaliy.

fearthecowboy · 2018-02-02T19:53:21Z

true should not be in quotes. "true" is not a boolean value

vfedonkin · 2018-02-02T19:57:43Z

We tried, it didn't help.
We have exactly the same error when we run this test tool locally:
oav validate-example <...>\specification\apimanagement\resource-manager\Microsoft.ApiManagement\stable\2017-03-01\apimproducts.json

fearthecowboy · 2018-02-05T22:40:45Z

@vfedonkin - I'll try doing this locally and grab @amarzavery if it's not workable.

solankisamir · 2018-02-07T02:02:42Z

@fearthecowboy any update on this.

AutorestCI · 2018-02-07T18:48:32Z

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

AutorestCI · 2018-02-07T18:52:02Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmphflqx9kw/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmphflqx9kw/sdk', '--multiapi', '--package-version=nightly', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/nightly services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

azuresdkciprbot · 2018-02-07T18:53:08Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

fearthecowboy · 2018-02-07T18:54:28Z

@vfedonkin - It was exactly as I said; the quotes around "true" was causing it to fail. I fixed it in your branch for you.

AutorestCI · 2018-02-07T19:00:39Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp9t3lyyca/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp9t3lyyca/sdk', '--multiapi', '--package-version=nightly', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/nightly services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4244/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4244)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8fzkm\78_20180205T234947\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

APIM tags documentation

574374c

azuresdkci assigned fearthecowboy Jan 11, 2018

solankisamir reviewed Jan 11, 2018

View reviewed changes

some small changes after code review

f5fab07

solankisamir reviewed Jan 12, 2018

View reviewed changes

solankisamir approved these changes Jan 12, 2018

View reviewed changes

solankisamir reviewed Jan 12, 2018

View reviewed changes

vfedonkin added 2 commits January 12, 2018 16:22

some small changes and examples fixes after code review

58ff5cb

some small changes and examples fixes after code review

a79b720

fearthecowboy reviewed Jan 17, 2018

View reviewed changes

operation IDs changed after code review

0b4fe98

fearthecowboy assigned ravbhatnagar Jan 17, 2018

fearthecowboy reviewed Jan 17, 2018

View reviewed changes

changes after code review, suppressions

3b1270a

fearthecowboy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 22, 2018

fearthecowboy approved these changes Jan 22, 2018

View reviewed changes

fearthecowboy mentioned this pull request Jan 22, 2018

Api Management - Versions, Revisions and Releases #2295

Merged

9 tasks

Merge branch 'master' into master

4018c31

moved all tags related paths into apimtags.json file

fae545d

vfedonkin added 2 commits January 31, 2018 12:11

rolled back to boolean type in parameters

6344a0a

rolled back to boolean type in parameters

a23c667

Update ApiManagementDeleteProduct.json

607d978

fearthecowboy merged commit f633051 into Azure:master Feb 7, 2018

solankisamir mentioned this pull request Feb 8, 2018

moved tags related paths into one file so operations prefixes is grouped by files #2449

Merged

Conversation

vfedonkin commented Jan 11, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

vfedonkin commented Jan 11, 2018

Uh oh!

solankisamir commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solankisamir Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir left a comment

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fearthecowboy commented Jan 17, 2018

Uh oh!

fearthecowboy Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vfedonkin commented Jan 11, 2018 •

edited by azuresdkci

Loading

solankisamir commented Jan 11, 2018 •

edited

Loading

solankisamir Jan 11, 2018 •

edited

Loading

solankisamir Jan 11, 2018 •

edited

Loading

solankisamir Jan 12, 2018 •

edited

Loading

solankisamir Jan 12, 2018 •

edited

Loading

solankisamir Jan 12, 2018 •

edited

Loading

solankisamir Jan 12, 2018 •

edited

Loading

solankisamir Jan 12, 2018 •

edited

Loading

fearthecowboy Jan 17, 2018 •

edited

Loading

fearthecowboy Jan 17, 2018 •

edited

Loading

fearthecowboy Jan 17, 2018 •

edited

Loading

fearthecowboy Jan 17, 2018 •

edited

Loading

fearthecowboy Jan 17, 2018 •

edited

Loading