Skip to content

Event Hubs: Removed AvroDeflate from CaptureDescription - encoding#2268

Merged
sergey-shandar merged 2 commits intoAzure:masterfrom
v-Ajnava:currentEH
Jan 23, 2018
Merged

Event Hubs: Removed AvroDeflate from CaptureDescription - encoding#2268
sergey-shandar merged 2 commits intoAzure:masterfrom
v-Ajnava:currentEH

Conversation

@v-Ajnava
Copy link
Contributor

@v-Ajnava v-Ajnava commented Jan 16, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Changes in this PR

  • Removed 'AvroDeflate' from CaptureDescription - encoding

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@v-Ajnava v-Ajnava changed the base branch from master to current January 16, 2018 04:17
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@marstr marstr changed the base branch from current to master January 16, 2018 20:59
@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 17, 2018
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need ARM approval.

@ravbhatnagar
Copy link
Contributor

New api-version

@v-Ajnava
Copy link
Contributor Author

@ravbhatnagar and @sergey-shandar , here is the Service Bus PR #2267. we have reverted the the change and put a comment in redme.md file, about enum value been deprecated and will not be returned from service. at Service level it will be handled.
shall we implement same here ?

@ravbhatnagar
Copy link
Contributor

Not returning it from the service is still a breaking change. Its an API breaking change. New api-version.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@v-Ajnava
Copy link
Contributor Author

@ravbhatnagar and @sergey-shandar ,I have reverted the change and updated description of the enum

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 23, 2018
@ravbhatnagar
Copy link
Contributor

Signing off!

@sergey-shandar sergey-shandar merged commit db70a06 into Azure:master Jan 23, 2018
@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants