Service Bus : New Property deadLetteringOnFilterEvaluationExceptions added and AvroDeflate removed by v-Ajnava · Pull Request #2267 · Azure/azure-rest-api-specs

v-Ajnava · 2018-01-16T04:15:50Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Changes in this PR

Added 'deadLetteringOnFilterEvaluationExceptions' for subscriptions and updated examples
Removed 'AvroDeflate' from CaptureDescription - encoding

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- [ X] The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

fearthecowboy · 2018-01-16T16:10:23Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

          "description": "Enumerates the possible values for the encoding format of capture description.",
          "enum": [
-            "Avro",
-            "AvroDeflate"


Deleting an enum value is a Binary Breaking Change in SDKs; this is typically not permitted.

If this value is only used in a model schema that is returned from the service, I recommend that you leave it in the enum, and make a remark about it in the readme.md file indicating that the value is deprecated and not returned from the service.

Removing the enum value at this point is not recommended.

fearthecowboy · 2018-01-16T16:25:37Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

          "type": "string",
          "description": "ISO 8061 Default message timespan to live value. This is the duration after which the message expires, starting from when the message is sent to Service Bus. This is the default value used when TimeToLive is not set on a message itself."
        },
+        "deadLetteringOnFilterEvaluationExceptions": {


Adding a property on an existing model -- ( //cc @ravbhatnagar )

Looks ok to me.

fearthecowboy

FYI: You have a couple of failures in the semantic validator - https://travis-ci.org/Azure/azure-rest-api-specs/jobs/329350277

I'd rather not remove the existing enum value; this will cause binary breaking changes in the generated SDKs.

Recommended to leave the value in, and make a note of it in the readme.md file

azuresdkciprbot · 2018-01-17T12:57:28Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

…i-specs into currentSB # Conflicts: # specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

azuresdkciprbot · 2018-01-17T23:31:43Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

fearthecowboy

Looks good to me.

fearthecowboy · 2018-01-22T16:30:48Z

@v-Ajnava I'm ok with this; are you ready to have this merged?

v-Ajnava · 2018-01-22T18:10:03Z

@fearthecowboy , yes you can merge. Thanks !

AutorestCI · 2018-01-22T18:11:00Z

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

AutorestCI · 2018-01-22T18:15:01Z

Azure/azure-sdk-for-ruby#1246

AutorestCI · 2018-01-22T18:15:31Z

Azure/azure-sdk-for-python#1816

Ajit Maruti Navasare (MINDTREE LIMITED) added 3 commits January 4, 2018 16:06

added a missing property

ec15185

updated examples

46868a5

removed AvroDeflate from CaptureDescription - encoding

0ebc8e8

azuresdkci assigned fearthecowboy Jan 16, 2018

fixed syntax error in example

f79ad77

fearthecowboy reviewed Jan 16, 2018

View reviewed changes

fearthecowboy suggested changes Jan 16, 2018

View reviewed changes

marstr changed the base branch from current to master January 16, 2018 20:59

Review comments resolved

95779b8

Ajit Maruti Navasare (MINDTREE LIMITED) added 2 commits January 17, 2018 15:17

Reverted 'AvroDeflate' removal and added comment in readme.md

4c15c50

Merge branch 'currentSB' of https://github.com/v-Ajnava/azure-rest-ap…

0e46f7e

…i-specs into currentSB # Conflicts: # specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

v-Ajnava mentioned this pull request Jan 18, 2018

Event Hubs: Removed AvroDeflate from CaptureDescription - encoding #2268

Merged

10 tasks

fearthecowboy approved these changes Jan 22, 2018

View reviewed changes

fearthecowboy added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jan 22, 2018

fearthecowboy merged commit 5942709 into Azure:master Jan 22, 2018

AutorestCI mentioned this pull request Jan 22, 2018

Automatic PR from RestAPI-PR2267 Azure/azure-sdk-for-ruby#1246

Closed

AutorestCI mentioned this pull request Jan 22, 2018

[ServiceBus] Automatic PR from RestAPI-PR2267 Azure/azure-sdk-for-python#1816

Merged

v-Ajnava mentioned this pull request Feb 28, 2018

ServiceBus: properties added to queue and subscription Azure/azure-sdk-for-net#4097

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service Bus : New Property deadLetteringOnFilterEvaluationExceptions added and AvroDeflate removed#2267

Service Bus : New Property deadLetteringOnFilterEvaluationExceptions added and AvroDeflate removed#2267
fearthecowboy merged 7 commits intoAzure:masterfrom
v-Ajnava:currentSB

v-Ajnava commented Jan 16, 2018 •

edited by azuresdkci

Loading

Uh oh!

fearthecowboy Jan 16, 2018 •

edited

Loading

Uh oh!

fearthecowboy Jan 16, 2018 •

edited

Loading

Uh oh!

fearthecowboy left a comment

Uh oh!

azuresdkciprbot commented Jan 17, 2018

Uh oh!

azuresdkciprbot commented Jan 17, 2018

Uh oh!

fearthecowboy left a comment

Uh oh!

fearthecowboy commented Jan 22, 2018

Uh oh!

v-Ajnava commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

v-Ajnava commented Jan 16, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this PR

PR information

Quality of Swagger

Uh oh!

fearthecowboy Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fearthecowboy Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fearthecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Jan 17, 2018

Uh oh!

azuresdkciprbot commented Jan 17, 2018

Uh oh!

fearthecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

fearthecowboy commented Jan 22, 2018

Uh oh!

v-Ajnava commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

AutorestCI commented Jan 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v-Ajnava commented Jan 16, 2018 •

edited by azuresdkci

Loading

fearthecowboy Jan 16, 2018 •

edited

Loading

fearthecowboy Jan 16, 2018 •

edited

Loading