add AVS 2022-05-01 API #20873
Merged
add AVS 2022-05-01 API #20873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and replace subscription-id in examples
|
Hi, @cataggar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @cataggar your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| vmware.json | 2022-05-01(d3342cb) | 2021-12-01(main) |
| vmware.json | 2022-05-01(d3342cb) | 2021-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-05-01 | package-2022-05-01(d3342cb) | default(main) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
Tag package-2022-05-01; Prod region: Not deployed; Canary region: Not deployed
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/d3342cb7369489e3e84ca2964727092ead79491d/specification/vmware/resource-manager/readme.md#tag-package-2022-05-01">vmware/resource-manager/readme.md#package-2022-05-01
| Rule | Message |
|---|---|
| "readme":"vmware/resource-manager/readme.md", "tag":"package-2022-05-01", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @cataggar, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Sep 26, 2022
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
Member
Author
|
I submitted a Swagger Suppression Request just now. |
leniatgh
added
the
WaitForARMFeedback
Contributor
|
@mentat9 please review the suppression in readme.md, which is made after ARM sign-off |
Member
@leni-msft - I don't really know these rules or even where they are defined, so I reviewed just using the names. I find PatchSkuProperty, LroPatch202, ArmResourcePropertiesBag, UnSupportedPatchProperties to be suspect from the ARM perspective, but AFAICT, those are all flagging existing APIs, not APIs newly added in this PR. There appear to be many issues with this spec from ARM perspective, but the current review only covers the changes in this PR, not the entire API surface. |
Member
Author
That is correct. These suppressions are for existing APIs, not newly added APIs. Most are documented at: |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
raosuhas
removed
the
WaitForARMFeedback
|
Review has already been signed off from ARM. Please remove "ARMSignedOff" and add "WaitForARMFeedback" if you need us to take another look |
Member
Member
Author
|
@qiaozha, can you merge this now that suppression has been approved? |
qiaozha
approved these changes
Oct 12, 2022
This was referenced Oct 12, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Oct 12, 2022
3 tasks
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
* copy 2021-12-01 * replace api-version and replace subscription-id in examples * allow specifying a sku in Locations_CheckTrialAvailability * add Clusters_ListZones * add WorkloadNetworks_Get & WorkloadNetworks_List * Arc Addons * add readOnly nsxPublicIpQuotaRaised flag to PrivateCloudProperties * add readonly autoDetectedKeyVersion to EncryptionKeyVaultProperties * definition of WorkloadNetwork & WorkloadNetworkList * add affinityStrength and azureHybridBenefitType to VmHostPlacementPolicyProperties * add affinityStrength and azureHybridBenefitType to PlacementPolicyUpdateProperties * add definitions for ClusterZone and ClusterZoneList * add company and uri to ScriptPackageProperties * add to readme * add x-ms-identifiers * suppress ParametersOrder * fix Azure#20902. add Canceled to all provisioningState * fix trial spelling * add workloadNetworkName param to WorkloadNetworks_Get * use v3/types in new operations Clusters_ListZones, WorkloadNetworks_Get, WorkloadNetworks_List * fix response type for WorkloadNetworks_List * remove empty property bags * add workloadNetworkName to WorkloadNetworks_Get example * use suppressions * restore AutoRest v2 Suppressions * fix ConsistentPatchProperties by using PlacePolicy resource directly in PlacementPolicies_Update * Revert "fix ConsistentPatchProperties by using PlacePolicy resource directly in PlacementPolicies_Update" This reverts commit b88a2c0. * suppress ConsistentPatchProperties * suppress DefinitionsPropertiesNamesCamelCase & ArmResourcePropertiesBag * suppress DeleteOperationAsyncResponseValidation * add 202 responses to PrivateClouds_Update & Clusters_Update * just warnings * suppress PatchSkuProperty * Revert "add 202 responses to PrivateClouds_Update & Clusters_Update" This reverts commit 9d6abb1. * suppress LroPatch202 * suppress UnSupportedPatchProperties `name` & `type` * suppress XmsLongRunningOperationOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior internal review was completed in https://github.com/Azure/azure-rest-api-specs-pr/pull/5032 .
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.