CLI SDK Update to 2022-05-01 API #5397

jonathanhe-msft · 2022-09-28T14:34:28Z

Update to AVS 2022-05-01 API
Add az vmware cluster list-zones
Add --affinity-strength and --azure-hybrid-benefit-type parameter to az vmware placement-policy vm-host create
Add --affinity-strength and --azure-hybrid-benefit-type parameter to az vmware placement-policy vm-host update
Add --express-route-id parameter to az vmware authorization create
Add vmware addon arc command group
Add az vmware location check-trial-availability
Add az vmware location check-quota-availability
Deprecate az vmware location checktrialavailability
Deprecate az vmware location checkquotaavailability
[BREAKING CHANGE] az vmware private-cloud add-availability-zone has been removed. Availability zone cannot be modified after private cloud creation
[BREAKING CHANGE] az vmware private-cloud delete-availability-zone has been removed. Availability zone cannot be modified after private cloud creation.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

yonzhan · 2022-09-28T14:44:10Z

vmware

src/vmware/HISTORY.md

wangzelin007 · 2022-10-07T06:24:07Z

/azp run

azure-pipelines · 2022-10-07T06:24:19Z

Azure Pipelines successfully started running 1 pipeline(s).

cataggar

With Azure/azure-rest-api-specs#20873 finally merged, please use the published spec.

src/vmware/HISTORY.md

jonathanhe-msft · 2022-10-17T16:02:47Z

With Azure/azure-rest-api-specs#20873 finally merged, please use the published spec.

Regenerated client using latest published in azure-rest-api-specs

cataggar · 2022-10-27T14:24:04Z

@jonathanhe-msft, linter is failing with:

-  FAIL - HIGH severity: unrecognized_help_entry_rule
    Help-Entry: `vmware workload-network list` - Not a recognized command or command-group
    Help-Entry: `vmware workload-network show` - Not a recognized command or command-group

Looks like you need to remove that help for the removed commands.

src/vmware/DEVELOPMENT.md

jonathanhe-msft · 2022-11-07T16:51:35Z

@zhoxing-ms can I get a review on this please? thank you!

src/vmware/HISTORY.md

Co-authored-by: Xing Zhou <[email protected]>

src/vmware/azext_vmware/commands.py

src/vmware/HISTORY.md

…-msft/azure-cli-extensions into jonathanhe/api-update

jonathanhe-msft · 2022-12-06T17:51:08Z

@zhoxing-ms this is ready for final review and to be merged. Thanks!

zhoxing-ms · 2022-12-07T09:29:51Z

src/vmware/HISTORY.md

+- Add `az vmware cluster list-zones`
+- Add `--affinity-strength` and `--azure-hybrid-benefit-type` parameters to `az vmware placement-policy vm-host create`
+- Add `--affinity-strength` and `--azure-hybrid-benefit-type` parameters to `az vmware placement-policy vm-host update`
+- Add `--express-route-id` parameter to `az vmware authorization create`
+- Add `vmware addon arc` command group
+- Add `az vmware location check-trial-availability`
+- Add `az vmware location check-quota-availability`


Could you please add some description for these new commands and new parameters?

There's a separate help.py file that contains help for each of these commands and parameters. I'd also like to keep the HISTORY.md file minimal for readability.

src/vmware/azext_vmware/_params.py

azclibot · 2022-12-08T06:34:55Z

[Release] Update index.json for extension [ vmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=19884&view=results

zhoxing-ms · 2022-12-08T10:33:24Z

src/vmware/azext_vmware/vendored_sdks/__init__.py

-# coding=utf-8
-# --------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for
-# license information.
-#
-# Code generated by Microsoft (R) AutoRest Code Generator.
-# Changes may cause incorrect behavior and will be lost if the code is
-# regenerated.
-# --------------------------------------------------------------------------
-
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)


Please do not remove this file, it will cause a CI problem in main CLI pipeline pipeline link

File "/opt/az/azcliextensions/vmware/azext_vmware/custom.py", line 8, in
from azext_vmware.vendored_sdks.avs_client import AVSClient
ModuleNotFoundError: No module named 'azext_vmware.vendored_sdks'

@jonathanhe-msft Could you please add this file back as soon as possible to unblock our CI?

It was restored in #5619 and published as 5.0.1.

jonathanhe-msft added 5 commits September 23, 2022 14:57

private-cloud create availability changes

f86287a

Merge branch 'main' into jonathanhe/api-update

b14fdc8

updated sdk to 2022-05-01 api version

b770773

Merge branch 'main' into jonathanhe/api-update

8e3816b

update to 2022-05-01 api

2bf2aa3

ghost added the Auto-Assign Auto assign by bot label Sep 28, 2022

ghost requested review from kairu-ms and necusjz September 28, 2022 14:34

ghost assigned kairu-ms Sep 28, 2022

ghost added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 28, 2022

ghost requested review from wangzelin007, yonzhan and zhoxing-ms September 28, 2022 14:34

ghost assigned zhoxing-ms Sep 28, 2022

ghost added the Compute label Sep 28, 2022

yonzhan modified the milestones: Sep 2022 (2022-10-12) - For Ignite, Oct 2022 (2022-11-01) Sep 28, 2022

cataggar reviewed Sep 28, 2022

View reviewed changes

src/vmware/HISTORY.md Outdated Show resolved Hide resolved

src/vmware/HISTORY.md Outdated Show resolved Hide resolved

jonathanhe-msft changed the title ~~Jonathanhe/api update~~ CLI SDK Update to 2022-05-01 API Sep 28, 2022

removed workload-network get and show

eea5364

cataggar reviewed Oct 13, 2022

View reviewed changes

src/vmware/HISTORY.md Outdated Show resolved Hide resolved

jonathanhe-msft added 2 commits October 17, 2022 11:56

updated history and version

9597825

regenerated sdk using latest published version in azure-rest-api-specs

05dcc66

fixed linter issues

21bd6ac

jonathanhe-msft marked this pull request as ready for review October 24, 2022 17:16

cataggar removed the Auto-Assign Auto assign by bot label Oct 27, 2022

cataggar added AVS and removed Compute labels Oct 27, 2022

fix lint errors

dd8eb5a

cataggar approved these changes Oct 27, 2022

View reviewed changes

src/vmware/DEVELOPMENT.md Show resolved Hide resolved

kairu-ms removed their assignment Oct 31, 2022

zhoxing-ms reviewed Nov 8, 2022

View reviewed changes

src/vmware/HISTORY.md Outdated Show resolved Hide resolved

Update src/vmware/HISTORY.md

41d46ca

Co-authored-by: Xing Zhou <[email protected]>

zhoxing-ms reviewed Nov 9, 2022

View reviewed changes

src/vmware/azext_vmware/commands.py Show resolved Hide resolved

zhoxing-ms reviewed Nov 9, 2022

View reviewed changes

src/vmware/HISTORY.md Show resolved Hide resolved

cataggar approved these changes Dec 6, 2022

View reviewed changes

src/vmware/HISTORY.md Outdated Show resolved Hide resolved

jonathanhe-msft added 3 commits December 6, 2022 12:48

release date update

f5f66c1

Merge branch 'jonathanhe/api-update' of https://github.com/jonathanhe…

1281ed0

…-msft/azure-cli-extensions into jonathanhe/api-update

Merge branch 'main' into jonathanhe/api-update

45f84e8

zhoxing-ms reviewed Dec 7, 2022

View reviewed changes

src/vmware/azext_vmware/_params.py Outdated Show resolved Hide resolved

help text capitalization update

59c217c

zhoxing-ms approved these changes Dec 8, 2022

View reviewed changes

zhoxing-ms merged commit 83ba1e9 into Azure:main Dec 8, 2022

zhoxing-ms reviewed Dec 8, 2022

View reviewed changes

jonathanhe-msft deleted the jonathanhe/api-update branch August 18, 2023 16:50

CLI SDK Update to 2022-05-01 API #5397

CLI SDK Update to 2022-05-01 API #5397

Uh oh!

Conversation

jonathanhe-msft commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

yonzhan commented Sep 28, 2022

Uh oh!

Uh oh!

Uh oh!

wangzelin007 commented Oct 7, 2022

Uh oh!

azure-pipelines bot commented Oct 7, 2022

Uh oh!

cataggar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonathanhe-msft commented Oct 17, 2022

Uh oh!

cataggar commented Oct 27, 2022

Uh oh!

Uh oh!

jonathanhe-msft commented Nov 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonathanhe-msft commented Dec 6, 2022

Uh oh!

zhoxing-ms Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

jonathanhe-msft Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azclibot commented Dec 8, 2022

Uh oh!

zhoxing-ms Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cataggar Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jonathanhe-msft commented Sep 28, 2022 •

edited

Loading

zhoxing-ms Dec 8, 2022 •

edited

Loading

cataggar Dec 9, 2022 •

edited

Loading