Add restler config to improve coverage of appconfig traffic validation by mikekistler · Pull Request #20548 · Azure/azure-rest-api-specs

mikekistler · 2022-09-01T14:59:07Z

This PR adds an annotations.json file for appconfiguration mgmt plane API to improve the coverage of traffic validation PR check.

openapi-workflow-bot · 2022-09-01T14:59:11Z

Hi, @mikekistler Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-09-01T14:59:11Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v1.13.0)	new version	base version
default	default(0e21a6a)	default(main)

️❌Avocado: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` UNREFERENCED_JSON_FILE	The swagger JSON file is not referenced from the readme file. readme: specification/appconfiguration/resource-manager/readme.md json: stable/2022-05-01/restler/annotations.json

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

️❌~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]

️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` unacceptable kind of an object to dump [object Error]	"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/0e21a6a5518f94513e7091ac5aa5df3ae6240b83/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/restler/annotations.json"

️❌SemanticValidation: 3 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: swagger JsonUrl: stable/2022-05-01/restler/annotations.json
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: info JsonUrl: stable/2022-05-01/restler/annotations.json
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: paths JsonUrl: stable/2022-05-01/restler/annotations.json

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-01T14:59:12Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-appconfiguration [View full logs] [Release SDK Changes]
- azure-mgmt-appconfiguration-2.2.0.zip
- azure_mgmt_appconfiguration-2.2.0-py3-none-any.whl
```
info	[Changelog]
```

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.AppConfiguration [View full logs] [Release SDK Changes]
- Azure.ResourceManager.AppConfiguration.1.1.0-alpha.20221008.1.nupkg
```
info	[Changelog]
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appconfiguration [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appconfiguration [View full logs] [Release SDK Changes]

azure-arm-appconfiguration-3.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ConfigurationStore
info	[Changelog]   - Added Interface TrackedResource

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appconfiguration/armappconfiguration [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 35388d9. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️appconfiguration [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 35388d9. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.AppConfiguration [View full logs] [Release SDK Changes]
- Az.AppConfiguration.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-01T14:59:13Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appconfiguration/armappconfiguration	https://apiview.dev/Assemblies/Review/eb567827ce2046d29a23e8dc755e9c13
Python	track2_azure-mgmt-appconfiguration	https://apiview.dev/Assemblies/Review/862caec438e2470c9d8fdf954b2999ed
Java	azure-resourcemanager-appconfiguration	https://apiview.dev/Assemblies/Review/1a7f7f0b72d04397ab46d50beaf10be0
.Net	Azure.ResourceManager.AppConfiguration	There is no API change compared with the previous version
JavaScript	@azure/arm-appconfiguration	https://apiview.dev/Assemblies/Review/f3b46638f9284a118acfda100f9c2283

openapi-workflow-bot · 2022-09-02T02:24:00Z

Hi @mikekistler, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

raych1 · 2022-09-06T01:13:06Z

@mikekistler , would you mind fix both PrettieCheck and SpellCheck errors? For other checks I think we can ignore them.

mikekistler · 2022-09-30T14:27:44Z

@raych1 could you please merge this? I do not have permissions.

Azure#20548) * Add restler config to improve coverage of appconfig traffic validation * Fix prettier and cspell issues

Add restler config to improve coverage of appconfig traffic validation

878d59d

openapi-assignment-bot bot assigned raych1 Sep 1, 2022

openapi-pipeline-app bot added the resource-manager label Sep 1, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 2, 2022

raych1 approved these changes Sep 6, 2022

View reviewed changes

Fix prettier and cspell issues

0e21a6a

azure-sdk mentioned this pull request Sep 7, 2022

[AutoPR Az.appconfiguration] Add restler config to improve coverage of appconfig traffic validation azure-sdk/azure-powershell#2226

Closed

raych1 approved these changes Sep 20, 2022

View reviewed changes

raych1 added Approved-Avocado Approved-ModelValidation Approved-SemanticValidation labels Oct 8, 2022

raych1 merged commit 35388d9 into Azure:main Oct 8, 2022

azure-sdk mentioned this pull request Oct 8, 2022

[ReleasePR @azure/arm-appconfiguration] Update App Configuration management plane API description Azure/azure-sdk-for-js#21561

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add restler config to improve coverage of appconfig traffic validation#20548

Add restler config to improve coverage of appconfig traffic validation#20548
raych1 merged 2 commits intoAzure:mainfrom
mikekistler:restler-config-for-appconfig

mikekistler commented Sep 1, 2022

Uh oh!

openapi-workflow-bot bot commented Sep 1, 2022

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Sep 2, 2022

Uh oh!

raych1 commented Sep 6, 2022

Uh oh!

mikekistler commented Sep 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mikekistler commented Sep 1, 2022

Uh oh!

openapi-workflow-bot bot commented Sep 1, 2022

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot bot commented Sep 2, 2022

Uh oh!

raych1 commented Sep 6, 2022

Uh oh!

mikekistler commented Sep 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 1, 2022 •

edited

Loading