GET snapshot-Changed CopyCompletionError enum name#19227
Merged
haagha merged 1 commit intoAzure:diskrp-2022-03-02from May 25, 2022
Merged
Conversation
|
Hi, @haagha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
This was referenced May 25, 2022
Closed
ArcturusZhang
pushed a commit
that referenced
this pull request
May 30, 2022
* new version folder * new version folder * sync with diskRP 2021-12-01 changes * Update creationData description (#18050) * Update diskRPCommon.json * Update diskRPCommon.json * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * New ApI Version * Readme changes * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * GET snapshot-Changed CopyCompletionError enum name (#19160) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * move UserAssignedIdentities to common.json to fix duplicate definition * update readme with gallery 2022-01-03 * sync with past updates * update with description for object * fix readme * GET snapshot-Changed CopyCompletionError enum name (#19227) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * fixing readme.md * fix vmss userAssignedIdentities duplicate definition Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: parkhyukjun89 <hyupar@microsoft.com> Co-authored-by: Akash Pargat <akashpargat@yahoo.com> Co-authored-by: akashpargat <akashpargat@microsoft.com> Co-authored-by: jerryc3 <48365571+jerryc3@users.noreply.github.com> Co-authored-by: Jerry Chan <jerch@microsoft.com> Co-authored-by: Karan Manish Thakkar <kkaran.thakkar@gmail.com> Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.