adding SecurityProfile in DiskRestorePointProperties#18826
Merged
haagha merged 1 commit intoAzure:feature/cplat-2022-03-02from Apr 28, 2022
Merged
adding SecurityProfile in DiskRestorePointProperties#18826haagha merged 1 commit intoAzure:feature/cplat-2022-03-02from
haagha merged 1 commit intoAzure:feature/cplat-2022-03-02from
Conversation
anshulsolanki21
requested review from
MS-syh2qs,
Sandido,
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee and
madewithsmiles
as code owners
|
Hi, @anshulsolanki21 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The schema 'DiskRestorePoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L254 |
|
The schema 'DiskRestorePointList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L268 |
|
The schema 'DiskRestorePointProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L287 |
|
The schema 'ProxyOnlyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L383 |
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L42 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L93 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L141 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L205 |
|
| OperationId should contain the verb: 'begingetaccess' in:'DiskRestorePoint_GrantAccess'. Consider updating the operationId Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L141 |
|
| OperationId should contain the verb: 'endgetaccess' in:'DiskRestorePoint_RevokeAccess'. Consider updating the operationId Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L205 |
|
| The child tracked resource, 'diskRestorePoints' with immediate parent 'RestorePoint', must have a list by immediate parent operation. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L254 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: supportsHibernation Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L348 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get an incremental disk restorePoint resource. Location: stable/2022-03-02/DiskRP/diskRestorePoint.json#L126 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-02 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:DiskRestorePoint_RevokeAccess;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/feature/cplat-2022-03-02/specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/diskRestorePoint.json" |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
Swagger Generation Artifacts
|
This was referenced Apr 26, 2022
25 tasks
haagha
pushed a commit
to haagha/azure-rest-api-specs
that referenced
this pull request
May 17, 2022
haagha
pushed a commit
that referenced
this pull request
May 25, 2022
ArcturusZhang
pushed a commit
that referenced
this pull request
May 30, 2022
* new version folder * new version folder * sync with diskRP 2021-12-01 changes * Update creationData description (#18050) * Update diskRPCommon.json * Update diskRPCommon.json * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * New ApI Version * Readme changes * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * GET snapshot-Changed CopyCompletionError enum name (#19160) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * move UserAssignedIdentities to common.json to fix duplicate definition * update readme with gallery 2022-01-03 * sync with past updates * update with description for object * fix readme * GET snapshot-Changed CopyCompletionError enum name (#19227) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * fixing readme.md * fix vmss userAssignedIdentities duplicate definition Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: parkhyukjun89 <hyupar@microsoft.com> Co-authored-by: Akash Pargat <akashpargat@yahoo.com> Co-authored-by: akashpargat <akashpargat@microsoft.com> Co-authored-by: jerryc3 <48365571+jerryc3@users.noreply.github.com> Co-authored-by: Jerry Chan <jerch@microsoft.com> Co-authored-by: Karan Manish Thakkar <kkaran.thakkar@gmail.com> Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.