Skip to content

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2021-09-01#17666

Closed
Kencdk wants to merge 10 commits intoAzure:mainfrom
Kencdk:devtestlabs-Microsoft.DevTestLab-2021-09-01
Closed

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2021-09-01#17666
Kencdk wants to merge 10 commits intoAzure:mainfrom
Kencdk:devtestlabs-Microsoft.DevTestLab-2021-09-01

Conversation

@Kencdk
Copy link
Copy Markdown

@Kencdk Kencdk commented Feb 4, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot bot commented Feb 4, 2022

Hi, @Kencdk Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Feb 4, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail] The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/d5cbe02f779a8313875cc92e94078f588e35ae52/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json",
    "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow,
    indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest.
    ====================
    1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.64/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp
    --------------------
    2: ERROR: Schema violation: Data does not match any schemas from 'oneOf'
    --------------------
    3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json:8422:10 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.DevTestLab/labs/name"].put["x-ms-examples"].LabsCreateOrUpdate)
    --------------------
    4: FATAL: swagger-document/individual/schema-validator - FAILED
    --------------------
    5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
    --------------------
    6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
    --------------------"


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/d5cbe02f779a8313875cc92e94078f588e35ae52/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/preview/2015-05-21-preview/DTL.json",
    "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow,
    indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest.
    ====================
    1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.64/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp
    --------------------
    2: ERROR: Schema violation: Data does not match any schemas from 'oneOf'
    --------------------
    3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json:8422:10 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.DevTestLab/labs/name"].put["x-ms-examples"].LabsCreateOrUpdate)
    --------------------
    4: FATAL: swagger-document/individual/schema-validator - FAILED
    --------------------
    5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
    --------------------
    6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
    --------------------"
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌LintDiff: 24 Errors, 110 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.6) new version base version
    package-2021-09 package-2021-09(d5cbe02) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 30 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    ❌ ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3075
    ❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3075    		 RPC-Async-V1-11, RPC-Put-V1-11
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3123
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3133    		 RPC-Delete-V1-01
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3166    		 RPC-Async-V1-07
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3175
    ❌ PatchResponseCodes Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3185    		 RPC-Patch-V1-06
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3410
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3421    		 RPC-Delete-V1-01
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3454    		 RPC-Async-V1-07
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3463
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3552    		 RPC-Get-V1-08
    ❌ ResourceNameRestriction The resource name parameter 'sharedGalleryName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3769    		 RPC-Uri-V1-05
    ❌ ResourceNameRestriction The resource name parameter 'sharedGalleryName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3843    		 RPC-Uri-V1-05
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3850    		 RPC-Get-V1-08
    ❌ ConsistentPatchProperties The property 'tags' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4350    		 RPC-Patch-V1-03
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L8188
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L8199    		 RPC-Delete-V1-01
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L8234    		 RPC-Async-V1-07
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L8243
    ❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L8498    		 RPC-Patch-V1-11
    ❌ TrackedResourcePatchOperation Tracked resource 'GalleryImage' must have patch operation that at least supports the update of tags.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L10824    		 RPC-Patch-V1-03
    ❌ TrackedResourcesMustHavePut The tracked resource GalleryImage does not have a corresponding put operation.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L10824    		 RPC-Put-V1-22
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L13508
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1734
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1734
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1734
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2135
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2135
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2135


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DevTestLab/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L45
    ❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L46
    ❌ LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L132
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L165
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L165
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L470
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L603
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L724
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L948
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1138
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1239
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1250
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1282
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1291
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1438
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1539
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1855
    ❌ ResourceNameRestriction The resource name parameter 'policySetName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2252
    ❌ ResourceNameRestriction The resource name parameter 'policySetName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2326
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2333
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2640
    ❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2858
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2890
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2896
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4157
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4258
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4269
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4301
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4310
    ❌ ResourceNameRestriction The resource name parameter 'userName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4379
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 128 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ PATTERN String does not match pattern ^[a-zA-Z0-9_-]+$: {locationName}
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L14004:21
    ExampleUrl: stable/2021-09-01/examples/Operations_Get.json#L6:21
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9380:20
    ExampleUrl: stable/2021-09-01/examples/ArmTemplates_List.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9380:20
    ExampleUrl: stable/2021-09-01/examples/ArmTemplates_Get.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9502:17
    ExampleUrl: stable/2021-09-01/examples/Artifacts_List.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9502:17
    ExampleUrl: stable/2021-09-01/examples/Artifacts_Get.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_Get.json
    ❌ MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_Get.json#L11:15
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_CreateOrUpdate.json#L8:16
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_CreateOrUpdate.json
    ❌ MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_CreateOrUpdate.json#L67:15
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_CreateOrUpdate.json
    ❌ MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L11158:16
    ExampleUrl: stable/2021-09-01/examples/Costs_CreateOrUpdate.json#L133:15
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L1278:22
    ExampleUrl: stable/2021-09-01/examples/CustomImages_Delete.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L10824:21
    ExampleUrl: stable/2021-09-01/examples/GalleryImages_List.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L10824:21
    ExampleUrl: stable/2021-09-01/examples/GalleryImages_List.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L10824:21
    ExampleUrl: stable/2021-09-01/examples/GalleryImages_Get.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L12753:18
    ExampleUrl: stable/2021-09-01/examples/PolicySets_List.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L2886:22
    ExampleUrl: stable/2021-09-01/examples/Schedules_Execute.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3162:22
    ExampleUrl: stable/2021-09-01/examples/LabSecrets_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L3450:22
    ExampleUrl: stable/2021-09-01/examples/ServiceRunners_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4297:22
    ExampleUrl: stable/2021-09-01/examples/Users_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4609:22
    ExampleUrl: stable/2021-09-01/examples/Disks_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4735:22
    ExampleUrl: stable/2021-09-01/examples/Disks_Attach.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L4798:22
    ExampleUrl: stable/2021-09-01/examples/Disks_Detach.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L5050:22
    ExampleUrl: stable/2021-09-01/examples/Environments_Delete.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9324:27
    ExampleUrl: stable/2021-09-01/examples/ServiceFabrics_List.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9324:27
    ExampleUrl: stable/2021-09-01/examples/ServiceFabrics_Get.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9324:27
    ExampleUrl: stable/2021-09-01/examples/ServiceFabrics_CreateOrUpdate.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: location
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L9324:27
    ExampleUrl: stable/2021-09-01/examples/ServiceFabrics_CreateOrUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DevTestLab/stable/2021-09-01/DTL.json#L5676:22
    ExampleUrl: stable/2021-09-01/examples/ServiceFabrics_Delete.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Feb 4, 2022

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Feb 4, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-powershell succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Feb 4, 2022

    Hi @Kencdk, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Feb 4, 2022
    Draft
    Draft
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 4, 2022
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 22, 2022
    Draft
    This was referenced May 24, 2022
    Closed
    Draft
    Closed
    This was referenced May 24, 2022
    Closed
    Closed
    Closed
    Closed
    @Kencdk Kencdk mentioned this pull request May 24, 2022
    Closed
    25 tasks
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Jun 28, 2022

    Hi @Kencdk, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Sep 25, 2023

    Hi, @Kencdk. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    3 similar comments
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Sep 25, 2023

    Hi, @Kencdk. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Sep 25, 2023

    Hi, @Kencdk. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Sep 25, 2023

    Hi, @Kencdk. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @ms-zhenhua
    Copy link
    Copy Markdown
    Contributor

    ms-zhenhua commented Oct 9, 2023

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Oct 9, 2023

    Azure Pipelines successfully started running 3 pipeline(s).

    @ms-zhenhua
    Copy link
    Copy Markdown
    Contributor

    ms-zhenhua commented Oct 9, 2023 

          "200": {

    200 is not needed for LRO-DELETE:
    https://github.com/Azure/azure-openapi-validator/blob/main/docs/delete-response-codes.md

    Refers to: specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json:8467 in 68714be. [](commit_id = 68714be2680d2d993d24582080aba9cfbfc495d4, deletion_comment = False)

    @ms-zhenhua
    Copy link
    Copy Markdown
    Contributor

    ms-zhenhua commented Oct 9, 2023 

          },

    200 is not needed for LRO-DELETE:
    https://github.com/Azure/azure-openapi-validator/blob/main/docs/delete-response-codes.md

    Refers to: specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json:3090 in 68714be. [](commit_id = 68714be2680d2d993d24582080aba9cfbfc495d4, deletion_comment = False)

    @ms-zhenhua
    Copy link
    Copy Markdown
    Contributor

    ms-zhenhua commented Oct 9, 2023 

          "200": {

    200 is not needed for LRO-DELETE:
    https://github.com/Azure/azure-openapi-validator/blob/main/docs/delete-response-codes.md

    Refers to: specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2021-09-01/DTL.json:3405 in 68714be. [](commit_id = 68714be2680d2d993d24582080aba9cfbfc495d4, deletion_comment = False)

    ms-zhenhua
    ms-zhenhua reviewed Oct 9, 2023
    View reviewed changes
    Comment thread specification/devtestlabs/resource-manager/readme.md Outdated
    Copy link
    Copy Markdown
    Contributor

    @ms-zhenhua ms-zhenhua Oct 9, 2023 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    directive

    since it's been a long time and the original lint-diff error(https://github.com/Azure/azure-rest-api-specs/pull/17666/checks?sha=93f32e1fb5ea9dd065142f956f8543aa892de32f) does not exist, could you kindly remove all the added suppressions and submit a new commit to create a new lint-diff result and then add the suppressions back. After that we can review whether they can be suppressed. Thanks.

    This was referenced Dec 5, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Kencdk and others added 10 commits December 5, 2023 13:26
    @Kencdk
    Adds base for updating Microsoft.DevTestLab from version stable/2018-…
    5e80f00 
    …09-15 to version 2021-09-01
    @Kencdk
    Add scenarios
    befb011 
    Scenarios depend on an environment with the following properties:
repo_cloneuri, a link to a github or ado git repository
repo_type, the type of repository (GitHub or VsoGit)
repo_pat, personal access token to the repository
repo_folderPath, path to the artifacts folder in the repository
repo_branchref, name of the branch in the repository
    ...
    112635d
    Adressing a couple violations
    f0dda68
    ...
    9a1772a
    Convert casing in references to #/definitions/Resource
    7536c70
    ...
    b572cf2
    Change names in examples to not violate patterns described in each pr…
    2c6cbc7 
    …operty
    Add uppercase letters to patterns
    5a299d0
    ...
    d5cbe02
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Mar 4, 2024

    Hi, @Kencdk. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    1 similar comment
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Mar 4, 2024

    Hi, @Kencdk. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @konrad-jamrozik
    Copy link
    Copy Markdown

    konrad-jamrozik commented Mar 12, 2024

    @Kencdk I have removed the Approved-BreakingChange label because it is obsolete. Your PR will have to be re-approved. Please follow the instructions at https://aka.ms/brch. If you provide the reason why your PR was approved in the first place, this will speed up the process and help the Breaking Change Review Board apply appropriate new label. Apologies for the inconvenience!

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Apr 15, 2024

    Hi, @Kencdk. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service bot commented Apr 29, 2024

    Hi, @Kencdk. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @ms-zhenhua ms-zhenhua ms-zhenhua left review comments

    @pareshverma91 pareshverma91 Awaiting requested review from pareshverma91

    Assignees

    @rkmanda rkmanda

    Labels

    Approved-SdkBreakingChange-Python ARMReview AzCoreIDC CI-BreakingChange-Go CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-BreakingChange-Python CI-FixRequiredOnFailure new-api-version no-recent-activity There has been no recent activity on this issue. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.