Skip to content

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2021-09-01#15957

Closed
Kencdk wants to merge 31 commits intoAzure:mainfrom
Kencdk:dev-devtestlabs-Microsoft.DevTestLab-2021-09-01
Closed

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2021-09-01#15957
Kencdk wants to merge 31 commits intoAzure:mainfrom
Kencdk:dev-devtestlabs-Microsoft.DevTestLab-2021-09-01

Conversation

@Kencdk
Copy link
Copy Markdown

@Kencdk Kencdk commented Sep 8, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot bot commented Sep 8, 2021

Hi, @Kencdk Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Sep 8, 2021

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Sep 8, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️🔄~[Staging] ApiReadinessCheck inProgress [Detail]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ UNRESOLVABLE_REFERENCE Security scope definition could not be resolved: https://management.azure.com/.default
    JsonUrl: Microsoft.DevTestLab/stable/2021-09-01/DTL.json
    ️🔄Cross-Version Breaking Changes inProgress [Detail]
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Sep 8, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-python failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Sep 8, 2021
    Draft
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 8, 2021
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 8, 2021
    Draft
    This was referenced Sep 8, 2021
    Draft
    Draft
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Nov 5, 2021

    Hi @Kencdk, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Nov 5, 2021
    Draft
    @Kencdk Kencdk force-pushed the dev-devtestlabs-Microsoft.DevTestLab-2021-09-01 branch from ffd6798 to 573534e Compare November 12, 2021 21:53
    Kencdk and others added 16 commits December 16, 2021 14:07
    @Kencdk
    Adds suppression to readme
    2291f9c
    Remove suppressions that aren't being handled anyway
    997dd5c
    Refer to common types for systemdata
    1501886
    ...
    ee29fcb
    Rebuild DTL spec using new generator
    9eac38a
    Fix typo and add operationId to /operations call
    4f6161c
    Add 200 OK to deletes
    74e0c4e 
    Refer to the common types for /Operations endpoint
    Add GlobalSchedule operations and rename Labs_ImportVirtualMachine
    2c7e43a
    Add GET GalleryImage and fix enum names
    65f1e83
    More updates to examples
    8285443
    Fix generation of list responses and more example fixes
    179a487
    Model validation fixes
    4a1f282
    Prettier fixes
    a27e5e2
    More fixes and added words to custom-words
    1e1e2f2 
    Also, ran re-duplication on custom-words as well as sorted it.
    Fix casing issue with paths.
    3a8f5b7 
    Renamed 'Patch' objects to Fragments to not introduce breaking changes
Reordered properties to better align with previous specs.
    rename example for Labs_ImportVirtualmachine
    4088a9f
    @Kencdk Kencdk force-pushed the dev-devtestlabs-Microsoft.DevTestLab-2021-09-01 branch from d707e04 to e5c96e7 Compare December 16, 2021 13:07
    Ensure 'default' aren't always converted to a string.
    3fd9b17 
    Add StorageType as the correct enum (instead of a string)
    @Kencdk Kencdk force-pushed the dev-devtestlabs-Microsoft.DevTestLab-2021-09-01 branch from e5c96e7 to 3fd9b17 Compare January 13, 2022 15:54
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 13, 2022
    Draft
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot bot commented Jan 31, 2022

    Hi, @Kencdk your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 31, 2022
    @Kencdk
    Copy link
    Copy Markdown
    Author

    Kencdk commented May 24, 2022

    replaced by #17666

    @Kencdk Kencdk closed this May 24, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @Kencdk