-
Notifications
You must be signed in to change notification settings - Fork 5.7k
EventHub: updated for GEO DR #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
75dfbf9
Removed maxLength from entity name
9d0cde4
Geo DR changes
22bc6a7
review changes
d1f92d7
alias connection string added.
f50fc80
Merge branch 'current' of https://github.com/Azure/azure-rest-api-spe…
9caa0be
description updated
1c1ac61
Review comments and examples
3ac37b5
pluralize opertionsIds and reveted delete response code to 200
d42d401
Removed LastSync Property
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...r/Microsoft.EventHub/2017-04-01/examples/disasterRecoveryConfigs/EHAliasBreakPairing.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "namespaceName": "sdk-Namespace-8859", | ||
| "resourceGroupName": "ardsouzatestRG", | ||
| "alias": "sdk-DisasterRecovery-3814", | ||
| "api-version": "2017-04-01", | ||
| "subscriptionId": "5f750a97-50d9-4e36-8081-c9ee4c0210d4" | ||
| }, | ||
| "responses": { | ||
| "200": {} | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum. What about a Failed provisioning State value? You mention that possible values as accepted or succeeded. In case the operation fails, failed should be returned. And do you support cancel? In that case, you will have a canceled provisioning state as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved, we don't support cancel.