EventHub: updated for GEO DR by v-Ajnava · Pull Request #1709 · Azure/azure-rest-api-specs

Ajit Navasare (v-Ajnava) · 2017-09-20T23:59:08Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… into currentEHDR

Garrett Serack (fearthecowboy) · 2017-09-21T16:44:34Z

APIs added -- requiring ARM signoff (Gaurav Bhatnagar (@ravbhatnagar))

Garrett Serack (fearthecowboy)

As soon as ARM signs off, I'm good too.

Gaurav Bhatnagar (ravbhatnagar)

Ajit Navasare (@v-Ajnava) - same feedback as on the other PR.

Gaurav Bhatnagar (ravbhatnagar) · 2017-09-21T23:40:50Z

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.EventHub/namespaces/{namespaceName}/disasterRecoveryConfig": {


pluralize resource type name. disasterRecoveryConfigs

Gaurav Bhatnagar (ravbhatnagar) · 2017-09-21T23:41:21Z

+          }
+        ],
+        "responses": {
+          "201": {


202 response for async delete.

Reverted as delete is not async

Gaurav Bhatnagar (ravbhatnagar) · 2017-09-21T23:41:42Z

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.EventHub/namespaces/{namespaceName}/disasterRecoveryConfig/{alias}/breakpairing": {


camelcase, breakPairing

Gaurav Bhatnagar (ravbhatnagar) · 2017-09-21T23:43:31Z

+        "properties": {
+          "x-ms-client-flatten": true,
+          "properties": {
+            "provisioningState": {


enum. What about a Failed provisioning State value? You mention that possible values as accepted or succeeded. In case the operation fails, failed should be returned. And do you support cancel? In that case, you will have a canceled provisioning state as well.

Resolved, we don't support cancel.

Azure PR Bot (azuresdkciprbot) · 2017-09-23T01:30:45Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 5 Error(s): 0
After the PR: Warning(s): 7 Error(s): 0

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Samer Alameer (salameer) · 2017-09-25T19:32:44Z

Ajit Navasare (@v-Ajnava) any update s here?

Have all Gaurav's feedbacks been addressed here?

Ajit Navasare (v-Ajnava) · 2017-09-25T20:00:44Z

Samer Alameer (@salameer), Yes, Gaurav's feedback are addressed.

Azure PR Bot (azuresdkciprbot) · 2017-09-25T21:29:10Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 5 Error(s): 0
After the PR: Warning(s): 7 Error(s): 0

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Azure SDK Bot (AutorestCI) · 2017-09-26T15:46:49Z

Azure/azure-sdk-for-ruby#1000

Azure SDK Bot (AutorestCI) · 2017-09-26T15:46:52Z

No modification for AutorestCI/azure-sdk-for-node

Azure SDK Bot (AutorestCI) · 2017-09-26T15:46:52Z

Azure/azure-sdk-for-python#1479

Ajit Navasare (MINDTREE LIMITED) added 6 commits August 10, 2017 16:00

Removed maxLength from entity name

75dfbf9

Geo DR changes

9d0cde4

review changes

22bc6a7

alias connection string added.

d1f92d7

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

f50fc80

… into currentEHDR

description updated

9caa0be

Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 20, 2017

Azure Builder (azuresdkci) assigned Garrett Serack (fearthecowboy) Sep 21, 2017

Garrett Serack (fearthecowboy) added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2017

Garrett Serack (fearthecowboy) assigned Gaurav Bhatnagar (ravbhatnagar) Sep 21, 2017

Garrett Serack (fearthecowboy) approved these changes Sep 21, 2017

View reviewed changes

Gaurav Bhatnagar (ravbhatnagar) reviewed Sep 21, 2017

View reviewed changes

Ajit Navasare (MINDTREE LIMITED) added 2 commits September 21, 2017 18:58

Review comments and examples

1c1ac61

pluralize opertionsIds and reveted delete response code to 200

3ac37b5

Removed LastSync Property

d42d401

Microsoft GitHub User (msftgits) removed the cla-already-signed label Sep 26, 2017

Garrett Serack (fearthecowboy) merged commit acdca60 into Azure:current Sep 26, 2017

Azure SDK Bot (AutorestCI) mentioned this pull request Sep 26, 2017

Automatic PR from RestAPI-PR1709 Azure/azure-sdk-for-ruby#1000

Merged

Azure SDK Bot (AutorestCI) mentioned this pull request Sep 26, 2017

[EventHub] updated for GEO DR Azure/azure-sdk-for-python#1479

Merged

Ajit Navasare (v-Ajnava) mentioned this pull request Oct 3, 2017

EventHub: Geo DR Feature Azure/azure-sdk-for-net#3749

Merged

8 tasks

Uh oh!

Conversation

Ajit Navasare (v-Ajnava) commented Sep 20, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

Garrett Serack (fearthecowboy) commented Sep 21, 2017

Uh oh!

Garrett Serack (fearthecowboy) left a comment

Choose a reason for hiding this comment

Uh oh!

Gaurav Bhatnagar (ravbhatnagar) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Azure PR Bot (azuresdkciprbot) commented Sep 23, 2017

Uh oh!

Samer Alameer (salameer) commented Sep 25, 2017

Uh oh!

Ajit Navasare (v-Ajnava) commented Sep 25, 2017

Uh oh!

Azure PR Bot (azuresdkciprbot) commented Sep 25, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 26, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 26, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Ajit Navasare (v-Ajnava) commented Sep 20, 2017 •

edited by azuresdkci

Loading