Merge main into securityinsights 2021-10-01 dev branch#16119
Closed
anat-gilenson wants to merge 246 commits intodev-securityinsights-Microsoft.SecurityInsights-2021-10-01from
Closed
Merge main into securityinsights 2021-10-01 dev branch#16119anat-gilenson wants to merge 246 commits intodev-securityinsights-Microsoft.SecurityInsights-2021-10-01from
anat-gilenson wants to merge 246 commits intodev-securityinsights-Microsoft.SecurityInsights-2021-10-01from
Conversation
Co-authored-by: Miguel Concha Vazquez <miconcha@microsoft.com>
* Purview Terraform support * Move readme.md
* Adding the existing folders to a new version * Updating swagger file and readme * Addressed PR comments * Nit changes Co-authored-by: Ninika Sharma <ninsharm@microsoft.com>
…table/2020-06-01 (#15240) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Adding swaggers for Power BI private links * Fixed Lint erros. * Fixed spellcheck * Fixed Lint errors * fixed Avocado error * fixed model validation * fixed model validation. * updated private endpoint connections * updated PrivateLinkResources * updated PrivateLinkResource * updated private endpoint connection proxies * fixed model validation. * updated connectionstate * renamed connection files * update readme file. * updated python readme * fixed code review comments * updated error ref. * Removed Error and linked to common-type. * added 201 to put request * removed unnecessary definitions. * updates examples for 201 * updated list of * removed extra space * Added patch to PowerBIResource * added 202 to PrivateLinkServiceResourceOperationResults_Get * updated readme files * added provisioning state * trying to fix sdk error * removed privateEndpointConnectionProxies * added PrivateLinkResources_Get * added privateLinkResourceName in example * removed privateLinkServicesForPowerBI from URL * added nextLink * fixed prettier * Fixed error for Prettier
* Update Python SDK version * Remove preview api version for GO sdk * Add back GO package package-2020-12-01-preview
This change updates the operation ids for operations in the Purview Accounts service. These names are used when generating clients and so for some we've added suffxes (based on their groupings) to make generated method names a little clearler when you see just the method name in code e.g.: ``` var client = new PurviewAccountsClient(); ... client.GetAccountProperties() // Nicer than just client.Get(); ``` In addition, we noticed that the `Collections_GetCollectionPath` operation took a `$skipToken` parameter, even though the operation is not pageable. After following up with the service team we learned this was a mistake, so I have removed the parameter from the specification.
Co-authored-by: Tim Nguyen <you@example.com>
* Adds VNet peering to 2021-04-01-preview api-version. * Added OutboundNetworkDependencies. * Fixed Prettier issue * Fixed lint error * Edited sample output * Added reference to preview/vnetpeering.json in readme file * Edited description for outbound network dependency endpoints. * Corrected return type for outbound network dependency endpoints. * Corrected return type for outbound network dependency endpoints. * Correcting schema * Correcting schema Co-authored-by: nipuneth <nipuneth@microsoft.com> Co-authored-by: Sharanjeet Kaur <shkau@microsoft.com>
* add new resources * Add resources to markdown * Modify routes * Add systemData * Add systemData to defenderSettings * Add missing parameter * Add more systemData * Fix example * Add new API version * Remove redundant change * update markdown * Add operations to new API version * Update list filters * update description * update examples * Update examples * Add missing properties * Add missing properties * Rename property * Add alert editing * Update editable properties * Update example * update put to patch * Separate patch request to a different model * Share enum * update example * update patch model * Undo break change * small update * Old version as PR baseline * Move examples * Update scopes and examples * Add example values * alignWithMaster * Revert "Old version as PR baseline" This reverts commit d963f3a. * mdeIntegration * switchToObject * prettier Co-authored-by: Orel Kayam <orkayam@microsoft.com> Co-authored-by: Liran Chen <lirche@microsoft.com>
* Spec fixed to reflect new examples property * Prettier * suppressing incorrect warning
* 1st * 2nd * severity * prettier * fix date example * add date * readme * resolve pr comments * readme * remove id + title * remove publishedDate + lastModifiedDate * source -> sources * format * format * remove paging * update to 3 levels * fix validation Co-authored-by: Gal Bruchim <galbru@microsoft.com>
* Initial commit of previous api-version * Update swagger * Updated examples * Updated readme * Removed dataPolicyManifest.json as we will use the previous one. Also updated based on feedback. * Update to support patch for assignments and system data * Updated based on tool analysis * updated based on feedback
* Api version bump * Apply 2021-06-01 changes * Update readme * Change default on enum * Add s360 fixes * Add missing systemdata * Change defaultUserQuotaInKiBs default to 0 Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
…w/2.0 (#15388) * fix RangeObject properties inconsistency: double -> string * update remaining samples
The behavior of job schedules with respect to UTC time was causing some confusion. Co-authored-by: David Watrous <set>
… preview/2019-10-11-preview (#15642) * Add new API with examples, add a few new response for current API endpoints * change file name back * remove nullable parameter * change operation name of patch * add description to allowPublicNetworkResource * change example from string to boolean * Change publicnetworkaccess from boolean to string+ * change name * change example to string * change property name Co-authored-by: Geoffrey Troyer <geoffreymtroyer@gmail.com>
* Baseline changes for API version 2021-07-01 * Made the new changes related to API version 2021-07-01 * Fixing Lintdiff failure * resolved PR comments * Fixing validation failures * Fix the validation failures * Made lintdiff failures * Resolved PR comments * Fixing validation failures * Resolved PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com>
* fix default in volumeproperties * Update description * Update description Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Update custom-words.txt Co-authored-by: MIDDLEEAST\morbrisker <morbrisker@microsoft.com>
|
Hi @anat-gilenson, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Sep 22, 2021
* Create swagger.json Added swagger for vmwaresite, hypervsite, serversite * Update swagger.json Addition of Importsite resource * Referred swagger in readme.md * changed readme to have 2 api-versions * Updated readme * Updated ip address name * Create migrate.json * deleted preview changes * Fixed new version * fixed job definition, get and put site * Update migrate.json * Update migrate.json * Added examples. Removed server and import stacks * Removed extra code * Made it in accordance with private preview PR * Examples added * fixed comments * added tags * Resolved conflicts * fixed file * Fixed spellings * fixed spellings * added examples * fixed example * fixed examples * fixed examples * fixed discrption * fixed prettier check * fixed enums * prettier check * Update readme.md * Added operations list * Create migrate.json * added OperationDisplay definition * error fixed * Update migrate.json * fixed errors * Update Operations_List.json * Update migrate.json * Removed parameters * Ran Prettier check * Update migrate.json * Update migrate.json * prettier check * Update migrate.json * Update migrate.json removed extra controllers * Update migrate.json * Added examples * fixed examples * Update migrate.json * Update MasterSite_Create.json * fixed prettier check * fixed prettier check * Update MasterSite_Create.json * Update migrate.json * Update MasterSite_Patch.json * Update migrate.json * fixed examples * Update PrivateEndpointConnections_Create.json * Update PrivateLinkResources_Get.json * fixed example * Update migrate.json * Update migrate.json * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update migrate.json * Update readme.md * Fixed examples * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Fixed camel casing * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * added examples * fixed operations * Update migrate.json * Update readme.md * Update PrivateEndpointConnections_Delete.json * Update migrate.json * Update migrate.json * fixed prettier check * Update migrate.json * Update migrate.json * Added machine start, stop examples * Added examples * Added examples * Fixed prettier check * Update migrate.json * Update migrate.json
This was referenced Sep 22, 2021
* New Version 2021-08-01 * New Version 2021-08-01 * Adding new storage account input * Adding default value for automationAccount authentication type * Fixing indenation * removing new storage account changes Co-authored-by: Nilesh Gupta <nilgupta@microsoft.com>
* Create identification-swagger.yaml * Create verification-swagger.yaml * Update identification-swagger.yaml * Update verification-swagger.yaml * Update and rename identification-swagger.yaml to identification-swagger.json * Update and rename verification-swagger.yaml to verification-swagger.json * Added new files kept json for the move * Update based on review * typo * cspell * cspell * fix examples * pretty * Fix model semantic issues * pretty * Apply review comments * Update Identification.json * linter issues * Linter issues * api version required * Fix model issues * pretty checks * Update readme add go * fix required * update go readme * Clean autorest warnings * Fixes * fix regression * python * go * python trial2 * fix typescript * Remove typescipt not required * Attempt to fix last failing test Co-authored-by: Youssef Shahin <yshahin@gmail.com> Co-authored-by: Youssef Shahin <yshahin@users.noreply.github.com> Co-authored-by: Youssef Shahin <yshahin@microsoft.com>
* add 2021-07-01 swagger * update swagger * update folders * update to support Azure/azure-sdk-for-net#22576 * remove preview items+introduce apiversion * address comments * run prettier-check * fix CI * re-add changes from old preview swagger * address comments * add missing example Co-authored-by: Anne Loomis Thompson <annelo@microsoft.com>
* Add Channel Archive Heartbeat event * Removed added "required" field which caused validation errors. * Added examples for the new/updated events. Co-authored-by: Xueping Deng <xuepingd@microsoft.com>
) * Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Added support for GraphQL API type (#14851) * Added support for GraphQL API type * Added missing enum value for GraphQL APIs. * add schema definition fix from 2021-01-01-preview (#14883) Co-authored-by: Alan Feng <alanfeng@microsoft.com> * Vanguard: Get Outbound Network Dependency (#14900) * outbound dependency * fix resource * Update backup/restore API for managed identities (#14973) * Update backup/restore API for system-assigned and user-assigned identities * Fix formatting issue * Rename user-assigned-msi-client-id with client-id * SystemData implemenation on API Management Control Plane (#14899) * system-data * fix spec * remove unreferenced file * APIM - Network Watcher Connectivity Check integration specs (#15056) * Connectivity Check API Specs * Fix * Fix errors * style fixs * Fix 202 code * HTTPConnect request parameters * Fix errors Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Parameter examples added (#14836) * platformversion (#15114) * fix update service (#15478) * HttpConnect example (#15493) * HttpConnect example * Prettifier fix Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Added properties of difference API spec format for "SchemaDocumentProperties" (#15703) * add schema definition fix from 2021-01-01-preview * added properties for SchemaDocumentProperties * updated the fix * updated fix * [APIM]Add private endpoint connection APIs (#15115) * Add private endpoint connection apis * add readme * quick fixes * fix to PE contract * Small fixes * small fixes * small fixes * Small fixes * small fixes * small fix * small fixes * small fixes * small fixes * Update readme.md * fix error * small fix * fix format * address comments * small fixes * Change to lower case * small fixes Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Added support for GraphQL API type (#14851) * Added support for GraphQL API type * Added missing enum value for GraphQL APIs. * add schema definition fix from 2021-01-01-preview (#14883) Co-authored-by: Alan Feng <alanfeng@microsoft.com> * Vanguard: Get Outbound Network Dependency (#14900) * outbound dependency * fix resource * Update backup/restore API for managed identities (#14973) * Update backup/restore API for system-assigned and user-assigned identities * Fix formatting issue * Rename user-assigned-msi-client-id with client-id * SystemData implemenation on API Management Control Plane (#14899) * system-data * fix spec * remove unreferenced file * APIM - Network Watcher Connectivity Check integration specs (#15056) * Connectivity Check API Specs * Fix * Fix errors * style fixs * Fix 202 code * HTTPConnect request parameters * Fix errors Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Parameter examples added (#14836) * platformversion (#15114) * fix update service (#15478) * HttpConnect example (#15493) * HttpConnect example * Prettifier fix Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Added properties of difference API spec format for "SchemaDocumentProperties" (#15703) * add schema definition fix from 2021-01-01-preview * added properties for SchemaDocumentProperties * updated the fix * updated fix * [APIM]Add private endpoint connection APIs (#15115) * Add private endpoint connection apis * add readme * quick fixes * fix to PE contract * Small fixes * small fixes * small fixes * Small fixes * small fixes * small fix * small fixes * small fixes * small fixes * Update readme.md * fix error * small fix * fix format * address comments * small fixes * Change to lower case * small fixes Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * fix tenant sync contract * fix linter issues * examples for managed identity backup * prettier * Fix Apis-Get and updated comments for api-version 2021-04-01-preview (#3) * add schema definition fix from 2021-01-01-preview * added fix * small fix (#6) * 'examples' added to RepresentationContract (#7) Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com> Co-authored-by: DreamlessA <DreamlessA@users.noreply.github.com> Co-authored-by: Alan Feng <alanfeng@microsoft.com> Co-authored-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com> Co-authored-by: Nicolás Barrera <nicolasbarrera@outlook.com> Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com> Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: RupengLiu <rupliu@microsoft.com> Co-authored-by: VitaliyKurokhtin <Vitaliy.Kurokhtin@gmail.com>
…on stable/2021-05-01 (#16123) * etag -> eTag * Fix description Co-authored-by: Alex Goldschmidt <algoldsc@microsoft.com>
…stable/2021-05-01 (#16037) * Adds base for updating Microsoft.Insights from version stable/2019-07-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * Copy 2018-01-01 metric definitions API and examples * Changes to add subscription scope metrics API * Fix post request example after fixing casing of parameter names * Addressed PR comments and moved common types to a common json file * Fix commonMonitoringTypes API version and formatting
* correct sku request body schema * Correct Sku resource type request body schema Co-authored-by: Wendy Chang <wendychang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.