Skip to content

Conversation

@pajind
Copy link
Contributor

@pajind pajind commented Jun 11, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested labels Sep 10, 2021
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@pajind
Copy link
Contributor Author

pajind commented Sep 11, 2021

@jianyexi Can you please check and merge the PR. I got ARM sign off

@pajind
Copy link
Contributor Author

pajind commented Sep 13, 2021

@jianyexi Can you please check and merge. Its a blocker for our JEDI deadlines

@jianyexi
Copy link
Contributor

@pajind could you fix the lint errors https://github.com/Azure/azure-rest-api-specs/pull/14776/checks?check_run_id=3542878612 ?
Why the model or property name start with capital character

@pajind
Copy link
Contributor Author

pajind commented Sep 14, 2021

@pajind could you fix the lint errors https://github.com/Azure/azure-rest-api-specs/pull/14776/checks?check_run_id=3542878612 ?
Why the model or property name start with capital character

@jianyexi These Lintdiff errors are for existing apis and were not there in earlier reviews. The service is years old. I can take all these errors/breaking changes including camelcase in next api version while increasing api version. This api version is already public

@jianyexi
Copy link
Contributor

@pajind

        Pallavi Jindal
        FTE could you fix the lint errors https://github.com/Azure/azure-rest-api-specs/pull/14776/checks?check_run_id=3542878612 ?

Why the model or property name start with capital character

@jianyexi Jianye Xi FTE These Lintdiff errors are for existing apis and were not there in earlier reviews. The service is years old. I can take all these errors/breaking changes including camelcase in next api version while increasing api version. This api version is already public

Okay, I approved it ,as it's not newly introduced errors.

@jianyexi
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

"schema": {
"$ref": "#/definitions/MasterSite"
"202": {
"description": "Accepted",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong to me. Now, there's no way to tell what the shape of the eventual response is going to be. I believe all other resources declare their final response, even if in practice it's a long running operation, similarly to what the previous version did.

Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
* Create swagger.json

Added swagger for vmwaresite, hypervsite, serversite

* Update swagger.json

Addition of Importsite resource

* Referred swagger in readme.md

* changed readme to have 2 api-versions

* Updated readme

* Updated ip address name

* Create migrate.json

* deleted preview changes

* Fixed new version

* fixed job definition, get and put site

* Update migrate.json

* Update migrate.json

* Added examples. Removed server and import stacks

* Removed extra code

* Made it in accordance with private preview PR

* Examples added

* fixed comments

* added tags

* Resolved conflicts

* fixed file

* Fixed spellings

* fixed spellings

* added examples

* fixed example

* fixed examples

* fixed examples

* fixed discrption

* fixed prettier check

* fixed enums

* prettier check

* Update readme.md

* Added operations list

* Create migrate.json

* added OperationDisplay definition

* error fixed

* Update migrate.json

* fixed errors

* Update Operations_List.json

* Update migrate.json

* Removed parameters

* Ran Prettier check

* Update migrate.json

* Update migrate.json

* prettier check

* Update migrate.json

* Update migrate.json

removed extra controllers

* Update migrate.json

* Added examples

* fixed examples

* Update migrate.json

* Update MasterSite_Create.json

* fixed prettier check

* fixed prettier check

* Update MasterSite_Create.json

* Update migrate.json

* Update MasterSite_Patch.json

* Update migrate.json

* fixed examples

* Update PrivateEndpointConnections_Create.json

* Update PrivateLinkResources_Get.json

* fixed example

* Update migrate.json

* Update migrate.json

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update migrate.json

* Update readme.md

* Fixed examples

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Fixed camel casing

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* added examples

* fixed operations

* Update migrate.json

* Update readme.md

* Update PrivateEndpointConnections_Delete.json

* Update migrate.json

* Update migrate.json

* fixed prettier check

* Update migrate.json

* Update migrate.json

* Added machine start, stop examples

* Added examples

* Added examples

* Fixed prettier check

* Update migrate.json

* Update migrate.json
@msyyc
Copy link
Member

msyyc commented Jan 5, 2022

/azp run

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
* Create swagger.json

Added swagger for vmwaresite, hypervsite, serversite

* Update swagger.json

Addition of Importsite resource

* Referred swagger in readme.md

* changed readme to have 2 api-versions

* Updated readme

* Updated ip address name

* Create migrate.json

* deleted preview changes

* Fixed new version

* fixed job definition, get and put site

* Update migrate.json

* Update migrate.json

* Added examples. Removed server and import stacks

* Removed extra code

* Made it in accordance with private preview PR

* Examples added

* fixed comments

* added tags

* Resolved conflicts

* fixed file

* Fixed spellings

* fixed spellings

* added examples

* fixed example

* fixed examples

* fixed examples

* fixed discrption

* fixed prettier check

* fixed enums

* prettier check

* Update readme.md

* Added operations list

* Create migrate.json

* added OperationDisplay definition

* error fixed

* Update migrate.json

* fixed errors

* Update Operations_List.json

* Update migrate.json

* Removed parameters

* Ran Prettier check

* Update migrate.json

* Update migrate.json

* prettier check

* Update migrate.json

* Update migrate.json

removed extra controllers

* Update migrate.json

* Added examples

* fixed examples

* Update migrate.json

* Update MasterSite_Create.json

* fixed prettier check

* fixed prettier check

* Update MasterSite_Create.json

* Update migrate.json

* Update MasterSite_Patch.json

* Update migrate.json

* fixed examples

* Update PrivateEndpointConnections_Create.json

* Update PrivateLinkResources_Get.json

* fixed example

* Update migrate.json

* Update migrate.json

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update migrate.json

* Update readme.md

* Fixed examples

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Fixed camel casing

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* Update migrate.json

* added examples

* fixed operations

* Update migrate.json

* Update readme.md

* Update PrivateEndpointConnections_Delete.json

* Update migrate.json

* Update migrate.json

* fixed prettier check

* Update migrate.json

* Update migrate.json

* Added machine start, stop examples

* Added examples

* Added examples

* Fixed prettier check

* Update migrate.json

* Update migrate.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants