-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Private endpoints and JEDI controllers #14776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added swagger for vmwaresite, hypervsite, serversite
Addition of Importsite resource
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
|
@jianyexi Can you please check and merge the PR. I got ARM sign off |
|
@jianyexi Can you please check and merge. Its a blocker for our JEDI deadlines |
|
@pajind could you fix the lint errors https://github.com/Azure/azure-rest-api-specs/pull/14776/checks?check_run_id=3542878612 ? |
@jianyexi These Lintdiff errors are for existing apis and were not there in earlier reviews. The service is years old. I can take all these errors/breaking changes including camelcase in next api version while increasing api version. This api version is already public |
Okay, I approved it ,as it's not newly introduced errors. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "schema": { | ||
| "$ref": "#/definitions/MasterSite" | ||
| "202": { | ||
| "description": "Accepted", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong to me. Now, there's no way to tell what the shape of the eventual response is going to be. I believe all other resources declare their final response, even if in practice it's a long running operation, similarly to what the previous version did.
* Create swagger.json Added swagger for vmwaresite, hypervsite, serversite * Update swagger.json Addition of Importsite resource * Referred swagger in readme.md * changed readme to have 2 api-versions * Updated readme * Updated ip address name * Create migrate.json * deleted preview changes * Fixed new version * fixed job definition, get and put site * Update migrate.json * Update migrate.json * Added examples. Removed server and import stacks * Removed extra code * Made it in accordance with private preview PR * Examples added * fixed comments * added tags * Resolved conflicts * fixed file * Fixed spellings * fixed spellings * added examples * fixed example * fixed examples * fixed examples * fixed discrption * fixed prettier check * fixed enums * prettier check * Update readme.md * Added operations list * Create migrate.json * added OperationDisplay definition * error fixed * Update migrate.json * fixed errors * Update Operations_List.json * Update migrate.json * Removed parameters * Ran Prettier check * Update migrate.json * Update migrate.json * prettier check * Update migrate.json * Update migrate.json removed extra controllers * Update migrate.json * Added examples * fixed examples * Update migrate.json * Update MasterSite_Create.json * fixed prettier check * fixed prettier check * Update MasterSite_Create.json * Update migrate.json * Update MasterSite_Patch.json * Update migrate.json * fixed examples * Update PrivateEndpointConnections_Create.json * Update PrivateLinkResources_Get.json * fixed example * Update migrate.json * Update migrate.json * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update migrate.json * Update readme.md * Fixed examples * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Fixed camel casing * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * added examples * fixed operations * Update migrate.json * Update readme.md * Update PrivateEndpointConnections_Delete.json * Update migrate.json * Update migrate.json * fixed prettier check * Update migrate.json * Update migrate.json * Added machine start, stop examples * Added examples * Added examples * Fixed prettier check * Update migrate.json * Update migrate.json
|
/azp run |
* Create swagger.json Added swagger for vmwaresite, hypervsite, serversite * Update swagger.json Addition of Importsite resource * Referred swagger in readme.md * changed readme to have 2 api-versions * Updated readme * Updated ip address name * Create migrate.json * deleted preview changes * Fixed new version * fixed job definition, get and put site * Update migrate.json * Update migrate.json * Added examples. Removed server and import stacks * Removed extra code * Made it in accordance with private preview PR * Examples added * fixed comments * added tags * Resolved conflicts * fixed file * Fixed spellings * fixed spellings * added examples * fixed example * fixed examples * fixed examples * fixed discrption * fixed prettier check * fixed enums * prettier check * Update readme.md * Added operations list * Create migrate.json * added OperationDisplay definition * error fixed * Update migrate.json * fixed errors * Update Operations_List.json * Update migrate.json * Removed parameters * Ran Prettier check * Update migrate.json * Update migrate.json * prettier check * Update migrate.json * Update migrate.json removed extra controllers * Update migrate.json * Added examples * fixed examples * Update migrate.json * Update MasterSite_Create.json * fixed prettier check * fixed prettier check * Update MasterSite_Create.json * Update migrate.json * Update MasterSite_Patch.json * Update migrate.json * fixed examples * Update PrivateEndpointConnections_Create.json * Update PrivateLinkResources_Get.json * fixed example * Update migrate.json * Update migrate.json * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update migrate.json * Update readme.md * Fixed examples * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Fixed camel casing * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * Update migrate.json * added examples * fixed operations * Update migrate.json * Update readme.md * Update PrivateEndpointConnections_Delete.json * Update migrate.json * Update migrate.json * fixed prettier check * Update migrate.json * Update migrate.json * Added machine start, stop examples * Added examples * Added examples * Fixed prettier check * Update migrate.json * Update migrate.json
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.