New API Version 2017-08-01: Adding Sku property into publicIP and load balancer by gmainar · Pull Request #1528 · Azure/azure-rest-api-specs

gmainar · 2017-08-10T01:33:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ce APIs. Corrections to existing examples. (Azure#1498)

…1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names

* Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync

* Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure.

msftclas · 2017-08-10T01:33:05Z

@gmainar,
Thanks for your contribution. It looks like you are a Microsoft vendor. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

The agreement will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

… file (Azure#1529)

salameer · 2017-08-10T17:59:17Z

Thank Gloria,

@anuchandy fire Awwwwaaaayyy

anuchandy · 2017-08-10T18:45:36Z

@ravbhatnagar this is the new API version "2017-08-01". Please refer the commit Changes for new API version in this PR to see the diff between this new version and previous version.

salameer · 2017-08-10T21:09:41Z

@anuchandy can you please provide your feedback from the SDKs as @ravbhatnagar is reviewing to speed us the process here :)

Agreed on the changes

anuchandy · 2017-08-10T21:52:40Z

specification/network/resource-manager/Microsoft.Network/2017-08-01/loadBalancer.json

+        "sku": {
+          "$ref": "#/definitions/LoadBalancerSku",
+          "description": "The load balancer SKU."
+        },


Is sku a required property?

thanks for confirming

anuchandy · 2017-08-10T21:52:58Z

specification/network/resource-manager/Microsoft.Network/2017-08-01/publicIpAddress.json

      "properties": {
+        "sku": {
+          "$ref": "#/definitions/PublicIPAddressSku",
+          "description": "The public IP address SKU."


Is sku a required property?

* Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d.

anuchandy · 2017-08-11T00:38:09Z

The "2017-08-01" api version enables configuring SNAT for back pool VMs and adds SKU for public IP, load balancer. These changes looks good from the SDK side.

…Face API. (Azure#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore.

ravbhatnagar · 2017-08-12T00:29:56Z

@anuchandy - Looks good. ARM has signed off.

anuchandy · 2017-08-14T15:19:53Z

@salameer as discussed, taking this PR to unblock PowerShell and SDKs generations for ignite.. There is a build failure which is related to cognitiveservices.

AutorestCI · 2017-08-14T15:24:16Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-14T15:27:11Z

Azure/azure-sdk-for-python#1362

…d balancer (#1528) (#1543) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)

AutorestCI · 2017-08-15T00:13:23Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-15T00:16:35Z

Azure/azure-sdk-for-ruby#895

niblak and others added 6 commits August 8, 2017 16:24

Updating documentation for Microsoft.VisualStudio with project resour…

45f3b8b

…ce APIs. Corrections to existing examples. (Azure#1498)

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (Azure#…

52649c0

…1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names

Microsoft.Sql - Added data sync to package-2015-05-preview (Azure#1510)

342a4d4

* Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync

no YAML in glob patterns for report scripts

d44f0d6

Copying 2017-06-01 to 2017-08-01

382aea1

msftclas added the cla-not-required label Aug 10, 2017

Changes for new API version

fc6108b

azuresdkci assigned sarangan12 Aug 10, 2017

anuchandy self-assigned this Aug 10, 2017

Updated script to run autorest with grouping swaggers based on config…

4c49e89

… file (Azure#1529)

salameer unassigned sarangan12 Aug 10, 2017

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 10, 2017

Removed the maxLength for entities (Azure#1527)

b4618ee

salameer assigned ravbhatnagar Aug 10, 2017

Update folder structure example. (Azure#1489)

b92e702

Agreed on the changes

anuchandy reviewed Aug 10, 2017

View reviewed changes

Ajit Navasare and others added 4 commits August 11, 2017 09:44

Removed maxLength from entity name (Azure#1531)

37a1784

Relay: Removed the maxLength for entity names (Azure#1535)

e5ad3c6

Merge remote-tracking branch 'upstream/current' into 2017-08-01API

0a55eff

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2017

anuchandy approved these changes Aug 13, 2017

View reviewed changes

anuchandy merged commit 6d76e5f into Azure:Networking-V2017-08-01 Aug 14, 2017

AutorestCI mentioned this pull request Aug 14, 2017

Automatic PR from RestAPI-PR1528 Azure/azure-sdk-for-python#1362

Closed

gmainar mentioned this pull request Aug 14, 2017

New API Version 2017-08-01: Adding Sku property into publicIP and loa… #1543

Merged

10 tasks

AutorestCI mentioned this pull request Aug 15, 2017

Automatic PR from RestAPI-PR1528 Azure/azure-sdk-for-ruby#895

Closed

Conversation

gmainar commented Aug 10, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

msftclas commented Aug 10, 2017

Uh oh!

salameer commented Aug 10, 2017

Uh oh!

anuchandy commented Aug 10, 2017

Uh oh!

salameer commented Aug 10, 2017

Uh oh!

anuchandy Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

gmainar Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

anuchandy Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

anuchandy Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

gmainar Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

anuchandy commented Aug 11, 2017

Uh oh!

ravbhatnagar commented Aug 12, 2017

Uh oh!

anuchandy commented Aug 14, 2017

Uh oh!

AutorestCI commented Aug 14, 2017

Uh oh!

AutorestCI commented Aug 14, 2017

Uh oh!

AutorestCI commented Aug 15, 2017

Uh oh!

AutorestCI commented Aug 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

gmainar commented Aug 10, 2017 •

edited by azuresdkci

Loading