Make MsDeploy and MsDeployLog Azure resources by naveedaz · Pull Request #1519 · Azure/azure-rest-api-specs

naveedaz · 2017-08-07T20:49:24Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…operties

…tatus object

jianghaolu · 2017-08-08T00:33:33Z

specification/web/resource-manager/Microsoft.Web/2016-08-01/WebApps.json

-          "description": "URI of MSDeploy Parameters file. Must not be set if SetParameters is used.",
-          "type": "string"
-        },
-        "setParameters": {


Seems like server is expecting a JSON dictionary here - sending an array gets me a 500. This sample also shows that this should be a dictionary: https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/app-service-web/app-service-web-arm-with-msdeploy-provision.md.

@EricSten-MSFT Can you let us know why you chose array over dictionary? Since this is critical to the fluent SDK team and the ARM deploy above says it should be a dictionary, I will change it right now. @EricSten-MSFT Let me know if there is any reason why we should not.

setParameters should be a dictionary. It's specified as a IDictionary in the underlying code, and in the stuff that generated the Swagger.

…arameters

azuresdkciprbot · 2017-08-08T02:38:07Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 1806 Error(s): 184
After the PR: Warning(s): 1639 Error(s): 99

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

jianghaolu · 2017-08-08T18:06:03Z

specification/web/resource-manager/Microsoft.Web/2016-03-01/Provider.json

+        "tags": [
+          "Provider"
+        ],
+        "operationId": "Provider_ListOperations",


This has the same name as https://github.com/Azure/azure-rest-api-specs/pull/1519/files#diff-3adaa26580e5e10147ca02b203c71b4fR46

Not sure why the validations did not pick it up. Fixed it.

azuresdkciprbot · 2017-08-08T18:33:01Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 1806 Error(s): 184
After the PR: Warning(s): 1637 Error(s): 98

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

sarangan12 · 2017-08-09T22:54:54Z

@jianghaolu please confirm if you are ok with these changes

AutorestCI · 2017-08-09T23:49:36Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-09T23:50:11Z

Azure/azure-sdk-for-python#1357

AutorestCI · 2017-08-09T23:50:14Z

Azure/azure-sdk-for-ruby#887

…d balancer (#1528) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)

…d balancer (#1528) (#1543) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)

Navy Aziz added 11 commits July 25, 2017 17:02

Add public certificates, Functions Admin Token and MSDeploy APIs

dc0352d

Revert resource definition changes and description change for site pr…

549a9de

…operties

Merge remote-tracking branch 'upstream/current' into current

39ceb0d

Make type and name readonly properties. Add ARM envelope to MSDeployS…

ba5ad4f

…tatus object

Merge remote-tracking branch 'upstream/current' into current

f9084ca

Fix missing quotation issue.

a82a87c

Merge remote-tracking branch 'upstream/current' into current

7ed3428

Add long running operation to MS deploy

e0fd751

Merge remote-tracking branch 'upstream/current' into current

7fa0073

Make MsDeploy and MsDeployLog Azure resources

4dab1f8

Merge remote-tracking branch 'upstream/current' into current

2101e70

msftclas added the cla-not-required label Aug 7, 2017

azuresdkci assigned sarangan12 Aug 7, 2017

jianghaolu reviewed Aug 8, 2017

View reviewed changes

Navy Aziz added 4 commits August 7, 2017 18:50

Fix some AutoRest validation issues. Use dictionary for msdeploy.setp…

d4abb2f

…arameters

Ensure models are same across all schemas in Microsoft.Web

b47c0d5

Fix azure resource type across all models

26c40f9

Merge remote-tracking branch 'upstream/current' into current

d068b39

jianghaolu suggested changes Aug 8, 2017

View reviewed changes

Navy Aziz added 2 commits August 8, 2017 11:20

Remove conflicting ListOperations. It is not used for public Azure.

49b1967

Merge remote-tracking branch 'upstream/current' into current

39cbd9e

jianghaolu approved these changes Aug 9, 2017

View reviewed changes

jianghaolu merged commit 659995d into Azure:current Aug 9, 2017

AutorestCI mentioned this pull request Aug 9, 2017

[WebApp] Make MsDeploy and MsDeployLog Azure resources Azure/azure-sdk-for-python#1357

Closed

AutorestCI mentioned this pull request Aug 9, 2017

Automatic PR from RestAPI-PR1519 Azure/azure-sdk-for-ruby#887

Closed

gmainar mentioned this pull request Aug 14, 2017

New API Version 2017-08-01: Adding Sku property into publicIP and loa… #1543

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make MsDeploy and MsDeployLog Azure resources#1519

Make MsDeploy and MsDeployLog Azure resources#1519
jianghaolu merged 17 commits intoAzure:currentfrom
naveedaz:current

naveedaz commented Aug 7, 2017 •

edited by azuresdkci

Loading

Uh oh!

jianghaolu Aug 8, 2017

Uh oh!

naveedaz Aug 8, 2017

Uh oh!

EricSten-MSFT Aug 8, 2017

Uh oh!

azuresdkciprbot commented Aug 8, 2017

Uh oh!

jianghaolu Aug 8, 2017

Uh oh!

naveedaz Aug 8, 2017

Uh oh!

azuresdkciprbot commented Aug 8, 2017

Uh oh!

sarangan12 commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

naveedaz commented Aug 7, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

jianghaolu Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

naveedaz Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

EricSten-MSFT Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Aug 8, 2017

Uh oh!

jianghaolu Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

naveedaz Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Aug 8, 2017

Uh oh!

sarangan12 commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

AutorestCI commented Aug 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

naveedaz commented Aug 7, 2017 •

edited by azuresdkci

Loading