Addpersonalizerv1point1swagger by orenmichaely · Pull Request #14533 · Azure/azure-rest-api-specs

orenmichaely · 2021-05-24T21:37:30Z

This is a follow up on

#14289

All I am adding is

to personalizer.json

due to CI failures the docs team is having with our new swagger.

openapi-workflow-bot · 2021-05-24T21:37:32Z

Hi, @orenmichaely Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-05-24T21:37:32Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-workflow-bot · 2021-05-24T21:37:32Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-24T21:37:33Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-pipeline-app · 2021-05-24T21:53:32Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- current:preview/v1.1-preview.1/Personalizer.json compared with base:preview/v1.1-preview.1/Personalizer.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- data-plane/Personalizer/readme.md tag:release_1_1_preview.1
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- data-plane/Personalizer/readme.md tag:release_1_1_preview.1

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ServiceConfigurationModel'. Consider using the plural form of 'ServiceConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Personalizer/preview/v1.1-preview.1/Personalizer.json#L21
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ServiceConfigurationModel'. Consider using the plural form of 'ServiceConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Personalizer/preview/v1.1-preview.1/Personalizer.json#L65
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EvaluationModel'. Consider using the plural form of 'Evaluation' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Personalizer/preview/v1.1-preview.1/Personalizer.json#L184
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Personalizer/preview/v1.1-preview.1/Personalizer.json#L192

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

cognitiveservices/data-plane/Personalizer/readme.md#release_1_1_preview.1

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Personalizer/readme.md",
"tag":"release_1_1_preview.1",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Personalizer/readme.md",
"tag":"release_1_1_preview.1",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Personalizer/readme.md",
"tag":"release_1_1_preview.1",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-05-24T21:53:32Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 161fef4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-cognitiveservices-personalizer [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ModelOperations
info	[Changelog]   - Added operation group PersonalizerClientOperationsMixin
info	[Changelog]   - Added operation group PolicyOperations
info	[Changelog]   - Added operation group EvaluationsOperations
info	[Changelog]   - Added operation group ServiceConfigurationOperations
info	[Changelog]   - Added operation group LogOperations

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 161fef4. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️personalizer/v1.0/personalizer [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 161fef4. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cognitiveservices/data-plane/Personalizer/readme.md

️✔️@azure/cognitiveservices-personalizer [View full logs] [Release SDK Changes]

azure-cognitiveservices-personalizer-2.0.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/personalizerClient.js → ./dist/cognitiveservices-personalizer.js...
cmderr	[npmPack] created ./dist/cognitiveservices-personalizer.js in 296ms

_{Posted by Swagger Pipeline | How to fix these errors?}

jhendrixMSFT · 2021-05-24T21:57:53Z

/azp run

azure-pipelines · 2021-05-24T21:58:04Z

Azure Pipelines successfully started running 1 pipeline(s).

ormichae and others added 11 commits May 6, 2021 12:28

added swagger and examples for personalizer v1.1 preview

c79fc86

moved folder

639a828

added new version to readme

c026766

prettier changes

8b38218

fixed breaking changes

512b530

removed custom words

ebe6fc2

changed endpoint name

998da83

prettier

571a33c

custom word

6ac65ba

custom words

e1f6ff3

added apim-key to security

46a5ce7

orenmichaely requested a review from yangyuan as a code owner May 24, 2021 21:37

openapi-assignment-bot bot assigned jhendrixMSFT May 24, 2021

Merge branch 'master' into addpersonalizerv1point1swagger

8d0637b

openapi-sdkautomation bot mentioned this pull request May 24, 2021

[AutoPR @azure/cognitiveservices-personalizer] Addpersonalizerv1point1swagger AzureSDKAutomation/azure-sdk-for-js#4850

Closed

jhendrixMSFT approved these changes May 24, 2021

View reviewed changes

openapi-sdkautomation bot mentioned this pull request May 24, 2021

[AutoPR azure-cognitiveservices-personalizer] Addpersonalizerv1point1swagger AzureSDKAutomation/azure-sdk-for-python#5716

Closed

jhendrixMSFT merged commit 161fef4 into Azure:master May 24, 2021

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addpersonalizerv1point1swagger#14533

Addpersonalizerv1point1swagger#14533
jhendrixMSFT merged 12 commits intoAzure:masterfrom
ormichae:addpersonalizerv1point1swagger

orenmichaely commented May 24, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021

Uh oh!

openapi-workflow-bot bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 24, 2021 •

edited

Loading

Breaking Changes Tracking

Uh oh!

jhendrixMSFT commented May 24, 2021

Uh oh!

azure-pipelines bot commented May 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

orenmichaely commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021

Uh oh!

openapi-workflow-bot bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021

Uh oh!

openapi-pipeline-app bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

jhendrixMSFT commented May 24, 2021

Uh oh!

azure-pipelines bot commented May 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

orenmichaely commented May 24, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 24, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 24, 2021 •

edited

Loading