Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 2021-05-01-preview version #14855

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Initial 2021-05-01-preview version #14855

merged 2 commits into from
Jun 18, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Jun 16, 2021

Initial version of unified Cognitive Services : Language pillar.

Co-authored-by: Chong Tang [email protected]
Co-authored-by: Rohan Kulkarni [email protected]
Co-authored-by: Somi Reddy Satti [email protected]

Initial version of unified Cognitive Services : Language pillar.

Co-authored-by: Chong Tang <[email protected]>
Co-authored-by: Rohan Kulkarni <[email protected]>
Co-authored-by: Somi Reddy Satti <[email protected]>
@heaths heaths requested a review from yangyuan as a code owner June 16, 2021 20:52
@openapi-workflow-bot
Copy link

Hi, @heaths Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 16, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ PreCheck/DuplicateSchema "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"Duplicate Schema named Sentiment -- properties.label.description: undefined => "The label of the sentiment analysis result.",
    properties.score.$ref: undefined => "#/components/schemas/schemas:237",
    properties.score.description: undefined => "The sentiment score of the query.",
    required: undefined => ["score"] "
    ⚠️ Modeler/MissingType "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"The schema 'ExternalEntity-resolution' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/LUIS/Runtime/stable/v3.0/LUIS-Runtime.json#/components/schemas/ExternalEntity-resolution"
    ⚠️ Modeler/MissingType "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"The schema 'components·dl180i·schemas·prediction·properties·entities·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/LUIS/Runtime/stable/v3.0/LUIS-Runtime.json#/components/schemas/components·dl180i·schemas·prediction·properties·entities·additionalproperties"
    ⚠️ PreNamer/DeduplicateName "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"Deduplicating schema name: 'Sentiment' -> 'SentimentAutoGenerated'"
    💬 AutorestCore/Exception "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.15.456)"
    💬 AutorestCore/Exception "readme":"cognitiveservices/data-plane/Language/readme.md",
    "tag":"release_2021_05_01_preview",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 16, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-net warning [Detail]
    • ⚠️Warning [Logs] Generate from 1d31bd8539ccb5bd6ccf3eaeff72f8a2532df457. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cognitiveservices/data-plane/Language/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 1d31bd8539ccb5bd6ccf3eaeff72f8a2532df457. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    @heaths heaths changed the title cognitiveservices language Initial 2021-05-01-preview version Jun 16, 2021
    @heaths heaths changed the base branch from master to feature/cognitiveservices/language June 16, 2021 20:57
    @heaths
    Copy link
    Member Author

    heaths commented Jun 16, 2021

    /cc @rokulka @ChongTang @somigithub @annatisch

    This is a copy (with co-authors) from the private repo and no history (wasn't squashed, so many commits). @tjprescott did the final PR merge over in that repo. This is the initial seed into the feature branch.

    @heaths
    Copy link
    Member Author

    heaths commented Jun 16, 2021

    @jhendrixMSFT when you eventually merge this, can you make sure the squash commit description includes the correct raw text (not rendered markdown) like so:

    Co-authored-by: User Name <[email protected]>
    

    I want to make sure the original authors share the credit (and blame ;).

    @heaths
    Copy link
    Member Author

    heaths commented Jun 16, 2021

    For reviewers, I used robocopy to copy over everything in specifications/cognitiveservices/data-plane/Language and applied the same changes to the root custom-words.txt.

    @lmazuel lmazuel merged commit 186cef3 into Azure:feature/cognitiveservices/language Jun 18, 2021
    @heaths heaths deleted the cognitiveservices-language branch June 18, 2021 17:38
    @heaths heaths mentioned this pull request Nov 9, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants