[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 #14170

dpwatrous · 2021-04-28T16:31:36Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2021-04-28T16:32:14Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2020-09-01.12.0/BatchService.json <---> new: stable/2020-09-01.12.0/BatchService.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- batch/data-plane/readme.md tag:package-2020-09.12.0
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- batch/data-plane/readme.md tag:package-2020-09.12.0

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R3016 - DefinitionsPropertiesNamesCamelCase	Property named: 'nodeAgentSKUId', for definition: 'ImageInformation' must follow camelCase style. Example: 'nodeAgentSkuId'. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L10698
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L11286
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Certificate_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L1257
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'JobSchedule_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L2867
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'JobSchedule_Terminate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L3793
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Job_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L4205
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Job_Disable' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L4828
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Job_Enable' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L4989
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Job_Terminate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L5141
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Pool_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L6235

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-03.11.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-03.11.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-08.10.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-08.10.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-06.9.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-06.9.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-12.8.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-12.8.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-08.7.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-28T16:32:15Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 741037c. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️batch/2020-09-01.12.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2020-03-01.11.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-08-01.10.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-06-01.9.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-12-01.8.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-08-01.7.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-03-01.6.1/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2017-05-01.5.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs]Release - Generate from 741037c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/data-plane/readme.md
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromTask' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromComputeNode' method missing 404 status code section -- this might be unintentional.

❌@azure/batch [View full logs] [Release SDK Changes]

error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/batch/batch]: npm pack --silent

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-28T16:32:44Z

Hi, @dpwatrous Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-04-28T16:32:45Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

dpwatrous · 2021-04-28T16:53:19Z

This is an update for documentation purposes only. No SDK changes are required.

jhendrixMSFT · 2021-04-29T15:17:30Z

/azp run

azure-pipelines · 2021-04-29T15:17:41Z

Azure Pipelines successfully started running 1 pipeline(s).

dpwatrous and others added 2 commits April 28, 2021 09:32

[Batch] Update RemoveNodes description to include max nodes/request

db587de

Added suppressions to readme

8b748ae

openapi-sdkautomation bot mentioned this pull request Apr 28, 2021

[AutoPR @azure/batch] [Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 AzureSDKAutomation/azure-sdk-for-js#4568

Closed

dpwatrous marked this pull request as ready for review April 28, 2021 16:52

dpwatrous requested review from matthchr and xingwu1 as code owners April 28, 2021 16:52

openapi-assignment-bot bot assigned jhendrixMSFT Apr 28, 2021

jhendrixMSFT approved these changes Apr 29, 2021

View reviewed changes

jhendrixMSFT merged commit 741037c into master Apr 29, 2021

JackTn deleted the Batch-data-plane-docs-updates-2020-09-01.12.0 branch August 17, 2021 06:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 #14170

[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 #14170

Uh oh!

dpwatrous commented Apr 28, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 28, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 28, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Apr 28, 2021

Uh oh!

openapi-workflow-bot bot commented Apr 28, 2021

Uh oh!

dpwatrous commented Apr 28, 2021

Uh oh!

jhendrixMSFT commented Apr 29, 2021

Uh oh!

azure-pipelines bot commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 #14170

[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 #14170

Uh oh!

Conversation

dpwatrous commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot bot commented Apr 28, 2021

Uh oh!

openapi-workflow-bot bot commented Apr 28, 2021

Uh oh!

dpwatrous commented Apr 28, 2021

Uh oh!

jhendrixMSFT commented Apr 29, 2021

Uh oh!

azure-pipelines bot commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dpwatrous commented Apr 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 28, 2021 •

edited

Loading