Skip to content

Commit 741037c

Browse files
authored
[Hub Generated] Review request for Microsoft.Batch to add version stable/2020-09-01.12.0 (#14170)
* [Batch] Update RemoveNodes description to include max nodes/request * Added suppressions to readme
1 parent 5f79658 commit 741037c

File tree

2 files changed

+28
-12
lines changed

2 files changed

+28
-12
lines changed

specification/batch/data-plane/Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7679,7 +7679,7 @@
76797679
}
76807680
},
76817681
"summary": "Removes Compute Nodes from the specified Pool.",
7682-
"description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing.",
7682+
"description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing. Each request may remove up to 100 nodes.",
76837683
"x-ms-request-id": "request-id",
76847684
"parameters": [
76857685
{
@@ -15862,7 +15862,8 @@
1586215862
"items": {
1586315863
"type": "string"
1586415864
},
15865-
"title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool."
15865+
"title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool.",
15866+
"description": "A maximum of 100 nodes may be removed per request."
1586615867
},
1586715868
"resizeTimeout": {
1586815869
"type": "string",

specification/batch/data-plane/readme.md

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,24 @@
44
55
This is the AutoRest configuration file for Batch.
66

7-
8-
97
---
8+
109
## Getting Started
10+
1111
To build the SDK for Batch, simply [Install AutoRest](https://aka.ms/autorest/install) and in this folder, run:
1212

1313
> `autorest`
1414
1515
To see additional help and options, run:
1616

1717
> `autorest --help`
18+
1819
---
1920

2021
## Configuration
2122

22-
23-
2423
### Basic Information
24+
2525
These are the global settings for the Batch API.
2626

2727
``` yaml
@@ -113,6 +113,7 @@ input-file:
113113
## Suppression
114114

115115
Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/68) is fixed.
116+
116117
``` yaml
117118
directive:
118119
- suppress: R2063
@@ -121,6 +122,7 @@ directive:
121122
```
122123

123124
Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/69) is fixed.
125+
124126
``` yaml
125127
directive:
126128
- suppress: R2064
@@ -216,6 +218,20 @@ directive:
216218
reason: The suggested casing of this property is worse than the casing that we're using
217219
```
218220

221+
``` yaml
222+
- suppress: DefinitionsPropertiesNamesCamelCase
223+
where: $.definitions.ImageInformation.properties.nodeAgentSKUId
224+
from: BatchService.json
225+
reason: Changing the casing of this property would be a breaking change
226+
```
227+
228+
``` yaml
229+
- suppress: AvoidNestedProperties
230+
where: $.definitions.NodeFile.properties.properties
231+
from: BatchService.json
232+
reason: Switching to x-ms-client-flatten would be a breaking change to the SDKs
233+
```
234+
219235
### Tag: package-2017-05.5.0
220236

221237
These settings apply only when `--tag=package-2017-05.5.0` is specified on the command line.
@@ -225,7 +241,6 @@ input-file:
225241
- Microsoft.Batch/stable/2017-05-01.5.0/BatchService.json
226242
```
227243

228-
229244
### Tag: package-2017-01.4.0
230245

231246
These settings apply only when `--tag=package-2017-01.4.0` is specified on the command line.
@@ -262,10 +277,9 @@ input-file:
262277
- Microsoft.Batch/stable/2015-12-01.2.2/BatchService.json
263278
```
264279

265-
266280
---
267-
# Code Generation
268281

282+
# Code Generation
269283

270284
## Swagger to SDK
271285

@@ -311,11 +325,13 @@ python:
311325
package-name: azure-batch
312326
clear-output-folder: true
313327
```
328+
314329
``` yaml $(python) && $(python-mode) == 'update'
315330
python:
316331
no-namespace-folders: true
317332
output-folder: $(python-sdks-folder)/azure-batch/azure/batch
318333
```
334+
319335
``` yaml $(python) && $(python-mode) == 'create'
320336
python:
321337
basic-setup-py: true
@@ -357,7 +373,7 @@ java:
357373
output-folder: $(azure-libraries-for-java-folder)/azure-batch
358374
```
359375

360-
## Multi-API/Profile support for AutoRest v3 generators
376+
## Multi-API/Profile support for AutoRest v3 generators
361377

362378
AutoRest V3 generators require the use of `--tag=all-api-versions` to select api files.
363379

@@ -386,11 +402,10 @@ input-file:
386402
387403
```
388404

389-
If there are files that should not be in the `all-api-versions` set,
405+
If there are files that should not be in the `all-api-versions` set,
390406
uncomment the `exclude-file` section below and add the file paths.
391407

392408
``` yaml $(tag) == 'all-api-versions'
393409
#exclude-file:
394410
# - $(this-folder)/Microsoft.Example/stable/2010-01-01/somefile.json
395411
```
396-

0 commit comments

Comments
 (0)