AKS: Review request for Microsoft.ContainerService to add version stable/2021-05-01 #14147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-03-01 to version 2021-05-01
|
Hi, @levimm Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableUltraSSD Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L2484 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePrivateClusterPublicFQDN Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3380 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L2504 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L2574 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3129 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3319 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3414 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3455 |
|
Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3489 |
|
Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3789 |
|
The response of operation:'ManagedClusters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L418 |
|
The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L899 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 32 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-05-01/managedClusters.json compared with base:preview/2018-08-01-preview/managedClusters.json
- current:stable/2021-05-01/managedClusters.json compared with base:stable/2021-03-01/managedClusters.json
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05-01-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05-01-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
This was referenced Apr 27, 2021
…01 (#14149) * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 api * ref example Co-authored-by: Li Ma <[email protected]>
* Add swagger for OutboundNetworkDependenciesEndpoints for AKS * fix * lint * update operationId
Co-authored-by: Li Ma <[email protected]>
|
Hi, @levimm your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @PhoenixHe-msft |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
levimm
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
confirmed sdk breaking change is a bug at go-sdk side. This bug will be fixed today. |
gossion
approved these changes
Jun 1, 2021
feiskyer
approved these changes
Jun 1, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi ARM reviewer, the CI-BreakingChange-Go is not caused by this pr. Please help review. The individual commits were approved by ARM before. |
PhoenixHe-NV
requested review from
ArcturusZhang,
jsntcy,
msyyc,
RAY-316 and
zhangyan133
as code owners
majastrz
reviewed
Jun 1, 2021
| "body": { | ||
| "value": [ | ||
| { | ||
| "category": "azure-resource-management", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @majastrz ,
This is already answered and signed off in #14332 (comment) when merging the PR to dev branch
There was a problem hiding this comment.
Given that you're ok with the suboptimal API design, the restrictions it causes (as explained by @pilor in the linked comment), and the fact that it was already approved by API review, I'll let it slide.
There was a problem hiding this comment.
Also keep in mind that this is a one-off exception and it should not be used to justify similar designs elsewhere in the RP.
You should also add a single GET path for Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2021-05-01/managedClusters.json:1876 in 808938d. [](commit_id = 808938d, deletion_comment = False) |
majastrz
added
ARMChangesRequested
Hi @majastrz , |
levimm
added
WaitForARMRevisit
and removed
ARMChangesRequested
majastrz
added
ARMSignedOff
Co-authored-by: Li Ma <[email protected]>
This was referenced Jun 2, 2021
26 tasks
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ble/2021-05-01 (Azure#14147) * Adds base for updating Microsoft.ContainerService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 (Azure#14149) * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 api * ref example Co-authored-by: Li Ma <[email protected]> * Add swagger for OutboundNetworkDependenciesEndpoints for AKS (Azure#14332) * Add swagger for OutboundNetworkDependenciesEndpoints for AKS * fix * lint * update operationId * aks: add enableUltraSSD in v20210501 api-version (Azure#14354) * update doc for agentpool max count from 100 to 1000 (Azure#14553) Co-authored-by: Li Ma <[email protected]> * add readme for new version (Azure#14611) Co-authored-by: Li Ma <[email protected]> * fix conflict (Azure#14614) Co-authored-by: Li Ma <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: gossion <[email protected]> Co-authored-by: Andy Zhang <[email protected]>
FumingZhang
deleted the
dev-containerservice-Microsoft.ContainerService-2021-05-01
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.