-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to support nextLink with post calls for python sdk #14035
Conversation
Hi, @najagasi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Hi @najagasi, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@najadojo , could you please fix CI failures? |
@erich-wang thanks for your link, @najagasi have you had a chance to attend office hours? thank you so much again for your patience! |
…r python sdk (#1728) Create to sync Azure/azure-rest-api-specs#14035 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/policyinsights?expand=1)
"/{nextLink}": { | ||
"post": { | ||
"operationId": "PolicyStates_NextLink", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path probably need to be {nextLink}
(without the /
), as response have full URI.
"@odata.nextLink" : "https://management.azure.com/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/providers/Microsoft.PolicyInsights/policyStates/latest/queryResults?api-version=2019-10-01&%24skipToken=nZLLbtswEEX_hWvLelG0pV2BbrIIEDhZdcfHUKItkvaQsisH_vdSieEWRRZFlyTmzrlzZ94J-kt4BRdJV6zIaQKcn1wEPPORdO9Eo7ekI1VRlVmxyYrtW9F2FevqYt3WZd1sqh9kRaL_s6b9oua2IiMPcecvO5Ae1dL7zVgIkdvjX-JyATTbNa1qxujSfwfBTyjhKelIHiYRJJpjNN6FvBClZnRTZqXQRUaV4hkHWWdStNWm0kXbtEWO9wY9-ukYcjmamNBr7BnlTNjTXFt1ofO-6c_MXjdTPB96MQa9rzkyF1lvWO-H64g_D-oUKo4CDprtwZn8iP5sFGDIn41EH7yO69fTmIeU4fJ7Z30-2UBl9INxqMamxwNYAWYeZEObZm-BIZNUeRz0BfbzZNHnikcueICQ25QfYErjxY9Gzt9CML2zaXP_ncpv6_ZhnU9x8GiufEk3P36g-AMV0lhyQhNnmcCAYjJjNO5h6jto48wi_TT1rwT10KXAZLutG11lrWYio1JuMy4oz_QWNCsbEDVtvwDuQAOCux9JOI1KLNnJdHbBaCM_BrI-uUvjuZ7cbr8A"
However the problem is that nextLink request should always be quested via GET
, see #15136
/azp run |
* single example with post nextLinl * address suggestions * remove examples * Add nextLink param * Post on nextLink for all requests * Add api-version as param * update readme * prettier fix * fix lint err try * rename operation id * fix generation for python * fix casing of next link * Remove package * change one next link op to normal path * readme.python config * Update readme.python.md Co-authored-by: Namrata Jagasia <[email protected]> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Zed <[email protected]> Co-authored-by: msyyc <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.