Skip to content

Update openapi-authoring-automated-guidelines.md#13859

Merged
jianyexi merged 8 commits intomasterfrom
jianyexi-patch-3
Jun 1, 2021
Merged

Update openapi-authoring-automated-guidelines.md#13859
jianyexi merged 8 commits intomasterfrom
jianyexi-patch-3

Conversation

@jianyexi
Copy link
Contributor

@jianyexi jianyexi commented Apr 9, 2021

Changes:
update documentation for R2005
add new rule: MissingTypeObject

@openapi-workflow-bot
Copy link

Hi, @jianyexi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 9, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 9, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @jianyexi jianyexi requested a review from josefree April 9, 2021 01:57
    @ghost
    Copy link

    ghost commented Apr 25, 2021

    Hi, @jianyexi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Apr 25, 2021
    @ghost ghost closed this May 10, 2021
    @ghost
    Copy link

    ghost commented May 10, 2021

    Hi, @jianyexi. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @jianyexi jianyexi reopened this May 24, 2021
    @ghost ghost removed the no-recent-activity label May 24, 2021
    @jianyexi jianyexi requested a review from lmazuel May 24, 2021 06:48
    @jianyexi
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jianyexi jianyexi merged commit a380bd6 into master Jun 1, 2021
    @jianyexi jianyexi deleted the jianyexi-patch-3 branch January 7, 2022 03:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants