Adding license header constant in SiteRecovery spec#1227
Adding license header constant in SiteRecovery spec#1227jhendrixMSFT merged 2 commits intoAzure:masterfrom
Conversation
|
@avneeshrai, |
| "type": "string" | ||
| } | ||
| }, | ||
| "properties": {}, |
There was a problem hiding this comment.
Is there a reason why this was left empty?
There was a problem hiding this comment.
@jhendrixMSFT model VmmToAzureUpdateNetworkMappingInput in service as of now doesn't have any value specific to this instance as of now and has been introduced to make it future extensible and consistent with other sibling models (we expect it to have some fields in near future).
Swagger changes just represent what the service expects
| "type": "object", | ||
| "properties": { | ||
| "InstanceType": { | ||
| "instanceType": { |
There was a problem hiding this comment.
Did the service change or is this update to the swagger making it match the service?
There was a problem hiding this comment.
This update to swagger matches it to service.
|
@jhendrixMSFT responded to your comments. Let me know if any other action item is on me or merge if it can be merged :) |
|
No modification for Ruby |
|
No modification for Python |
|
No modification for NodeJS |
5 participants
Change is to address the comment on PR: Azure/azure-sdk-for-net#3194
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger
This change is