Adding projects for RecoveryServices.SiteRecovery service. #3194
Conversation
|
@avneeshrai, |
…ionResults in operation id
1) Removing operationresults apis. 2) Introducing operations api. 3) Fixing issue in a patch model. 4) Changing few fields to string from boolean.
avneeshrai
changed the title
|
Can someone review this PR please. Corresponding swagger PR: Azure/azure-rest-api-specs#1209 is merged. I have removed do not merge tag. |
| @@ -0,0 +1,47 @@ | |||
| // Code generated by Microsoft (R) AutoRest Code Generator 0.16.0.0 | |||
| // Changes may cause incorrect behavior and will be lost if the code is | |||
There was a problem hiding this comment.
@avneeshrai missing license header.
Chances are your swagger does not have the right License Header Constant, please double check, I believe the constant that you need to use in your swagger is "MIT-no-version"
There was a problem hiding this comment.
@shahabhijeet can you please point to some example spec on what exacty needs to be done here
I tried searching MIT-no-version in azure-rest-api-spec repository but couldnt find any instance of it
| @@ -0,0 +1,47 @@ | |||
| // Code generated by Microsoft (R) AutoRest Code Generator 0.16.0.0 | |||
There was a problem hiding this comment.
@avneeshrai please use latest AutoRest (at least 1.0)
There was a problem hiding this comment.
even after doing autorest --latest or autorest --reset
the version that i get is 0.16.0.0.
How to i get 1.0?
|
@shahabhijeet Please review and merge the change in swagger spec as you had suggested in the PR: Azure/azure-rest-api-specs#1227 |
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
@avneeshrai please reference 1.5.0-preview of Resource manager in your test project.
With the new resource manager, you will be using the new nuget (might need to add new namespace) and then record your tests.
Don't worry if you see the older version of resource mangaer in your project, that is going to be there as it's a common dependency (we want to remove this dependency soon)
Record all your tests and that should solve the testing issue, I had mentioned earlier.
There was a problem hiding this comment.
@shahabhijeet as discussed offline...we dont have dependency on Resource manager in our projects. Have removed all the stale references that we had.
4 participants
It's corresponding to new swagger spec which is under PR Azure/azure-rest-api-specs#1209
Intent is to get early feedback here.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.