add updated databases.json swagger#11587
Closed
xaliciayang wants to merge 69 commits intoAzure:masterfrom
Closed
Conversation
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"details":" "Channel": "fatal", "Text": "swagger-document-override/md-override-loader - FAILED" "Channel": "fatal", "Text": "Error: Could not read 'file:///home/vsts/work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2020-02-02-preview/managedDatabases.json'."(node:6289) UnhandledPromiseRejectionWarning: Error: Could not read 'file:///home/vsts/work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2020-02-02-preview/managedDatabases.json'. at ReadThroughDataSource.ReadStrict (/home/vsts/.autorest/@microsoft.azure_autorest-core@2.0.4417/node_modules/@microsoft.azure/autorest-core/dist/lib/data-store/data-store.js:26:19)", "location":"https://github.com/Azure/azure-rest-api-specs/blob/40031a674688e5b5d95e8498adacb3ebafee6cf8/specification/sql/resource-manager/readme.md" |
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The JSON file is not found but it is referenced from the readme file. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2020-02-02-preview/importexport.json |
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4 |
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Additional properties not allowed: requestedBackupStorageRedundancy Url: Microsoft.Sql/preview/2020-11-01-preview/Databases.json#L1148 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 4 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-08-01-preview/Databases.json <---> new: preview/2020-11-01-preview/Databases.json
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
azure-sdk-for-java
|
azure-sdk-for-net
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Nov 9, 2020
Open
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Update comment.yml * Update comment.yml
…n stable/2020-06-02 (Azure#11976) * update swagger api * add custom words * remove secret in examples * test validation * test validation * test validation * suppress verifyToken * suppress verifyToken * suppress verifyToken * suppress verifyToken * suppress verifyToken * suppress verifyToken * suppress verifyToken
…#11716) * Added new specification for chat - release 2020-11-01-preview3 * Addressing feedback * Updating max page size parameter name * update `maxpagesize` parameter name in example file. * Runn prettier on examples * Removing obsolete example files, and adding missing description properties. * Update `maxpagesize` query parameter name for `ListChatThreads` * rename $maxpagesize to `maxPageSize` Co-authored-by: Camilo Ramirez <juramir@microsoft.com> Co-authored-by: Amr Elroumy <amr.elroumy@microsoft.com>
…ang/azure-rest-api-specs into backupStorageRedundancy
xaliciayang
requested review from
Kishp01,
MehaKaushik,
RandalliLama,
ahamad-MS,
heaths,
hectorhdzg,
jlichwa,
lmazuel,
lzchen,
ofirmanor,
orieldar,
ramthi,
shurd,
stankovski,
v-Ajnava and
yugangw-msft
as code owners
Member
|
@xaliciayang , please fix CI errors, thanks. |
Member
|
Please rebase your commits onto master rather than simply merging in everyone else's commits, which makes this PR huge and, for most files, probably unnecessary for all of us codeowners to review. You probably juse need to do: git fetch upstream master # assuming "upstream" is your azure/azure-rest-api-specs repo
git rebase FETCH_HEADOtherwise, please see https://heaths.dev/tips/2019/11/11/rebasing-commits-on-one-topic-branch-onto-another-branch.html for an example of |
Contributor
Author
Thanks for the tips! I will be abandoning this PR since I was clearly having some issues (I reopened a new one for just my changes) but I have been struggling with rebasing so these will probably come in handy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.