[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790

roytan-microsoft · 2020-11-23T23:06:59Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-11-23T23:07:03Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-04-06-preview/proxy.json <---> new: preview/2020-04-06-preview/proxy.json

Rule	Message
`❌` 1026 - TypeChanged	The new version has a different type 'boolean' than the previous one 'string'. New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145:9 Old: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L162:7 Old: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L162:7

️⚠️LintDiff: 2 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- mixedreality/resource-manager/readme.md tag:package-2020-04-06-preview
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- mixedreality/resource-manager/readme.md tag:package-2020-04-06-preview

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L171

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mixedreality/resource-manager/readme.md tag: specification/mixedreality/resource-manager/readme.md#tag-package-2020-05

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-11-23T23:07:03Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c1927d1. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/mixedreality/mgmt/2020-05-01-preview/mixedreality [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/mixedreality/mgmt/2019-02-28/mixedreality [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-net warning [Detail]

⚠️Warning [Logs]Release - Generate from c1927d1. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.MixedReality [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.MixedReality.1.0.0.nupkg
- Microsoft.Azure.Management.MixedReality.1.0.0.snupkg

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c1927d1. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md

️✔️azure-mgmt-mixedreality [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-mixedreality
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-mixedreality
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.mixedreality
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.mixedreality
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.mixedreality
cmderr	[changelogReport] INFO:__main__:Report written to sdk/mixedreality/azure-mgmt-mixedreality/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-mixedreality on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0b1 of azure-mgmt-mixedreality in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.mixedreality
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.mixedreality
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.mixedreality
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/mixedreality/azure-mgmt-mixedreality/code_reports/1.0.0b1/report.json
cmdout	[Changelog] Size of delta 55.621% size of original (original: 15683 chars, delta: 8723 chars)
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.list_keys has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.list_by_resource_group has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.get has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.delete has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.update has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.list_keys has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.list_by_resource_group has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.get has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.delete has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.create has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.regenerate_keys has a new signature
cmdout	[Changelog]   - Operation RemoteRenderingAccountsOperations.list_by_subscription has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.create has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.regenerate_keys has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.list_by_subscription has a new signature
cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.update has a new signature
cmdout	[Changelog]   - Operation MixedRealityClientOperationsMixin.check_name_availability_local has a new signature
cmdout	[Changelog]   - Operation Operations.list has a new signature
warn	Breaking change found in changelog

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c1927d1. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md

️✔️@azure/arm-mixedreality [View full logs] [Release SDK Changes]

azure-arm-mixedreality-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mixedRealityClient.js → ./dist/arm-mixedreality.js...
cmderr	[npmPack] created ./dist/arm-mixedreality.js in 293ms

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from c1927d1. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2020-12-16 10:38:33 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mixedreality"
cmderr	[generate.py] 2020-12-16 10:38:33 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-16 10:38:33 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality --java.namespace=com.azure.resourcemanager.mixedreality  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
cmderr	[generate.py]   Error: $ref to original location 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/mixedreality/resource-manager/Microsoft.MixedReality/stable/2020-05-01/common.json#/components/parameters/accountKeyRegenerateParameter' is not found in the new refs collection
cmderr	[generate.py] 2020-12-16 10:39:06 ERROR [GENERATE] Autorest fail
ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality/pom.xml'
Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality/pom.xml'

️✔️azure-resourcemanager-mixedreality [View full logs]

error	Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality/pom.xml'
error	The following packages are still pending:
error		azure-resourcemanager-mixedreality

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs]Release - Generate from c1927d1. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
cmderr	[Autorest] Failure during batch task - {"tag":"schema-mixedreality-2020-05-01"} -- Error: $ref to original location 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/mixedreality/resource-manager/Microsoft.MixedReality/stable/2020-05-01/common.json#/components/parameters/accountKeyRegenerateParameter' is not found in the new refs collection.
cmderr	[Autorest]   Error: $ref to original location 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/mixedreality/resource-manager/Microsoft.MixedReality/stable/2020-05-01/common.json#/components/parameters/accountKeyRegenerateParameter' is not found in the new refs collection
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas/azure-resource-manager-schemas]: autorest
warn	Skip package processing as generation is failed

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-11-23T23:11:16Z

Hi @roytan-microsoft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

roytan-microsoft · 2020-12-10T00:43:39Z

@leni-msft These are changes to the RP swagger to match what has long been our behavior and in fact required by the ARM API. The swagger PR for an earlier version has already been approved by you.

The breaking change work item is here:
https://msazure.visualstudio.com/One/_workitems/edit/8795462/

leni-msft · 2020-12-11T02:16:51Z

@ArcturusZhang pls check the go breaking change

ArcturusZhang · 2020-12-16T06:01:03Z

/azp run

azure-pipelines · 2020-12-16T06:01:18Z

Azure Pipelines successfully started running 2 pipeline(s).

ArcturusZhang · 2020-12-16T06:21:23Z

@leni-msft it is fixed and no breaking changes detected.

isDataAction and nameAvailability

a64ddd1

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Nov 23, 2020

openapi-sdkautomation bot mentioned this pull request Nov 23, 2020

[AutoPR @azure/arm-mixedreality] [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview AzureSDKAutomation/azure-sdk-for-js#2693

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 23, 2020

roytan-microsoft marked this pull request as ready for review December 7, 2020 23:29

openapi-assignment-bot bot assigned leni-msft Dec 7, 2020

leni-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 11, 2020

openapi-pipeline-app bot added CI-BreakingChange-Python and removed BreakingChangeReviewRequired CI-BreakingChange-Go labels Dec 16, 2020

leni-msft approved these changes Dec 16, 2020

View reviewed changes

leni-msft merged commit c1927d1 into Azure:master Dec 16, 2020

giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020

isDataAction and nameAvailability (Azure#11790)

ef4f9c8

josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021

isDataAction and nameAvailability (Azure#11790)

0bb2d0f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790

[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790

roytan-microsoft commented Nov 23, 2020

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

openapi-workflow-bot bot commented Nov 23, 2020

roytan-microsoft commented Dec 10, 2020

leni-msft commented Dec 11, 2020

ArcturusZhang commented Dec 16, 2020

azure-pipelines bot commented Dec 16, 2020

ArcturusZhang commented Dec 16, 2020

[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790

[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790

Conversation

roytan-microsoft commented Nov 23, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Nov 23, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 23, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Nov 23, 2020

roytan-microsoft commented Dec 10, 2020

leni-msft commented Dec 11, 2020

ArcturusZhang commented Dec 16, 2020

azure-pipelines bot commented Dec 16, 2020

ArcturusZhang commented Dec 16, 2020

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading