Skip to content

[Synapse] - name now is a required property for NotebookResource and SqlScriptResource #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 2 commits into from
Oct 28, 2020
Merged

[Synapse] - name now is a required property for NotebookResource and SqlScriptResource #11268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81cfd5b
[Synapse] - name now is a required property for NotebookResource and …
Oct 19, 2020
b072e34
Update examples
Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 40 additions & 10 deletions specification/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3285,18 +3285,33 @@
},
"SqlScriptResource": {
"description": "Sql Script resource type.",
"allOf": [
{
"$ref": "#/definitions/SubResource"
}
],
"properties": {
"id": {
"readOnly": true,
"type": "string",
"description": "Fully qualified resource Id for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
},
"name": {
"type": "string",
"description": "The name of the resource"
},
"type": {
"readOnly": true,
"type": "string",
"description": "The type of the resource. Ex- Microsoft.Compute/virtualMachines or Microsoft.Storage/storageAccounts."
},
"etag": {
"type": "string",
"readOnly": true,
"description": "Resource Etag."
},
"properties": {
"$ref": "./entityTypes/SqlScript.json#/definitions/SqlScript",
"description": "Properties of sql script."
}
},
"required": [
"name",
"properties"
]
},
Expand Down Expand Up @@ -3359,18 +3374,33 @@
},
"NotebookResource": {
"description": "Notebook resource type.",
"allOf": [
{
"$ref": "#/definitions/SubResource"
}
],
"properties": {
"id": {
"readOnly": true,
"type": "string",
"description": "Fully qualified resource Id for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
},
"name": {
"type": "string",
"description": "The name of the resource"
},
"type": {
"readOnly": true,
"type": "string",
"description": "The type of the resource. Ex- Microsoft.Compute/virtualMachines or Microsoft.Storage/storageAccounts."
},
"etag": {
"type": "string",
"readOnly": true,
"description": "Resource Etag."
},
"properties": {
"$ref": "./entityTypes/Notebook.json#/definitions/Notebook",
"description": "Properties of Notebook."
}
},
"required": [
"name",
"properties"
]
},
Expand Down
3 changes: 2 additions & 1 deletion ...synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Notebook.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
},
"bigDataPool": {
"description": "Big data pool reference.",
"$ref": "#/definitions/BigDataPoolReference"
"$ref": "#/definitions/BigDataPoolReference",
"x-nullable": true
},
"sessionProperties": {
"description": "Session properties.",
Expand Down
1 change: 1 addition & 0 deletions ...se/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/examples/Notebooks_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"notebookName": "exampleNotebook",
"ifMatch": null,
"Notebook": {
"name": "exampleNotebook",
"properties": {
"description": "A sample Notebook",
"nbformat": 4,
Expand Down
1 change: 1 addition & 0 deletions ...se/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/examples/Notebooks_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"notebookName": "exampleNotebook",
"ifMatch": null,
"Notebook": {
"name": "exampleNotebook",
"properties": {
"description": "Modified description",
"nbformat": 4,
Expand Down
1 change: 1 addition & 0 deletions ...e/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/examples/SqlScripts_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"sqlScriptName": "exampleSqlScript",
"ifMatch": null,
"sqlScript": {
"name": "exampleSqlScript",
"properties": {
"description": "Covers the data transformation and LDW scenarios in one brief e2e story",
"content": {
Expand Down
1 change: 1 addition & 0 deletions ...e/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/examples/SqlScripts_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"sqlScriptName": "exampleSqlScript",
"ifMatch": null,
"sqlScript": {
"name": "exampleSqlScript",
"properties": {
"description": "modified description",
"content": {
Expand Down