Skip to content

[Synapse] - name now is a required property for NotebookResource and SqlScriptResource#11268

Merged
lmazuel merged 2 commits intoAzure:masterfrom
idear1203:synapse_required_name_property
Oct 28, 2020
Merged

[Synapse] - name now is a required property for NotebookResource and SqlScriptResource#11268
lmazuel merged 2 commits intoAzure:masterfrom
idear1203:synapse_required_name_property

Conversation

@idear1203
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @idear1203 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 19, 2020

    [Staging] Swagger Validation Report

    BreakingChange: 36 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
    Rule Message
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3286:5
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3286:5
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2216:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2216:13
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1784:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1784:13
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2208:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2208:13
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3365:11
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3350:11
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2260:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2260:13
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3276:11
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3276:11
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3375:5
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L3360:5
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1735:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1735:13
    1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1743:13
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1743:13
    ️✔️LintDiff [Detail]
     Validation passes for LintDiff. 
    ️✔️Avocado [Detail]
     Validation passes for Avocado. 
    ️✔️ModelValidation [Detail]
     Validation passes for ModelValidation. 
    ️✔️SemanticValidation [Detail]
     Validation passes for SemanticValidation. 
    Posted by Swagger Pipeline | How to fix these errors?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-go - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-python - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-js - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 19, 2020

    azure-resource-manager-schemas - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lmazuel lmazuel merged commit 7181280 into Azure:master Oct 28, 2020
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    …SqlScriptResource (Azure#11268)
    
    * [Synapse] - name now is a required property for NotebookResource and SqlScriptResource
    
    * Update examples
    
    Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants