Skip to content

Hdinsight spec v4 #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pulkittomar wants to merge 9 commits into from
Closed

Hdinsight spec v4 #1126

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
311d438
ARM-HDInsight composite specs with examples.
Mar 28, 2017
dd0dd2a
Removed null types as sdk generation code doesn't like it
Mar 28, 2017
27210da
Fixed autorest camelcase errors. Added cluster patch request.
Apr 4, 2017
c429226
Added description for storage account model
Apr 4, 2017
94e108a
Removed swagger property from composite.json to make circleci pass. T…
Apr 6, 2017
0faec38
Added missing descriptions. Named missing body attributes as parameters.
Apr 8, 2017
18cf6bf
Updated description
Apr 8, 2017
cce6e12
Updated object property for cluster definition
Apr 14, 2017
9fd503c
Fixed merge conflict with Azure master
Apr 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion arm-hdinsight/2015-03-01-preview/swagger/cluster.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@
"description": "The payload for a Configure HTTP settings request."
},
"ClusterDefinition": {
"description": "The cluste definition.",
"description": "The cluster definition.",
"properties": {
"blueprint": {
"type": "string",
Expand All @@ -404,6 +404,9 @@
},
"configurations": {
"type": "object",
"additionalProperties": {
Copy link
Contributor

@sergey-shandar sergey-shandar Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's still breaking changes. In .Net, it became a Dictionary instead of an object.

Copy link
Contributor

@sergey-shandar sergey-shandar Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, this code worked before:

clusterDefinition.configurations = new { A = new { C = "Hello!" } };

but it will be a compilation error now.

"type": "object"
},
"description": "The cluster configurations."
}
}
Expand Down