Conversation
Changes do not include: 1. null specification for each data member. Some members may support nulls, but as per spec we haven't validated those. 2. Data format validation. We have to validate that all date strings follow the pattern as expected. Current date format patterns fail to validate dates in hdinsight api response, so we have removed the date check for now. 3. We have added readonly to most properties, but we need to validate those properties again.
Completed validation of HDInsight spec
…he property was added to pass a violation but it is not needed anymore.
|
@pulkittomar, |
sergey-shandar
left a comment
sergey-shandar
left a comment
There was a problem hiding this comment.
Breaking changes.
| }, | ||
| "configurations": { | ||
| "type": "object", | ||
| "additionalProperties": { |
There was a problem hiding this comment.
This's still breaking changes. In .Net, it became a Dictionary instead of an object.
There was a problem hiding this comment.
For example, this code worked before:
clusterDefinition.configurations = new { A = new { C = "Hello!" } };but it will be a compilation error now.
|
What are the action items here @sergey-shandar if there requested changes please mark it that way :) |
|
@pulkittomar as discussed in another PR, these changes still contain breaking changes. Please, address the issue or close the PR. |
sergey-shandar
left a comment
sergey-shandar
left a comment
There was a problem hiding this comment.
Please, address the breaking changes issue.
|
@pulkittomar I'm closing this on. Feel free to reopen it if you are working on new changes or would like to discuss the breaking changes issue. |
4 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger