-
Notifications
You must be signed in to change notification settings - Fork 5.8k
ADP - add missing ProvisioningState #10948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "201": {}, | ||
| "202": {}, | ||
| "204": {} | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "201": {}, | ||
| "202": {}, | ||
| "204": {} | ||
| } | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
specification/adp/resource-manager/readme.azureresourceschema.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| ## AzureResourceSchema | ||
|
|
||
| These settings apply only when `--azureresourceschema` is specified on the command line. | ||
|
|
||
| ### AzureResourceSchema multi-api | ||
|
|
||
| ``` yaml $(azureresourceschema) && $(multiapi) | ||
| batch: | ||
| - tag: schema-adp-2020-07-01-preview | ||
|
|
||
| ``` | ||
|
|
||
| Please also specify `--azureresourceschema-folder=<path to the root directory of your azure-resource-manager-schemas clone>`. | ||
|
|
||
| ### Tag: schema-adp-2020-07-01-preview and azureresourceschema | ||
|
|
||
| ``` yaml $(tag) == 'schema-adp-2020-07-01-preview' && $(azureresourceschema) | ||
| output-folder: $(azureresourceschema-folder)/schemas | ||
|
|
||
| # all the input files in this apiVersion | ||
| input-file: | ||
| - Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json | ||
|
|
||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this enum marked as
"modelAsString": false?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the same pattern for
ProvisioningStatefrom other RPs. Why do you think it should it betrue? I would like an enum to be generated in the SDK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed enums (modelAsString: false) have proven to be version intolerant (over time). If you can commit to never, ever add a new provisioning state value, then this is ok.