Skip to content

ADP - add missing ProvisioningState#10948

Merged
lirenhe merged 5 commits into
Azure:masterfrom
aelij:addstate
Oct 6, 2020
Merged

ADP - add missing ProvisioningState#10948
lirenhe merged 5 commits into
Azure:masterfrom
aelij:addstate

Conversation

@aelij
Copy link
Copy Markdown
Member

@aelij aelij commented Sep 25, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Sep 25, 2020

[Staging] Swagger Validation Report

BreakingChange: 5 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L330:11
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L583:11
1012 - RemovedResponseCode The new version removes the response code '201'
Old: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L330:11
1012 - RemovedResponseCode The new version removes the response code '201'
Old: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L583:11
1020 - AddedEnumValue The new version is adding enum value(s) 'Accepted' from the old version.
New: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L669:9
Old: Microsoft.AutonomousDevelopmentPlatform/preview/2020-07-01-preview/adp.json#L669:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service adp [Preview Changes]
    curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10948/azure-cli-extensions/adp/adp-0.1.0-py3-none-any.whl" -o adp-0.1.0-py3-none-any.whl
    az extension add --source=adp-0.1.0-py3-none-any.whl
    
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 079ea18 with merge commit 6875a9b. Azure CLI Automation 13.0.17.20200918.2
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'DataPoolProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Tags' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPool' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolPatch' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolBaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolProperties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolLocation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
    [AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Accounts/put/Put account
    [AutoRest]     - name: /Accounts/get/Get account
    [AutoRest]     - name: /Accounts/get/List accounts
    [AutoRest]     - name: /Accounts/get/List accounts by resource group
    [AutoRest]     - name: /Accounts/patch/Patch account
    [AutoRest]     - name: /DataPools/put/Put Data Pool
    [AutoRest]     - name: /DataPools/get/Get Data Pool
    [AutoRest]     - name: /DataPools/get/List Data Pools
    [AutoRest]     - name: /DataPools/patch/Patch Data Pool
    [AutoRest]     - name: /DataPools/delete/Delete Data Pool
    [AutoRest]     - name: /Accounts/delete/Delete account
    [AutoRest] --------------------------------------------------------
  • Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 06 Oct 2020 12:38:31 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"06C2:60E8:9AD852:1737004:5F7C6547","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 079ea18 with merge commit 6875a9b. SDK Automation 13.0.17.20200918.2
  • ️✔️preview/adp/mgmt [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 06 Oct 2020 12:41:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0441:65E6:371DCEF:58A5B34:5F7C65F1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-sdk-for-python-track2 - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 079ea18 with merge commit 6875a9b. SDK Automation 13.0.17.20200918.2
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'DataPoolProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Tags' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPool' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolPatch' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolBaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolProperties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolLocation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataPoolList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [track2_azure-mgmt-adp][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-adp [View full logs]  [Release SDK Changes]
    [build_conf_init]   Cache entry deserialization failed, entry ignored
    [build_conf_init]   Cache entry deserialization failed, entry ignored
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-adp
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-adp
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-adp
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 06 Oct 2020 12:40:04 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:FACF:269F928B:2DF63528:5F7C65A4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/v2020_07_01_preview.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 079ea18 with merge commit 6875a9b. SDK Automation 13.0.17.20200918.2
  • [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/adpManagementClient.js → ./dist/adp.js...
    [npmPack] created ./dist/adp.js in 275ms
    [npmPack] npm notice 
    [npmPack] npm notice package: adp@0.0.1
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 10.9kB  esm/operations/accounts.js             
    [npmPack] npm notice 597B    esm/models/accountsMappers.js          
    [npmPack] npm notice 58.9kB  dist/adp.js                            
    [npmPack] npm notice 19.3kB  dist/adp.min.js                        
    [npmPack] npm notice 1.6kB   esm/adpManagementClient.js             
    [npmPack] npm notice 2.5kB   esm/adpManagementClientContext.js      
    [npmPack] npm notice 10.5kB  esm/operations/dataPools.js            
    [npmPack] npm notice 579B    esm/models/dataPoolsMappers.js         
    [npmPack] npm notice 345B    esm/models/index.js                    
    [npmPack] npm notice 438B    esm/operations/index.js                
    [npmPack] npm notice 18.2kB  esm/models/mappers.js                  
    [npmPack] npm notice 2.3kB   esm/operations/operations.js           
    [npmPack] npm notice 592B    esm/models/operationsMappers.js        
    [npmPack] npm notice 2.3kB   esm/models/parameters.js               
    [npmPack] npm notice 958B    rollup.config.js                       
    [npmPack] npm notice 1.6kB   package.json                           
    [npmPack] npm notice 457B    tsconfig.json                          
    [npmPack] npm notice 3.1kB   esm/operations/accounts.d.ts.map       
    [npmPack] npm notice 5.8kB   esm/operations/accounts.js.map         
    [npmPack] npm notice 322B    esm/models/accountsMappers.d.ts.map    
    [npmPack] npm notice 335B    esm/models/accountsMappers.js.map      
    [npmPack] npm notice 117.8kB dist/adp.js.map                        
    [npmPack] npm notice 17.6kB  dist/adp.min.js.map                    
    [npmPack] npm notice 684B    esm/adpManagementClient.d.ts.map       
    [npmPack] npm notice 808B    esm/adpManagementClient.js.map         
    [npmPack] npm notice 504B    esm/adpManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/adpManagementClientContext.js.map  
    [npmPack] npm notice 2.7kB   esm/operations/dataPools.d.ts.map      
    [npmPack] npm notice 5.2kB   esm/operations/dataPools.js.map        
    [npmPack] npm notice 304B    esm/models/dataPoolsMappers.d.ts.map   
    [npmPack] npm notice 317B    esm/models/dataPoolsMappers.js.map     
    [npmPack] npm notice 8.5kB   esm/models/index.d.ts.map              
    [npmPack] npm notice 179B    esm/operations/index.d.ts.map          
    [npmPack] npm notice 126B    esm/models/index.js.map                
    [npmPack] npm notice 194B    esm/operations/index.js.map            
    [npmPack] npm notice 1.3kB   esm/models/mappers.d.ts.map            
    [npmPack] npm notice 10.4kB  esm/models/mappers.js.map              
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map     
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map       
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map  
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map    
    [npmPack] npm notice 492B    esm/models/parameters.d.ts.map         
    [npmPack] npm notice 1.6kB   esm/models/parameters.js.map           
    [npmPack] npm notice 3.0kB   README.md                              
    [npmPack] npm notice 8.0kB   esm/operations/accounts.d.ts           
    [npmPack] npm notice 16.1kB  src/operations/accounts.ts             
    [npmPack] npm notice 287B    esm/models/accountsMappers.d.ts        
    [npmPack] npm notice 585B    src/models/accountsMappers.ts          
    [npmPack] npm notice 1.0kB   esm/adpManagementClient.d.ts           
    [npmPack] npm notice 1.6kB   src/adpManagementClient.ts             
    [npmPack] npm notice 794B    esm/adpManagementClientContext.d.ts    
    [npmPack] npm notice 2.3kB   src/adpManagementClientContext.ts      
    [npmPack] npm notice 7.2kB   esm/operations/dataPools.d.ts          
    [npmPack] npm notice 14.0kB  src/operations/dataPools.ts            
    [npmPack] npm notice 269B    esm/models/dataPoolsMappers.d.ts       
    [npmPack] npm notice 562B    src/models/dataPoolsMappers.ts         
    [npmPack] npm notice 21.1kB  esm/models/index.d.ts                  
    [npmPack] npm notice 122B    esm/operations/index.d.ts              
    [npmPack] npm notice 20.2kB  src/models/index.ts                    
    [npmPack] npm notice 406B    src/operations/index.ts                
    [npmPack] npm notice 1.6kB   esm/models/mappers.d.ts                
    [npmPack] npm notice 14.6kB  src/models/mappers.ts                  
    [npmPack] npm notice 2.1kB   esm/operations/operations.d.ts         
    [npmPack] npm notice 4.2kB   src/operations/operations.ts           
    [npmPack] npm notice 282B    esm/models/operationsMappers.d.ts      
    [npmPack] npm notice 566B    src/models/operationsMappers.ts        
    [npmPack] npm notice 545B    esm/models/parameters.d.ts             
    [npmPack] npm notice 2.2kB   src/models/parameters.ts               
    [npmPack] npm notice 1.1kB   LICENSE.txt                            
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          adp                                     
    [npmPack] npm notice version:       0.0.1                                   
    [npmPack] npm notice filename:      adp-0.0.1.tgz                           
    [npmPack] npm notice package size:  52.2 kB                                 
    [npmPack] npm notice unpacked size: 439.5 kB                                
    [npmPack] npm notice shasum:        649339a2ee57acd822300a533927389a7ba7fca4
    [npmPack] npm notice integrity:     sha512-3QORIgluBDn09[...]Pm4uUK0k7TSFA==
    [npmPack] npm notice total files:   69                                      
    [npmPack] npm notice 
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 06 Oct 2020 12:38:40 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0780:7374:3D8769E:64C72ED:5F7C6550","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 25, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 079ea18 with merge commit 6875a9b. Schema Automation 13.0.17.20200918.2
    [adp][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [adp][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [adp][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5779 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 06 Oct 2020 12:44:21 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0441:1D09:326CB31:564B7E2:5F7C66A5","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Sep 25, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 079ea18 with merge commit 6875a9b. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @aelij
    Copy link
    Copy Markdown
    Member Author

    aelij commented Sep 25, 2020

    Since this is a new unpublished RP, the breaking change doesn't matter. The original PR was merged earlier today.

    @azure-pipelines
    Copy link
    Copy Markdown

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe
    Copy link
    Copy Markdown
    Member

    lirenhe commented Sep 29, 2020

    @aelij, it seems your change contains breaking change, could you follow the process from http://aka.ms/bcforapi to review this breaking change?

    @azure-pipelines
    Copy link
    Copy Markdown

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    Azure Pipelines successfully started running 1 pipeline(s).

    "Succeeded",
    "Failed",
    "Canceled",
    "Accepted",
    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Why is this enum marked as "modelAsString": false?

    Copy link
    Copy Markdown
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I followed the same pattern for ProvisioningState from other RPs. Why do you think it should it be true? I would like an enum to be generated in the SDK.

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Closed enums (modelAsString: false) have proven to be version intolerant (over time). If you can commit to never, ever add a new provisioning state value, then this is ok.

    @azure-pipelines
    Copy link
    Copy Markdown

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe lirenhe added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-FeedbackProvided labels Oct 6, 2020
    @lirenhe lirenhe merged commit 6875a9b into Azure:master Oct 6, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants