ADP - add missing ProvisioningState#10948
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
|
azure-sdk-for-js - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
|
Since this is a new unpublished RP, the breaking change doesn't matter. The original PR was merged earlier today. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@aelij, it seems your change contains breaking change, could you follow the process from http://aka.ms/bcforapi to review this breaking change? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "Succeeded", | ||
| "Failed", | ||
| "Canceled", | ||
| "Accepted", |
There was a problem hiding this comment.
Why is this enum marked as "modelAsString": false?
There was a problem hiding this comment.
I followed the same pattern for ProvisioningState from other RPs. Why do you think it should it be true? I would like an enum to be generated in the SDK.
There was a problem hiding this comment.
Closed enums (modelAsString: false) have proven to be version intolerant (over time). If you can commit to never, ever add a new provisioning state value, then this is ok.
|
Azure Pipelines successfully started running 1 pipeline(s). |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.