New VPN Protocol from 2018-06-01 REST specs #6418
Conversation
|
@markcowl When will SDK be generated for June 15 release? |
| </None> | ||
| <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests\TestVirtualNetworkGatewayP2SAndSKU.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> |
There was a problem hiding this comment.
remove all changes to this file
| <Reference Include="Microsoft.Azure.Management.Network, Version=19.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.19.0.2-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> |
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "The list of P2S VPN client tunneling protocols")] | ||
| [ValidateSet( |
There was a problem hiding this comment.
Change this from a ValidateSet to an ArgumentCompleter
| HelpMessage = "A list of P2S VPN client tunneling protocols")] | ||
| [ValidateSet( | ||
| MNM.VpnClientProtocol.SSTP, | ||
| MNM.VpnClientProtocol.IkeV2)] |
There was a problem hiding this comment.
Change this from a ValidateSet to an ArgumentCompleter
| <package id="AutoMapper" version="6.0.2" targetFramework="net452" /> | ||
| <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" /> | ||
| <package id="Microsoft.Azure.Management.Network" version="19.0.2-preview" targetFramework="net452" /> | ||
| <package id="Microsoft.Rest.ClientRuntime" version="2.3.11" targetFramework="net452" /> |
There was a problem hiding this comment.
remove all changes to this file
|
@markcowl feedback addressed. |
|
@markcowl Added tests. ArgumentCompleter seems to break powershell inputs, so reverted to original. |
|
@henry416 marking as 'do not merge' until we hear from the folks managing the network sdk |
|
@markcowl Can we target the June 29th release? |
|
@praries880 would you mind taking a look at this PR while Mark is OOF? |
|
@MikhailTryakhov Hey Mikhail, what's the status of this PR? |
|
@cormacpayne We are going to merge the changes into the network branch... heres the PR for that : #6481. @henry416 / @MikhailTryakhov is it ok to close this PR? |
|
@MikhailTryakhov When will we merge Network-2018-06-01 into build? |
|
@MikhailTryakhov do I need to review this PR? this one was closed in favor of |
|
@praries880 I'm not sure why did @henry416 closed this PR. |
|
@MikhailTryakhov Didn't you say that by merging changes into 2018-06-01 branch it will eventually go into June 29th release? We already completed the merge for that in the linked PR #6481 |
|
@henry416 I will merge all the progress from |
|
Clarified with @MikhailTryakhov offline, this PR can remained closed. Changes were merged to Network-2018-06-01 as intended. |
6 participants
Description
Added new VPN protocol from 2018-06-01 REST spec (checked in May 24th)
Azure/azure-rest-api-specs#3133
Checklist
CONTRIBUTING.mdplatyPSmodule