Skip to content

Conversation

@azure-powershell-bot
Copy link
Collaborator

Description

Migrate StackHCIVM from generation to release-2024-03-05
The last commit of src/StackHCIVM in generation is:
commit dff1cf2 Author: hvedati [email protected] Date: Tue Feb 27 19:10:47 2024 -0800 Report Image Download Progress (#24180) * working image download progress * adding reporting download progress logic * adding image recording test * adding marketplace test * Use fixed autorest.powershell version to generate * updating env and recording files * Revert change to README.md * updatig variables and image recording * image test * storage path test * disk recording * updating env variables * logical network test * nic test * fixing networkinterface test * vm test * fixing image test * image recording * fixing image * fix --------- Co-authored-by: Harika Vedati [email protected] Co-authored-by: Lei Jin [email protected] Co-authored-by: Jin Lei [email protected]

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 28, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.StackHCIVM
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzStackHCIVMImage Get-AzStackHCIVMImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMImage Get-AzStackHCIVMImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMLogicalNetwork Get-AzStackHCIVMLogicalNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMLogicalNetwork Get-AzStackHCIVMLogicalNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMNetworkInterface Get-AzStackHCIVMNetworkInterface Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMNetworkInterface Get-AzStackHCIVMNetworkInterface changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMStoragePath Get-AzStackHCIVMStoragePath Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMStoragePath Get-AzStackHCIVMStoragePath changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMVirtualHardDisk Get-AzStackHCIVMVirtualHardDisk Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMVirtualHardDisk Get-AzStackHCIVMVirtualHardDisk changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzStackHCIVMImage Get-AzStackHCIVMImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMImage Get-AzStackHCIVMImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMLogicalNetwork Get-AzStackHCIVMLogicalNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMLogicalNetwork Get-AzStackHCIVMLogicalNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMNetworkInterface Get-AzStackHCIVMNetworkInterface Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMNetworkInterface Get-AzStackHCIVMNetworkInterface changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMStoragePath Get-AzStackHCIVMStoragePath Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMStoragePath Get-AzStackHCIVMStoragePath changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStackHCIVMVirtualHardDisk Get-AzStackHCIVMVirtualHardDisk Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStackHCIVMVirtualHardDisk Get-AzStackHCIVMVirtualHardDisk changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.StackHCIVM. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.StackHCIVM. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@msJinLei msJinLei merged commit beda78b into release-2024-03-05 Feb 28, 2024
isra-fel added a commit that referenced this pull request Mar 1, 2024
* Update ChangeLog.md (#24257)

* Move StackHCIVM to release-2024-03-05 (#24267)

* Add warnings for future breaking changes in Az.Resources policy CRUD … (#24266)

* Update code-gen.yml (#24251)

Use Pwsh for codegen

* Add warnings for future breaking changes in Az.Resources policy CRUD cmdlets (#22691)

* Get-AzPolicyAlias: optmize common path for single namespace

* Update changelog.

* Fox for #15828

* Update changelog

* Add breaking change warnings to Policy CRUD cmdlets.

* Minor changelog correction

* Added per-cmdlet information about upcoming changes
Corrected deprecation version per feedback

* update changelog

---------

Co-authored-by: Chris Stackhouse <[email protected]>

* Update ChangeLog.md

---------

Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
Co-authored-by: Jin Lei <[email protected]>

* Migrate Security from generation to release-2024-03-05 (#24258)

* Move Security to release-2024-03-05

* Update the help files

* Add debug flag

* Add debug flag

* Add debug flag

---------

Co-authored-by: Yunchi Wang <[email protected]>

* Update Change Log for CodeSigning, StackHCIVM and Security (#24268)

* Az.CodeSigning initial version

* Update ChangeLog.md for StackHCIVM

* Update Change Log for Security

* Fix the typo in HelpIndex.ps1 (#24269)

* Remove ProgressAction from help doc (#24276)

* Migrate Cdn from generation to release-2024-03-05 (#24274)

* Move Cdn to release-2024-03-05

* Remove invalid UX metadata

* Update Changelog.md

---------

Co-authored-by: Yunchi Wang <[email protected]>

* Implement new interface IAzurePSSanitizer and ISanitizerService for secrets detection feature (#24249)

* Register IAzurePSSanitizer and ISanitizerService components and implement the functions defined in the interfaces.

* Upload new localfeed and test coverage pipeline to test all scenario tests

* Update live test to include sanitizer

* Register IAzurePSSanitizer and ISanitizerService components and implement the functions defined in the interfaces.

* Enable secrets warning on CI

* Add local build of common lib

* Move secrets detection related objects from common repo to Authentication

* Add change log

* Update config docs and fix issues

* Update src/Accounts/Accounts/ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

---------

Co-authored-by: Yeming Liu <[email protected]>

* fix deprecated version for breaking change announcement (#24284)

* release-2024-03-05 (#24259)

---------

Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: Chris Stackhouse <[email protected]>
Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants