Add warnings for future breaking changes in Az.Resources policy CRUD cmdlets #22691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected deprecation version per feedback
️✔️Az.Accounts
️✔️Az.ApplicationInsights
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 23.08 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 23.08% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 23.08% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 23.08% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.DeploymentManager
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.DevSpaces
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.MachineLearning
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Signature Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ UX Metadata Check
⚠️ PowerShell Core - Windows
Type Module ResourceType SubResourceType Command Description ⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Get-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources ⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Remove-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources
⚠️ Windows PowerShell - Windows
Type Module ResourceType SubResourceType Command Description ⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Get-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources ⚠️ Az.Resources Microsoft.Resources subscriptionsResourcegroups Remove-AzResourceGroup The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources ️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
VeryEarly
approved these changes
Aug 30, 2023
1 task
6 tasks
msJinLei
added a commit
that referenced
this pull request
Feb 28, 2024
#24266) * Update code-gen.yml (#24251) Use Pwsh for codegen * Add warnings for future breaking changes in Az.Resources policy CRUD cmdlets (#22691) * Get-AzPolicyAlias: optmize common path for single namespace * Update changelog. * Fox for #15828 * Update changelog * Add breaking change warnings to Policy CRUD cmdlets. * Minor changelog correction * Added per-cmdlet information about upcoming changes Corrected deprecation version per feedback * update changelog --------- Co-authored-by: Chris Stackhouse <[email protected]> * Update ChangeLog.md --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yan Xu <[email protected]> Co-authored-by: Jin Lei <[email protected]>
isra-fel
added a commit
that referenced
this pull request
Mar 1, 2024
* Update ChangeLog.md (#24257) * Move StackHCIVM to release-2024-03-05 (#24267) * Add warnings for future breaking changes in Az.Resources policy CRUD … (#24266) * Update code-gen.yml (#24251) Use Pwsh for codegen * Add warnings for future breaking changes in Az.Resources policy CRUD cmdlets (#22691) * Get-AzPolicyAlias: optmize common path for single namespace * Update changelog. * Fox for #15828 * Update changelog * Add breaking change warnings to Policy CRUD cmdlets. * Minor changelog correction * Added per-cmdlet information about upcoming changes Corrected deprecation version per feedback * update changelog --------- Co-authored-by: Chris Stackhouse <[email protected]> * Update ChangeLog.md --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yan Xu <[email protected]> Co-authored-by: Jin Lei <[email protected]> * Migrate Security from generation to release-2024-03-05 (#24258) * Move Security to release-2024-03-05 * Update the help files * Add debug flag * Add debug flag * Add debug flag --------- Co-authored-by: Yunchi Wang <[email protected]> * Update Change Log for CodeSigning, StackHCIVM and Security (#24268) * Az.CodeSigning initial version * Update ChangeLog.md for StackHCIVM * Update Change Log for Security * Fix the typo in HelpIndex.ps1 (#24269) * Remove ProgressAction from help doc (#24276) * Migrate Cdn from generation to release-2024-03-05 (#24274) * Move Cdn to release-2024-03-05 * Remove invalid UX metadata * Update Changelog.md --------- Co-authored-by: Yunchi Wang <[email protected]> * Implement new interface IAzurePSSanitizer and ISanitizerService for secrets detection feature (#24249) * Register IAzurePSSanitizer and ISanitizerService components and implement the functions defined in the interfaces. * Upload new localfeed and test coverage pipeline to test all scenario tests * Update live test to include sanitizer * Register IAzurePSSanitizer and ISanitizerService components and implement the functions defined in the interfaces. * Enable secrets warning on CI * Add local build of common lib * Move secrets detection related objects from common repo to Authentication * Add change log * Update config docs and fix issues * Update src/Accounts/Accounts/ChangeLog.md Co-authored-by: Yeming Liu <[email protected]> --------- Co-authored-by: Yeming Liu <[email protected]> * fix deprecated version for breaking change announcement (#24284) * release-2024-03-05 (#24259) --------- Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: Azure PowerShell <[email protected]> Co-authored-by: Chris Stackhouse <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yan Xu <[email protected]> Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Yabo Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add breaking change warnings to Azure Policy CRUD cmdlets in Az.Resources module.
This PR is for #22678.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.