Skip to content

Add alias for some properties to avoid breaking change for keyvault#22424

Merged
Nickcandy merged 1 commit intoAzure:release-2023-08-01from
dolauli:breakingchangefix/keyvault
Jul 26, 2023
Merged

Add alias for some properties to avoid breaking change for keyvault#22424
Nickcandy merged 1 commit intoAzure:release-2023-08-01from
dolauli:breakingchangefix/keyvault

Conversation

@dolauli
Copy link
Contributor

@dolauli dolauli commented Jul 26, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 26, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.KeyVault. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.KeyVault. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.72 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.72% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.72% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.72% Test coverage for the module cannot be lower than 50%.
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@dolauli dolauli force-pushed the breakingchangefix/keyvault branch from 51d3eea to 55d4956 Compare July 26, 2023 04:13
@dolauli dolauli marked this pull request as ready for review July 26, 2023 04:24
@Nickcandy Nickcandy merged commit b239cb0 into Azure:release-2023-08-01 Jul 26, 2023
NoriZC added a commit that referenced this pull request Aug 2, 2023
* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
wyunchi-ms added a commit that referenced this pull request Aug 4, 2023
* Test removing deps.json

* Test removing deps.json

* Merge main (#22470)

* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>

* test removing deps.json2

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
BethanyZhou added a commit that referenced this pull request Aug 7, 2023
dolauli pushed a commit that referenced this pull request Aug 7, 2023
…yvault" (#22510)

* Revert "Add alias for some properties to avoid breaking change for keyvault (#22424)"

This reverts commit b239cb0.

* Create BreakingChangeIssues.csv

* Update ChangeLog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants