Skip to content

[Compute] New cmdlets Get-AzHostSize and Update-AzHost#22381

Merged
Nickcandy merged 4 commits intomainfrom
haagha/azhost
Jul 24, 2023
Merged

[Compute] New cmdlets Get-AzHostSize and Update-AzHost#22381
Nickcandy merged 4 commits intomainfrom
haagha/azhost

Conversation

@haagha
Copy link
Member

@haagha haagha commented Jul 22, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 22, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -HostGroupName $hostGroupName is a null-valued parameter value. -HostGroupName Assign value for $hostGroupName.
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -HostName $hostName is a null-valued parameter value. -HostName Assign value for $hostName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -HostGroupName $hostGroupName is a null-valued parameter value. -HostGroupName Assign value for $hostGroupName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -Name $hostName is a null-valued parameter value. -Name Assign value for $hostName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -Sku $skuName is a null-valued parameter value. -Sku Assign value for $skuName.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -HostGroupName $hostGroupName is a null-valued parameter value. -HostGroupName Assign value for $hostGroupName.
⚠️ 1 1 Unassigned_Variable Get-AzHostSize -HostName $hostName is a null-valued parameter value. -HostName Assign value for $hostName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -HostGroupName $hostGroupName is a null-valued parameter value. -HostGroupName Assign value for $hostGroupName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -Name $hostName is a null-valued parameter value. -Name Assign value for $hostName.
⚠️ 1 1 Unassigned_Variable Update-AzHost -Sku $skuName is a null-valued parameter value. -Sku Assign value for $skuName.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy
Copy link
Contributor

Please fix the online version issue in the help file

@Nickcandy
Copy link
Contributor

@haagha Hi the ci still failed because of the example issue. Please fix it. You could find it here

@Nickcandy
Copy link
Contributor

Nickcandy commented Jul 24, 2023

@haagha Our code freeze would be before PST 07/25 at 0:00. So please fix it ASAP

@Nickcandy Nickcandy merged commit c8e54e2 into main Jul 24, 2023
@BethanyZhou BethanyZhou deleted the haagha/azhost branch July 25, 2023 07:30
Nickcandy added a commit that referenced this pull request Jul 25, 2023
Nickcandy added a commit that referenced this pull request Jul 26, 2023
NoriZC added a commit that referenced this pull request Aug 2, 2023
* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
wyunchi-ms added a commit that referenced this pull request Aug 4, 2023
* Test removing deps.json

* Test removing deps.json

* Merge main (#22470)

* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>

* test removing deps.json2

---------

Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: nanxiangLiu <nanxiangliu@microsoft.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants