Skip to content

Comments

Remove Get-AzVmssVmRunCommand from Autorest generated#19826

Merged
VeryEarly merged 3 commits intogenerationfrom
removeVMRunCommands
Oct 19, 2022
Merged

Remove Get-AzVmssVmRunCommand from Autorest generated#19826
VeryEarly merged 3 commits intogenerationfrom
removeVMRunCommands

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Oct 17, 2022

Description

Removing Get-AzVmssVmRunCommand from autorest generated to write it manually SDK based.
PR adding as a SDK built cmdlet: #19272

Last release, Get-AzVmRunCommand was removed #19267

There is no breaking change, because currently of the 5 parameter sets shown in documentation here:
https://docs.microsoft.com/en-us/powershell/module/az.compute/get-azvmruncommand?view=azps-8.2.0

1st, 2nd, and 5th parameter sets dont work. And what we are adding in the other PR is a combination of 3rd and 4th parameter set.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@VeryEarly VeryEarly merged commit b1e3519 into generation Oct 19, 2022
@VeryEarly VeryEarly deleted the removeVMRunCommands branch October 19, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants