add Get-AzVmRunCommand on SDK built cmdlet#19272
Merged
Conversation
1 task
Member
|
/azp run azure-powershell - powershell-cor |
Contributor
|
No pipelines are associated with this pull request. |
Member
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
isra-fel
approved these changes
Aug 26, 2022
This was referenced Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Get-AzVmRunCommand was originally autorest.powershell generated. But I am removing that from compute.autorest in this pr:
#19267
We are moving it to cmdlet built on SDK because we wanted to achieve two things:
Have all the fields show as a list format when we get back list of RunCommands
Have instanceView only show when -Expand InstanceView
So to achieve these customizations I moved it to cmdlet built on SDK here.
There is no breaking change here because currently from the documentation https://docs.microsoft.com/en-us/powershell/module/az.compute/get-azvmruncommand?view=azps-8.2.0, 1st, 2nd, and 5th(last) parameter sets arent working
And the one parameter set we are adding in this PR is a combination of 3rd and 4th parameter sets by having -RunCommandName as optional.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.