Skip to content

add Get-AzVmRunCommand on SDK built cmdlet#19272

Merged
isra-fel merged 11 commits intomainfrom
feature/cplat-GetAzVMRC
Aug 29, 2022
Merged

add Get-AzVmRunCommand on SDK built cmdlet#19272
isra-fel merged 11 commits intomainfrom
feature/cplat-GetAzVMRC

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Aug 19, 2022

Description

Get-AzVmRunCommand was originally autorest.powershell generated. But I am removing that from compute.autorest in this pr:
#19267

We are moving it to cmdlet built on SDK because we wanted to achieve two things:
Have all the fields show as a list format when we get back list of RunCommands
Have instanceView only show when -Expand InstanceView

So to achieve these customizations I moved it to cmdlet built on SDK here.

There is no breaking change here because currently from the documentation https://docs.microsoft.com/en-us/powershell/module/az.compute/get-azvmruncommand?view=azps-8.2.0, 1st, 2nd, and 5th(last) parameter sets arent working

And the one parameter set we are adding in this PR is a combination of 3rd and 4th parameter sets by having -RunCommandName as optional.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-cor

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants